Skip to contentSkip to conversation

ASoC: amd: acp: return irq error directly

PATCH In review Rosen Penev 3 participants 3 messages Aug 7 – Aug 8

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: acp: return irq error directly

platform_get_irq() returns multiple error codes. Return the irq directly instead of just -ENODEV.

---
 sound/soc/amd/acp-pcm-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/acp-pcm-dma.c +1 -1
index baf4b41e54df..e99588458ed8 100644
@@ -1292,7 +1292,7 @@ static int acp_audio_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
-		return -ENODEV;
+		return irq;
 
 	status = devm_request_irq(&pdev->dev, irq, dma_irq_handler,
 				  0, "ACP_IRQ", &pdev->dev);
Signature · 1 line
2.55.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Rosen Penev

platform_get_irq() returns multiple error codes. Return the irq directly instead of just -ENODEV.

Quoted 17 lines
---
  sound/soc/amd/acp-pcm-dma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/acp-pcm-dma.c +1 -1
index baf4b41e54df..e99588458ed8 100644
@@ -1292,7 +1292,7 @@ static int acp_audio_probe(struct platform_device *pdev)
 
  	irq = platform_get_irq(pdev, 0);
  	if (irq < 0)
-		return -ENODEV;
+		return irq;
 
  	status = devm_request_irq(&pdev->dev, irq, dma_irq_handler,
  				  0, "ACP_IRQ", &pdev->dev);
maintainer
#2 lore raw
In reply to Rosen Penev
Quoted 1 line · Rosen Penev

ASoC: amd: acp: return irq error directly

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: amd: acp: return irq error directly

      https://git.kernel.org/broonie/sound/c/e04cf4dd5faa

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark