Skip to contentSkip to conversation

mm-damon-core-initialize-damos-last_applied.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Aug 7 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: mm/damon/core: initialize damos->last_applied

has been removed from the -mm tree. Its filename was
mm-damon-core-initialize-damos-last_applied.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SJ Park <[email protected]>
Subject: mm/damon/core: initialize damos->last_applied
Date: Fri, 17 Jul 2026 17:14:35 -0700

Patch series "mm/damon: fix uninitialized DAMOS field and kunit exec expectation bugs".

Fix a few Sashiko-found unurgent bugs. Patch 1 fixes use of uninitialized damos->last_applied field. Patches 2-7 fix DAMON kunit tests that do invalid memory access under test failures.

The bugs are better to be fixed and eventually merged into stable@ kernel. That said, the fixes are arguably not urgent. Patch 1 only introduces negligible DAMOS efficiency degradation in occasional cases. Kunit fixes could introduce quite bad consequences but those are test code that affect only test run setups.

This patch (of 7):

Multiple DAMON regions could exist across a folio. If they fulfill the condition to apply a DAMOS scheme, the scheme could be applied multiple times to the folio. To avoid this, each DAMOS scheme stores the folio that the scheme was applied to last time in the damos->last_applied field and skips repeatedly applying the same scheme to the same folio.

The field is being used without initialization, though. Hence, the mechanism could wrongly skip applying a scheme to a folio at the very first time of DAMOS run.

The user impact is trivial. DAMON might unexpectedly skip applying DAMOS action for one folio for the first time per scheme. In the DAMON's best-effort world, this is never a real problem. No critical consequences such as kernel panic or memory corruption happen.

It is a clear bug, though, and the fix is straightforward. Fix the issue by initializing the field in DAMOS scheme creation function, damon_new_scheme().

The issue was discovered [1] by Sashiko.

Fixes 94ba17adaba0 ("mm/damon: avoid applying DAMOS action to same entity multiple times")
Cc Brendan Higgins <[email protected]>
Cc <[email protected]> # 6.15.x

---

 mm/damon/core.c |    1 +
 1 file changed, 1 insertion(+)
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-initialize-damos-last_applied +1 -0
@@ -705,6 +705,7 @@ struct damos *damon_new_scheme(struct da
 	INIT_LIST_HEAD(&scheme->ops_filters);
 	scheme->stat = (struct damos_stat){};
 	scheme->max_nr_snapshots = 0;
+	scheme->last_applied = NULL;
 	INIT_LIST_HEAD(&scheme->list);
 
 	scheme->quota = *(damos_quota_init(quota));

_

Patches currently in -mm which might be from [email protected] are