ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
Subsystems (3)
PATCH 1/1 ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
The IRQ handler only needs the audio_drv_data, so pass it directly as the request_irq argument instead of the device pointer and a dev_get_drvdata() lookup.
--- sound/soc/amd/acp-pcm-dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
sound/soc/amd/acp-pcm-dma.c +2 -4
@@ -692,12 +692,10 @@ static irqreturn_t dma_irq_handler(int irq, void *arg) {u16 dscr_idx;u32 intr_flag, ext_intr_status; -struct audio_drv_data *irq_data; +struct audio_drv_data *irq_data = arg;void __iomem *acp_mmio; -struct device *dev = arg;bool valid_irq = false; - irq_data =dev_get_drvdata (dev); acp_mmio = irq_data->acp_mmio; ext_intr_status =acp_reg_read (acp_mmio, mmACP_EXTERNAL_INTR_STAT);
@@ -1295,7 +1293,7 @@ static int acp_audio_probe(struct platform_device *pdev)return irq; status =devm_request_irq (&pdev->dev, irq, dma_irq_handler, -0 ,"ACP_IRQ" , &pdev->dev); +0 ,"ACP_IRQ" , audio_drv_data);if (status) {dev_err (&pdev->dev,"ACP IRQ request failed\n" );return status;
Signature · 1 line
2.55.0
Mark Brown
maintainerQuoted 1 line · Rosen Penev
ASoC: amd: acp: pass
audio_drv_datatodma_irq_handler
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/1] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
https://git.kernel.org/broonie/sound/c/0196c4b4f82b
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark