Skip to contentSkip to conversation

python3-setuptools-rust: remove wheel dependency

PATCH In review Ross Burton 2 participants 5 messages Aug 11 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 python3-setuptools-rust: remove wheel dependency

The dependency on wheel was removed in 2021[1].

[1] https://github.com/PyO3/setuptools-rust/commit/1d7ee9fc239c846fdd5aac5f3a28705333d47d77

---
 meta/recipes-devtools/python/python3-setuptools-rust_1.13.0.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-devtools/python/python3-setuptools-rust_1.13.0.bb +1 -2
index 884d6a6771e..ecb2169a3f6 100644
@@ -16,7 +16,7 @@ PYPI_PACKAGE = "setuptools_rust"
 
 inherit cargo pypi python_setuptools_build_meta
 
-DEPENDS += "python3-setuptools-scm-native python3-wheel-native"
+DEPENDS += "python3-setuptools-scm-native"
 
 RDEPENDS:${PN} += " \
     python3-json \
@@ -25,7 +25,6 @@ RDEPENDS:${PN} += " \
     python3-setuptools-scm \
     python3-shell \
     python3-typing-extensions \
-    python3-wheel \
 "
 
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/4 classes/python_mesonpy: remove wheel dependency

This class has never needed the wheel package, as it builds wheels on its own. I suspect this was copy-pasted from the setuptools classes.

---
 meta/classes-recipe/python_mesonpy.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/python_mesonpy.bbclass +1 -1
index 3613ea19c76..0ad1c970a9f 100644
@@ -17,7 +17,7 @@ meson_do_qa_configure () {
 # ERROR: Got argument buildtype as both -Dbuildtype and --buildtype. Pick one.
 MESONOPTS:remove = "--buildtype ${MESON_BUILDTYPE}"
 
-DEPENDS += "python3-wheel-native python3-meson-python-native"
+DEPENDS += "python3-meson-python-native"
 
 def mesonpy_get_args(d):
     vars = ['MESONOPTS', 'MESON_CROSS_FILE', 'EXTRA_OEMESON']
Signature · 1 line
2.43.0
#2 lore raw

PATCH 3/4 classes/setuptools3: remove wheel dependency

In reply to Ross Burton

Historically, setuptools provided most of the build commands but the wheel package provided bdist_wheel.

However, as of setuptools 70.1.0[1], this command is part of setuptools itself and the wheel package is not required.

[1] https://github.com/pypa/setuptools/commit/b3d3e93a834426f1bef8712e1405495084eb3b7f

---
 meta/classes-recipe/setuptools3.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/setuptools3.bbclass +1 -1
index 0bbe3780231..c6578f27de7 100644
@@ -6,7 +6,7 @@
 
 inherit setuptools3-base python_pep517
 
-DEPENDS += "python3-setuptools-native python3-wheel-native"
+DEPENDS += "python3-setuptools-native"
 
 SETUPTOOLS_BUILD_ARGS ?= ""
 
Signature · 1 line
2.43.0
#3 lore raw

PATCH 4/4 classes/python_setuptools_build_meta: remove wheel dependency

In reply to Ross Burton

Historically, setuptools provided most of the build commands but the wheel package provided bdist_wheel.

However, as of setuptools 70.1.0[1], this command is part of setuptools itself and the wheel package is not required.

[1] https://github.com/pypa/setuptools/commit/b3d3e93a834426f1bef8712e1405495084eb3b7f

---
 meta/classes-recipe/python_setuptools_build_meta.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/python_setuptools_build_meta.bbclass +1 -1
index f09f7e9a918..d488debdb0e 100644
@@ -6,7 +6,7 @@
 
 inherit python_pep517
 
-DEPENDS += "python3-setuptools-native python3-wheel-native"
+DEPENDS += "python3-setuptools-native"
 
 # This isn't nice, but is the best solutions to ensure clean builds for now.
 # https://github.com/pypa/setuptools/issues/4732
Signature · 1 line
2.43.0
#4 lore raw

Re: [OE-core] [PATCH 4/4] classes/python_setuptools_build_meta: remove wheel dependency

Quoted 6 lines · Ross Burton via lists.openembedded.org

Historically, setuptools provided most of the build commands but the wheel package provided bdist_wheel.

However, as of setuptools 70.1.0[1], this command is part of setuptools itself and the wheel package is not required.

Quoted 6 lines

[1] https://github.com/pypa/setuptools/commit/b3d3e93a834426f1bef8712e1405495084eb3b7f

---
 meta/classes-recipe/python_setuptools_build_meta.bbclass | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

One of the changes breaks python3-qemu-qmp:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/50/builds/4402

I suspect it needs the wheel dependency adding...

I'll test a patch.

Cheers,

Richard