mtd: rawnand: brcmnand: Propagate errors from optional IRQ lookup
PATCH 1/1 mtd: rawnand: brcmnand: Propagate errors from optional IRQ lookup
From: bui duc phuc <[email protected]>
platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available, in which case the driver falls back to using the ctlrdy IRQ. Other errors should be propagated so that the caller can handle them appropriately.
Treat -ENXIO as the only case where the driver falls back to the ctlrdy IRQ, and propagate all other errors returned by platform_get_irq_optional().
--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/mtd/nand/raw/brcmnand/brcmnand.c +2 -0
@@ -3272,6 +3272,8 @@ static int brcmnand_edu_setup(struct platform_device *pdev) ctrl->edu_irq =platform_get_irq_optional (pdev,1 );if (ctrl->edu_irq <0 ) { +if (ctrl->edu_irq != -ENXIO ) +return ctrl->edu_irq;dev_warn (dev,"FLASH EDU enabled, using ctlrdy irq\n" ); }else {
Signature · 1 line
2.43.0
Quoted 11 lines · On Wed, 12 Aug 2026 17:37:28 +0700, [email protected] wrote:
platform_get_irq_optional()returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ,-ENXIOindicates that no optional IRQ is available, in which case the driver falls back to using the ctlrdy IRQ. Other errors should be propagated so that the caller can handle them appropriately.Treat
-ENXIOas the only case where the driver falls back to the ctlrdy IRQ, and propagate all other errors returned byplatform_get_irq_optional().[...]
Applied to nand/next, thanks!
[1/1] mtd: rawnand: brcmnand: Propagate errors from optional IRQ lookup
commit: c9e20e213bb051d02711155de0dc4759de2faddf
Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).
Kind regards,
Miquèl