EDAC/xgene: Use platform_get_irq() for IRQ lookup
Subsystems (2)
PATCH 1/1 EDAC/xgene: Use platform_get_irq() for IRQ lookup
From: bui duc phuc <[email protected]>
The probe function propagates any negative return value from platform_get_irq_optional() and aborts the probe. Therefore, the optional IRQ semantics of platform_get_irq_optional() are not used here.
Use platform_get_irq() instead, which matches the existing error handling by propagating any IRQ lookup error.
platform_get_irq() also reports lookup errors itself, so remove the redundant error message from the driver.
--- drivers/edac/xgene_edac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/edac/xgene_edac.c +1 -2
@@ -1915,9 +1915,8 @@ static int xgene_edac_probe(struct platform_device *pdev)int i;for (i =0 ; i <3 ; i++) { - irq =platform_get_irq_optional (pdev, i); + irq =platform_get_irq (pdev, i);if (irq <0 ) { -dev_err (&pdev->dev,"No IRQ resource\n" ); rc = irq; goto out_err; }
Signature · 1 line
2.43.0
Borislav Petkov
maintainerQuoted 24 lines · On Fri, Aug 14, 2026 at 11:53:47AM +0700, [email protected] wrote:
From: bui duc phuc <[email protected]>
The probe function propagates any negative return value from
platform_get_irq_optional()and aborts the probe. Therefore, the optional IRQ semantics ofplatform_get_irq_optional()are not used here.Use
platform_get_irq()instead, which matches the existing error handling by propagating any IRQ lookup error.
platform_get_irq()also reports lookup errors itself, so remove the redundant error message from the driver.Signed-off-by bui duc phuc <[email protected]>--- drivers/edac/xgene_edac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/edac/xgene_edac.c +0
-0
drivers/edac/xgene_edac.c static int xgene_edac_probe(struct platform_device *pdev) · line 1922
Quoted 10 lines
drivers/edac/xgene_edac.c +1
-2@@ -1915,9 +1915,8 @@ static int xgene_edac_probe(struct platform_device *pdev)int i;for (i =0 ; i <3 ; i++) { - irq =platform_get_irq_optional (pdev, i); + irq =platform_get_irq (pdev, i);if (irq <0 ) { -dev_err (&pdev->dev,"No IRQ resource\n" ); rc = irq; goto out_err; }
So this driver received a new maintainer here:
49b35cd5e7dd ("MAINTAINERS: Update Ampere email address")
and I don't remember seeing it. But ok, water under the bridge, that's looong time ago.
Sashiko reports a bunch of preexisting issues:
https://sashiko.dev/#/patchset/20260814045347.13841-1-phucduc.bui%40gmail.com
which need to be addressed before anything else.
So let's see if Khuong responds. Otherwise, I'm marking this driver as orphan too and we're done with more obsolete stuff.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteHi Borislav,
Thank you for your feedback.
Quoted 7 lines
So this driver received a new maintainer here:
49b35cd5e7dd("MAINTAINERS: Update Ampere email address")and I don't remember seeing it. But ok, water under the bridge, that's looong time ago.
Quoted 9 lines
Sashiko reports a bunch of preexisting issues:
https://sashiko.dev/#/patchset/20260814045347.13841-1-phucduc.bui%40gmail.com
which need to be addressed before anything else.
So let's see if Khuong responds. Otherwise, I'm marking this driver as orphan too and we're done with more obsolete stuff.
Understood. I’ll wait for further feedback.
Best regards,
Phuc
Borislav Petkov
maintainerPATCH 1/1 MAINTAINERS: Orphan drivers/edac/xgene_edac.c
From: "Borislav Petkov (AMD)" <[email protected]>
Date: Tue, 15 Sep 2026 19:12:01 -0700
It looks forgotten, no one has the hardware to test, orphan it.
--- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
@@ -2076,8 +2076,7 @@ S: Supported F: arch/arm64/boot/dts/apm/ APPLIED MICRO (APM) X-GENE SOC EDAC -M: Khuong Dinh <[email protected]> -S: Supported +S: Orphan F: Documentation/devicetree/bindings/edac/apm,xgene-edac.yaml F: drivers/edac/xgene_edac.c
Signature · 8 lines
2.53.0
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette