Skip to contentSkip to conversation

staging: greybus: use sysfs_emit() in show functions

PATCH New Malathi 1 participant 1 message Aug 14

Subsystems (3)
Staging Greybus Greybus SDIO/GPIO/SPI protocols drivers
lore
Share & tools
lore

Malathi

author
#0 lore raw

PATCH 1/1 staging: greybus: use sysfs_emit() in show functions

Documentation/filesystems/sysfs.rst recommends that show() callbacks use sysfs_emit() instead of sprintf(). sysfs_emit() knows the sysfs output buffer starts at the beginning of a page and is bounded by PAGE_SIZE, so it guards against accidental buffer overruns.

Convert the sprintf() calls in the protocol_id, fade_in, fade_out and color attribute show functions accordingly. No functional change.

Signed-off-by Malathi <[email protected]>
---
 drivers/staging/greybus/gbphy.c | 2 +-
 drivers/staging/greybus/light.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/gbphy.c +1 -1
index bdb0f5164a6f..bb9a5b538e6e 100644
@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
 {
 	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
 
-	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
+	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
 }
 static DEVICE_ATTR_RO(protocol_id);
drivers/staging/greybus/light.c +2 -2
index cab02b5da867..2689f9a7524a 100644
@@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev,			\
 	struct led_classdev *cdev = dev_get_drvdata(dev);		\
 	struct gb_channel *channel = get_channel_from_cdev(cdev);	\
 									\
-	return sprintf(buf, "%u\n", channel->fade_##__dir);		\
+	return sysfs_emit(buf, "%u\n", channel->fade_##__dir);		\
 }									\
 									\
 static ssize_t fade_##__dir##_store(struct device *dev,			\

@@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr,
 	struct led_classdev *cdev = dev_get_drvdata(dev);
 	struct gb_channel *channel = get_channel_from_cdev(cdev);
 
-	return sprintf(buf, "0x%08x\n", channel->color);
+	return sysfs_emit(buf, "0x%08x\n", channel->color);
 }
 
 static ssize_t color_store(struct device *dev, struct device_attribute *attr,
Signature · 1 line
2.43.0