Skip to contentSkip to conversation

spi: dw: Remove shadowed dws in dw_spi_setup()

PATCH In review Liang Hao 2 participants 2 messages Aug 14 SPI

lore
Share & tools
lore

Liang Hao

author
#0 lore raw

PATCH 1/1 spi: dw: Remove shadowed dws in dw_spi_setup()

The controller private data is already fetched at the start of dw_spi_setup(). Drop the redundant inner declaration that shadows it.

---
 drivers/spi/spi-dw-core.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-dw-core.c +0 -1
index dfce2fa20adf..206d3f9dd83d 100644
@@ -1098,7 +1098,6 @@ static int dw_spi_setup(struct spi_device *spi)
 	/* Only alloc on first setup */
 	chip = spi_get_ctldata(spi);
 	if (!chip) {
-		struct dw_spi *dws = spi_controller_get_devdata(spi->controller);
 		u32 rx_sample_dly_ns;
 
 		chip = kzalloc_obj(*chip);
Signature · 1 line
2.50.1 (Apple Git-155)
maintainer
#1 lore raw
Quoted 1 line · Liang Hao

spi: dw: Remove shadowed dws in dw_spi_setup()

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.3

Thanks!

[1/1] spi: dw: Remove shadowed dws in dw_spi_setup()

      https://git.kernel.org/broonie/spi/c/11dfeb73d1f9

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark