Skip to contentSkip to conversation

scripts: Make the code use consistent syntax

PATCH In review Bhaskar Chowdhury 2 participants 2 messages Aug 17 – Aug 18 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts: Make the code use consistent syntax

The code was using a different form of syntax. So, make it more consistent with a similar kind of syntax.

---
 scripts/mkcompile_h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mkcompile_h +1 -1
index 2596f78e52ef..bf0d5669d9bc 100755
@@ -11,7 +11,7 @@ else
 	LINUX_COMPILE_BY=$KBUILD_BUILD_USER
 fi
 if test -z "$KBUILD_BUILD_HOST"; then
-	LINUX_COMPILE_HOST=`uname -n`
+	LINUX_COMPILE_HOST=$(uname -n)
 else
 	LINUX_COMPILE_HOST=$KBUILD_BUILD_HOST
 fi

--
2.54.0

#1 lore raw
Quoted 2 lines

The code was using a different form of syntax. So, make it more consistent with a similar kind of syntax.

Please make the commit subject and message more descriptive for what is being modified (scripts/mkcompile_h, not scripts in general) and how/why it is being modified. What you have is just too generic in my opinion. Maybe something like

scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

The assignment of LINUX_COMPILE_HOST uses the classic backtick style for its command substitution but the rest of the script uses the more common '$()'. Update LINUX_COMPILE_HOST to match for consistency.

Otherwise, change itself seems fine. I will pick up your next revision for 7.4 when 7.3-rc1 is out.

Signature · 2 lines
Cheers,
Nathan