Skip to contentSkip to conversation

drm/ttm: two small ttm_bo.c cleanups

PATCH Superseded Sean Chang 2 participants 5 messages Aug 18

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Sean Chang

author
#0 lore raw

cover drm/ttm: two small ttm_bo.c cleanups

This series contains two independent, minor cleanups to drivers/gpu/drm/ttm/ttm_bo.c found while auditing the file. They do not depend on each other and could be applied in either order or separately.

Patch 1 removes a stale @ctx kernel-doc entry left over from an earlier struct change, fixing a kernel-doc / W=1 mismatch warning.

Patch 2 gives ttm_swap_ops static linkage since it is not used outside this file and is not exported, fixing a sparse "was not declared, should it be static?" warning.

Both patches were build-tested with make W=1 C=2.

Sean Chang (2):
drm/ttm: drop stale @ctx kernel-doc entry
drm/ttm: make ttm_swap_ops static

 drivers/gpu/drm/ttm/ttm_bo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 1/2 drm/ttm: drop stale @ctx kernel-doc entry

ttm_bo_alloc_state no longer has a ctx member, but its kernel-doc comment still documents @ctx. Remove the stale entry so the documentation matches the struct.

---
 drivers/gpu/drm/ttm/ttm_bo.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +0 -1
index ef56c18ded1b..943297b49dc5 100644
@@ -506,7 +506,6 @@ struct ttm_bo_alloc_state {
  *
  * @bo: The buffer to allocate the backing store of
  * @place: The place to attempt allocation in
- * @ctx: ttm_operation_ctx associated with this allocation
  * @force_space: If we should evict buffers to force space
  * @res: On allocation success, the resulting struct ttm_resource.
  * @alloc_state: Object holding allocation state such as charged cgroups.
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message incorrectly claims it is fixing the documentation for `struct…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly claims it is fixing the documentation for struct ttm_bo_alloc_state rather than the function ttm_bo_alloc_at_place(). --

--- Patch [1]: [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry --- commit eda6deffe5de61d4cef4644920a61899181f3f40
Author: Sean Chang <[email protected]>

drm/ttm: drop stale @ctx kernel-doc entry

This commit removes a stale @ctx kernel-doc entry in ttm_bo.c to fix a documentation mismatch.

Quoted 3 lines

ttm_bo_alloc_state no longer has a ctx member, but its kernel-doc comment still documents @ctx. Remove the stale entry so the documentation matches the struct.

[Severity: Low]
This isn't a bug, but is this description accurate?

The commit message states the documentation for struct ttm_bo_alloc_state is being fixed, but the modified kernel-doc block actually documents the function ttm_bo_alloc_at_place().

It appears the diff chunk header below mistakenly picked up the struct definition from earlier in the file, which may have caused the confusion.

Quoted 12 lines
drivers/gpu/drm/ttm/ttm_bo.c +0 -1
index ef56c18ded1b8..943297b49dc53 100644
@@ -506,7 +506,6 @@ struct ttm_bo_alloc_state {
  *
  * @bo: The buffer to allocate the backing store of
  * @place: The place to attempt allocation in
- * @ctx: ttm_operation_ctx associated with this allocation
  * @force_space: If we should evict buffers to force space
  * @res: On allocation success, the resulting struct ttm_resource.
  * @alloc_state: Object holding allocation state such as charged cgroups.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author
#3 lore raw

Re: [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry

Quoted 8 lines · On Wed, Aug 19, 2026 at 12:13 AM <[email protected]> wrote:
Quoted 4 lines

ttm_bo_alloc_state no longer has a ctx member, but its kernel-doc comment still documents @ctx. Remove the stale entry so the documentation matches the struct.

[Severity: Low]
This isn't a bug, but is this description accurate?

Quoted 7 lines

The commit message states the documentation for struct ttm_bo_alloc_state is being fixed, but the modified kernel-doc block actually documents the function ttm_bo_alloc_at_place().

It appears the diff chunk header below mistakenly picked up the struct definition from earlier in the file, which may have caused the confusion.

Yeah, I type the wrong function name, fixing that in the next v2 patch.

Best Regard,
Sean

author
#4 lore raw

PATCH 2/2 drm/ttm: make ttm_swap_ops static

In reply to Sean Chang

ttm_swap_ops is not used outside ttm_bo.c and is not exported via EXPORT_SYMBOL(), so give it static linkage to keep it file-local and avoid polluting the global symbol namespace.

---
 drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +1 -1
index 943297b49dc5..1b9477381a1d 100644
@@ -1449,7 +1449,7 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo)
 	return ret;
 }
 
-const struct ttm_lru_walk_ops ttm_swap_ops = {
+static const struct ttm_lru_walk_ops ttm_swap_ops = {
 	.process_bo = ttm_bo_swapout_cb,
 };
 
Signature · 1 line
2.43.0