Skip to contentSkip to conversation

memblock: simplify reset_all_zones_managed_pages()

PATCH Applied Sang-Heon Jeon 2 participants 2 messages Aug 19 – Aug 23

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memblock: simplify reset_all_zones_managed_pages()

reset_all_zones_managed_pages() is only called from memblock_free_all(), which runs once during boot.

So remove the reset_managed_pages_done guard, make the function static and drop its declaration.

No functional change.

---
 include/linux/memblock.h | 1 -
 mm/memblock.c            | 9 +--------
 2 files changed, 1 insertion(+), 9 deletions(-)
include/linux/memblock.h +0 -1
index 5afcd99aa8c1..83dc821b23ad 100644
@@ -160,7 +160,6 @@ int memblock_mark_kho_scratch(phys_addr_t base, phys_addr_t size);
 int memblock_clear_kho_scratch(phys_addr_t base, phys_addr_t size);
 
 void memblock_free(void *ptr, size_t size);
-void reset_all_zones_managed_pages(void);
 
 /* Low level functions */
 void __next_mem_range(u64 *idx, int nid, enum memblock_flags flags,
mm/memblock.c +1 -8
index 43e036f3e11a..5954d005dbb1 100644
@@ -2368,8 +2368,6 @@ static unsigned long __init free_low_memory_core_early(void)
 	return count;
 }
 
-static int reset_managed_pages_done __initdata;
-
 static void __init reset_node_managed_pages(pg_data_t *pgdat)
 {
 	struct zone *z;
@@ -2378,17 +2376,12 @@ static void __init reset_node_managed_pages(pg_data_t *pgdat)
 		atomic_long_set(&z->managed_pages, 0);
 }
 
-void __init reset_all_zones_managed_pages(void)
+static void __init reset_all_zones_managed_pages(void)
 {
 	struct pglist_data *pgdat;
 
-	if (reset_managed_pages_done)
-		return;
-
 	for_each_online_pgdat(pgdat)
 		reset_node_managed_pages(pgdat);
-
-	reset_managed_pages_done = 1;
 }
 
 /**
Signature · 1 line
2.43.0