Skip to contentSkip to conversation

FAILED: patch "[PATCH] Input: byd - synchronize timer deletion before freeing" failed to apply to 5.10-stable tree

PATCH In review [email protected] 3 participants 4 messages Aug 20 – Oct 23

Subsystems (2)
Stable branch Input drivers
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x c83e79c0842ed29860648bcce5022ef0ba5001c6
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026082046-impound-leverage-8771@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..'

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From c83e79c0842ed29860648bcce5022ef0ba5001c6 Mon Sep 17 00:00:00 2001
From: Linmao Li <[email protected]>
Date: Mon, 20 Jul 2026 14:12:59 +0800
Subject: [PATCH] Input: byd - synchronize timer deletion before freeing
private data

byd_disconnect() uses timer_delete() before freeing the driver's private data. This does not wait for a running byd_clear_touch() callback, which dereferences the private data and its psmouse pointer. A callback racing with disconnect can therefore access the private data after it has been freed. The timer can also still be re-armed by byd_process_byte() while the disconnect is in progress.

Use timer_shutdown_sync() before freeing the private data: it waits for a running callback and turns any later re-arm attempt into a no-op.

Fixes 2d5f5611dd0d ("Input: byd - enable absolute mode")
Cc [email protected]
Signed-off-by Linmao Li <[email protected]>
Link https://patch.msgid.link/[email protected] open here
Signed-off-by Dmitry Torokhov <[email protected]>
drivers/input/mouse/byd.c +1 -1
index f5770a3af2f1..5fc3c629590a 100644
@@ -423,7 +423,7 @@ static void byd_disconnect(struct psmouse *psmouse)
 	struct byd_data *priv = psmouse->private;
 
 	if (priv) {
-		timer_delete(&priv->timer);
+		timer_shutdown_sync(&priv->timer);
 		kfree(psmouse->private);
 		psmouse->private = NULL;
 	}
maintainer
#1 lore raw

PATCH 1/1 Input: byd - synchronize timer deletion before freeing private data

From: Linmao Li <[email protected]>

[ Upstream commit c83e79c0842ed29860648bcce5022ef0ba5001c6 ]

byd_disconnect() uses timer_delete() before freeing the driver's private data. This does not wait for a running byd_clear_touch() callback, which dereferences the private data and its psmouse pointer. A callback racing with disconnect can therefore access the private data after it has been freed. The timer can also still be re-armed by byd_process_byte() while the disconnect is in progress.

Use timer_shutdown_sync() before freeing the private data: it waits for a running callback and turns any later re-arm attempt into a no-op.

Fixes 2d5f5611dd0d ("Input: byd - enable absolute mode")
Cc [email protected]
Signed-off-by Linmao Li <[email protected]>
Link https://patch.msgid.link/[email protected] open here
Signed-off-by Dmitry Torokhov <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
---
 drivers/input/mouse/byd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/byd.c +1 -1
index 6e0c5f5a2713d..1a0956520dcbe 100644
@@ -426,7 +426,7 @@ static void byd_disconnect(struct psmouse *psmouse)
 	struct byd_data *priv = psmouse->private;
 
 	if (priv) {
-		del_timer(&priv->timer);
+		timer_delete_sync(&priv->timer);
 		kfree(psmouse->private);
 		psmouse->private = NULL;
 	}
Signature · 1 line
2.53.0
#2 lore raw

Re: [PATCH 5.10.y] Input: byd - synchronize timer deletion before freeing private data

Hi.

Is there a reason why this wasn't merged ?

Le 24/08/2026 à 18:26, Sasha Levin a écrit :

Quoted 37 lines

From: Linmao Li <[email protected]>

[ Upstream commit c83e79c0842ed29860648bcce5022ef0ba5001c6 ]

byd_disconnect() uses timer_delete() before freeing the driver's private data. This does not wait for a running byd_clear_touch() callback, which dereferences the private data and its psmouse pointer. A callback racing with disconnect can therefore access the private data after it has been freed. The timer can also still be re-armed by byd_process_byte() while the disconnect is in progress.

Use timer_shutdown_sync() before freeing the private data: it waits for a running callback and turns any later re-arm attempt into a no-op.

Fixes 2d5f5611dd0d ("Input: byd - enable absolute mode")
Cc [email protected]
Signed-off-by Linmao Li <[email protected]>
Link https://patch.msgid.link/[email protected] open here
Signed-off-by Dmitry Torokhov <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
---
  drivers/input/mouse/byd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/byd.c +1 -1
index 6e0c5f5a2713d..1a0956520dcbe 100644
@@ -426,7 +426,7 @@ static void byd_disconnect(struct psmouse *psmouse)
  	struct byd_data *priv = psmouse->private;
 
  	if (priv) {
-		del_timer(&priv->timer);
+		timer_delete_sync(&priv->timer);
  		kfree(psmouse->private);
  		psmouse->private = NULL;
  	}
Signature · 3 lines
Miguel Gazquez, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#3 lore raw

Re: [PATCH 5.10.y] Input: byd - synchronize timer deletion before freeing private data

Quoted 1 line

Is there a reason why this wasn't merged ?

No, those were missed. Both are queued now for 5.15 and 5.10.

Signature · 2 lines
Thanks,
Sasha