mm/vmscan: fix comment logic in balance_pgdat
Subsystems (3)
PATCH v2 1/1 mm/vmscan: fix comment logic in balance_pgdat
In balance_pgdat(), when the low watermark is met, processes sleeping on pfmemalloc_wait are woken up because they are able to safely make forward progress.
However, the comment incorrectly states "they should not be able", which contradicts the actual code behavior. Fix this typo to accurately reflect the logic.
No functional changes are introduced.
--- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmscan.c +1 -1
@@ -7188,7 +7188,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * If the low watermark is met there is no need for processes -* to be throttled on pfmemalloc_wait as they should not be +* to be throttled on pfmemalloc_wait as they should now be * able to safely make forward progress. Wake them */ if (waitqueue_active(&pgdat->pfmemalloc_wait) &&
Signature · 1 line
2.39.5
Quoted 5 lines · Enlin Mu
In
balance_pgdat(), when the low watermark is met, processes sleeping onpfmemalloc_waitare woken up because they are able to safely make forward progress.
Quoted 8 lines
However, the comment incorrectly states "they should not be able", which contradicts the actual code behavior. Fix this typo to accurately reflect the logic.
No functional changes are introduced.
Signed-off-by Enlin Mu <[email protected]>Signed-off-by Enlin Mu <[email protected]>
Thanks to Johannes for pointing out the "not" and "now" issues in v1.
I followed Johannes's comments. I also feel that the patch looks good.
Quoted 4 lines · Enlin Mu
In
balance_pgdat(), when the low watermark is met, processes sleeping onpfmemalloc_waitare woken up because they are able to safely make forward progress.
Quoted 8 lines
However, the comment incorrectly states "they should not be able", which contradicts the actual code behavior. Fix this typo to accurately reflect the logic.
No functional changes are introduced.
Signed-off-by Enlin Mu <[email protected]>Signed-off-by Enlin Mu <[email protected]>
Looks good, thanks for updating the patch.
Quoted 4 lines · Enlin Mu
In
balance_pgdat(), when the low watermark is met, processes sleeping onpfmemalloc_waitare woken up because they are able to safely make forward progress.
Quoted 8 lines
However, the comment incorrectly states "they should not be able", which contradicts the actual code behavior. Fix this typo to accurately reflect the logic.
No functional changes are introduced.
Signed-off-by Enlin Mu <[email protected]>Signed-off-by Enlin Mu <[email protected]>