Skip to contentSkip to conversation

fs: Kconfig: Alignment of code and text in the FS_DAX help section for better readability

PATCH Superseded Bhaskar Chowdhury 2 participants 2 messages Aug 21 – Aug 23 VFS

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: Kconfig: Alignment of code and text in the FS_DAX help section for better readability

I thought eliminating the line break and add an empty line would improve the readability.

---
 fs/Kconfig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
fs/Kconfig +3 -4
index e05917adcd60..c341d364d53f 100644
@@ -71,11 +71,10 @@ config FS_DAX
 	  struct pages.  For the nfit based NVDIMMs this can be enabled
 	  using the ndctl utility:
 
-		# ndctl create-namespace --force --reconfig=namespace0.0 \
-			--mode=fsdax --map=mem
+	# ndctl create-namespace --force --reconfig=namespace0.0 --mode=fsdax --map=mem
+
+	  See the 'create-namespace' man page for details on the overhead of --map=mem:
 
-	  See the 'create-namespace' man page for details on the overhead of
-	  --map=mem:
 	  https://docs.pmem.io/ndctl-user-guide/ndctl-man-pages/ndctl-create-namespace
 
 	  For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most

--
2.55.0

#1 lore raw
kernel test robot noticed the following build errors:

Hi Bhaskar,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v7.2 next-20260821] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bhaskar-Chowdhury/fs-Kconfig-Alignment-of-code-and-text-in-the-FS_DAX-help-section-for-better-readability/20260821-154402
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20260821101824.23203-1-unixbhaskar%40gmail.com
patch subject: [PATCH] fs: Kconfig: Alignment of code and text in the FS_DAX help section for better readability
config: i386-randconfig-141-20260824 (attached as .config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9187-g5189e3fb
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260824/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> fs/Kconfig:76: syntax error

fs/Kconfig:76:warning: ignoring unsupported character ':' fs/Kconfig:76: unknown statement "See" fs/Kconfig:78:warning: ignoring unsupported character ':' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '.' fs/Kconfig:78:warning: ignoring unsupported character '.' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78: unknown statement "https" fs/Kconfig:80:warning: ignoring unsupported character '.' fs/Kconfig:80: unknown statement "For" fs/Kconfig:81: unknown statement "file" fs/Kconfig:82:warning: ignoring unsupported character '.' fs/Kconfig:82: unknown statement "per-inode" fs/Kconfig:83:warning: ignoring unsupported character '/' fs/Kconfig:83:warning: ignoring unsupported character '/' fs/Kconfig:83:warning: ignoring unsupported character '.' fs/Kconfig:83:warning: ignoring unsupported character '.' fs/Kconfig:83: unknown statement "Documentation" fs/Kconfig:85:warning: ignoring unsupported character ',' fs/Kconfig:85: unknown statement "If" fs/Kconfig:86:warning: ignoring unsupported character ',' fs/Kconfig:86:warning: ignoring unsupported character '.' fs/Kconfig:86: unknown statement "or" fs/Kconfig:87:warning: ignoring unsupported character '.' fs/Kconfig:87: unknown statement "by"
make[3]: *** [scripts/kconfig/Makefile:85: oldconfig] Error 1 make[2]: *** [Makefile:766: oldconfig] Error 2 make[1]: *** [Makefile:248: __sub-make] Error 2 make[1]: Target 'oldconfig' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'oldconfig' not remade because of errors.
--

>> fs/Kconfig:76: syntax error

fs/Kconfig:76:warning: ignoring unsupported character ':' fs/Kconfig:76: unknown statement "See" fs/Kconfig:78:warning: ignoring unsupported character ':' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '.' fs/Kconfig:78:warning: ignoring unsupported character '.' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78:warning: ignoring unsupported character '/' fs/Kconfig:78: unknown statement "https" fs/Kconfig:80:warning: ignoring unsupported character '.' fs/Kconfig:80: unknown statement "For"
fs/Kconfig:81: unknown statement "file" fs/Kconfig:82:warning: ignoring unsupported character '.' fs/Kconfig:82: unknown statement "per-inode" fs/Kconfig:83:warning: ignoring unsupported character '/' fs/Kconfig:83:warning: ignoring unsupported character '/' fs/Kconfig:83:warning: ignoring unsupported character '.' fs/Kconfig:83:warning: ignoring unsupported character '.' fs/Kconfig:83: unknown statement "Documentation" fs/Kconfig:85:warning: ignoring unsupported character ',' fs/Kconfig:85: unknown statement "If" fs/Kconfig:86:warning: ignoring unsupported character ',' fs/Kconfig:86:warning: ignoring unsupported character '.' fs/Kconfig:86: unknown statement "or" fs/Kconfig:87:warning: ignoring unsupported character '.' fs/Kconfig:87: unknown statement "by"
make[3]: *** [scripts/kconfig/Makefile:85: olddefconfig] Error 1 make[2]: *** [Makefile:766: olddefconfig] Error 2 make[1]: *** [Makefile:248: __sub-make] Error 2 make[1]: Target 'olddefconfig' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'olddefconfig' not remade because of errors.

vim +76 fs/Kconfig

57
58 config FS_DAX
59 bool "File system based Direct Access (DAX) support"
60 depends on MMU
61 depends on ZONE_DEVICE
62 select FS_IOMAP
63 select DAX
64 help
65 Direct Access (DAX) can be used on memory-backed block devices.
66 If the block device supports DAX and the filesystem supports DAX,
67 then you can avoid using the pagecache to buffer I/Os. Turning
68 on this option will compile in support for DAX.
69
70 For a DAX device to support file system access it needs to have
71 struct pages. For the nfit based NVDIMMs this can be enabled
72 using the ndctl utility:
73
74 # ndctl create-namespace --force --reconfig=namespace0.0 --mode=fsdax --map=mem
75

  > 76		  See the 'create-namespace' man page for details on the overhead of --map=mem:

77
78 https://docs.pmem.io/ndctl-user-guide/ndctl-man-pages/ndctl-create-namespace
79
80 For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most
81 file systems DAX support needs to be manually enabled globally or
82 per-inode using a mount option as well. See the file documentation in
83 Documentation/filesystems/dax.rst for details.
84
85 If you do not have a block device that is capable of using this,
86 or if unsure, say N. Saying Y will increase the size of the kernel
87 by about 5kB.
88

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki