Skip to contentSkip to conversation

selftests-cgroup-fix-cg_run_in_subcgroups-ignoring-arg-parameter.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Aug 21

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: selftests/cgroup: fix cg_run_in_subcgroups ignoring arg parameter
has been removed from the -mm tree. Its filename was
selftests-cgroup-fix-cg_run_in_subcgroups-ignoring-arg-parameter.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Hongfu Li <[email protected]>
Subject: selftests/cgroup: fix cg_run_in_subcgroups ignoring arg parameter
Date: Thu, 20 Aug 2026 15:09:44 +0800

cg_run_in_subcgroups() discards its arg and always passes NULL to cg_run(), turning the (void *)100 from test_kmem_dead_cgroups() into NULL so no allocation occurs.

This makes test_kmem_dead_cgroups() falsely pass without exercising the "dying cgroup with charged slab" scenario it intends to test.

Pass the arg through to cg_run() to fix this.

Fixes 933dc80ec262 ("kselftests: cgroup: add kernel memory accounting tests")
Cc Johannes Weiner <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Muchun Song <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Shakeel Butt <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Tejun Heo <[email protected]>

---

 tools/testing/selftests/cgroup/test_kmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/cgroup/test_kmem.c renamed from tools/testing/selftests/cgroup/test_kmem.c~selftests-cgroup-fix-cg_run_in_subcgroups-ignoring-arg-parameter +1 -1
@@ -145,7 +145,7 @@ static int cg_run_in_subcgroups(const ch
 			return -1;
 		}
 
-		if (cg_run(child, fn, NULL)) {
+		if (cg_run(child, fn, arg)) {
 			cg_destroy(child);
 			free(child);
 			return -1;

_

Patches currently in -mm which might be from [email protected] are

ksm-update-comments-and-docs-to-reference-folio-mapping.patch selftests-mm-drop-duplicate-test_seal_mprotect_two_vma_with_gap-call.patch selftests-mm-fix-read_file-return-value-check.patch mm-swap-fix-swap_cluster_lock-config_swap-stub-signature-mismatch.patch mm-cma-remove-stray-newline-from-auto-generated-cma-area-name.patch selftests-mm-drop-redundant-open-in-mprotect_tests.patch mm-use-a-folio-in-the-softleaf_is_device_private-path.patch