drm/amd/ras: tell KFD the reset came from an ECC error
Subsystems (2)
PATCH 1/2 drm/amd/ras: tell KFD the reset came from an ECC error
kfd_signal_reset_event() picks between KFD_HW_EXCEPTION_ECC and KFD_HW_EXCEPTION_GPU_HANG from the SRAM ECC flag, and only delivers the memory exception event for the former. Nothing raises that flag on the RAS module paths, so a reset caused by an uncorrectable or a consumed poison error is reported to every process on the device as a plain hang and the runtime carries on instead of tearing the workload down.
Raise it the way the per IP callbacks used to.
--- drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_process.c | 1 + drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c | 2 ++ 2 files changed, 3 insertions(+)
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_process.c +1 -0
@@ -89,6 +89,7 @@ int amdgpu_ras_process_handle_umc_interrupt(struct amdgpu_device *adev, void *daint amdgpu_ras_process_handle_unexpected_interrupt (struct amdgpu_device *adev,void *data) { +kgd2kfd_set_sram_ecc_flag (adev->kfd.dev);amdgpu_ras_set_fed (adev, true);return amdgpu_ras_mgr_reset_gpu (adev,AMDGPU_RAS_GPU_RESET_MODE1_RESET ); }
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c +2 -0
@@ -54,6 +54,8 @@ static int amdgpu_ras_sys_poison_consumption_event(struct ras_core_context *ras_if (!req)return -EINVAL ; +kgd2kfd_set_sram_ecc_flag (adev->kfd.dev); +if (req->pasid_fn) { pasid_fn = (pasid_notify )req->pasid_fn;pasid_fn (adev, req->pasid, req->data);
Signature · 1 line
2.34.1
PATCH 2/2 drm/amd/ras: record the fatal state on every device of the hive
The fatal error interrupt is broadcast to every device of the hive and they all race for amdgpu_ras_global_ras_isr(), which hands -EBUSY to everyone but the winner. Treating that as a failure returns before the device is marked, so seven devices out of eight are left without their fatal and SRAM ECC state, the one that actually logged the error among them. KFD then tells the processes on those devices that the reset was a plain hang.
-EBUSY only means the reset has already been asked for. Record the state anyway and leave the request to the winner.
--- drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c +8 -2
@@ -33,8 +33,14 @@ static int amdgpu_ras_sys_detect_fatal_event(struct ras_core_context *ras_core,uint64_t seq_no; ret =amdgpu_ras_global_ras_isr (adev); -if (ret) -return ret; +if (ret) { +/* Another device of the hive already asked for the reset, this +* one still has to record that it saw the error. +*/ +kgd2kfd_set_sram_ecc_flag (adev->kfd.dev); +amdgpu_ras_set_fed (adev, true); +return ret == -EBUSY ?0 : ret; + } seq_no =amdgpu_ras_mgr_gen_ras_event_seqno (adev,RAS_SEQNO_TYPE_UE ); RAS_DEV_INFO(adev,
Signature · 1 line
2.34.1
AMD General
Series is
Regards,
Hawking
-----Original Message-----
From: Liu, Xiang(Dean) <[email protected]>
Sent: Monday, August 24, 2026 6:21 PM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas <[email protected]>; Liu, Xiang(Dean) <[email protected]>
Subject: [PATCH 1/2] drm/amd/ras: tell KFD the reset came from an ECC error
kfd_signal_reset_event() picks between KFD_HW_EXCEPTION_ECC and KFD_HW_EXCEPTION_GPU_HANG from the SRAM ECC flag, and only delivers the memory exception event for the former. Nothing raises that flag on the RAS module paths, so a reset caused by an uncorrectable or a consumed poison error is reported to every process on the device as a plain hang and the runtime carries on instead of tearing the workload down.
Raise it the way the per IP callbacks used to.
--- drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_process.c | 1 + drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c | 2 ++ 2 files changed, 3 insertions(+)
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_process.c +1 -0
@@ -89,6 +89,7 @@ int amdgpu_ras_process_handle_umc_interrupt(struct amdgpu_device *adev, void *daint amdgpu_ras_process_handle_unexpected_interrupt (struct amdgpu_device *adev,void *data) { +kgd2kfd_set_sram_ecc_flag (adev->kfd.dev);amdgpu_ras_set_fed (adev, true);return amdgpu_ras_mgr_reset_gpu (adev,AMDGPU_RAS_GPU_RESET_MODE1_RESET ); }
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_sys.c +2 -0
@@ -54,6 +54,8 @@ static int amdgpu_ras_sys_poison_consumption_event(struct ras_core_context *ras_if (!req)return -EINVAL ; +kgd2kfd_set_sram_ecc_flag (adev->kfd.dev); +if (req->pasid_fn) { pasid_fn = (pasid_notify )req->pasid_fn;pasid_fn (adev, req->pasid, req->data);
--
2.34.1