ceph: lock mutex in ceph_mds_check_access()
Subsystems (2)
PATCH 1/1 ceph: lock mutex in ceph_mds_check_access()
MDS session OPEN handling replaces mdsc->s_cap_auths under mdsc->mutex, freeing the previous array and its strings.
ceph_mds_check_access() traverses this array without holding the mutex. A concurrent session reopen can therefore free the array while it is being inspected, resulting in a use-after-free like this:
Unable to handle kernel paging request at virtual address 003aaad64b2c8bb9 [...] Internal error: Oops: 0000000096000004 [#1] SMP Modules linked in: CPU: 56 UID: 2953037534 PID: 1253231 Comm: php-cgi8.4 Not tainted 6.18.45-i2-ampere #1146 NONE [..] pc : ceph_mds_check_access+0xd4/0x550 lr : ceph_mds_check_access+0xc8/0x550 [...] Call trace: ceph_mds_check_access+0xd4/0x550 (P) ceph_atomic_open+0x138/0xbe8 path_openat+0xa24/0xfa8 do_filp_open+0x94/0x158 do_sys_openat2+0x88/0xf8
Fixes 596afb0b8933 ("ceph: add ceph_mds_check_access() helper")
Signed-off-by Max Kellermann <[email protected]>
--- fs/ceph/mds_client.c | 4 ++++ fs/ceph/mds_client.h | 1 + 2 files changed, 5 insertions(+)
fs/ceph/mds_client.c +4 -0
@@ -6532,11 +6532,13 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)doutc (cl,"tpath '%s', mask %d, caller_uid %d, caller_gid %d\n" , tpath, mask, caller_uid, caller_gid); +mutex_lock (&mdsc->mutex);for (i =0 ; i < mdsc->s_cap_auths_num; i++) {struct ceph_mds_cap_auth *s = &mdsc->s_cap_auths[i]; err =ceph_mds_auth_match (mdsc, s, cred, tpath);if (err <0 ) { +mutex_unlock (&mdsc->mutex);put_cred (cred);return err; }else if (err >0 ) {
@@ -6558,6 +6560,7 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)doutc (cl,"root_squash_perms %d, rw_perms_s %p\n" , root_squash_perms, rw_perms_s);if (root_squash_perms && rw_perms_s ==NULL ) { +mutex_unlock (&mdsc->mutex);doutc (cl,"access allowed\n" );return 0 ; }
@@ -6572,6 +6575,7 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask) !!(mask & MAY_READ), !!(mask & MAY_WRITE)); }doutc (cl,"access denied\n" ); +mutex_unlock (&mdsc->mutex);return -EACCES ; }
fs/ceph/mds_client.h +1 -0
@@ -603,6 +603,7 @@ struct ceph_mds_client {struct rw_semaphore pool_perm_rwsem;struct rb_root pool_perm_tree; +/* protected by mutex */ u32 s_cap_auths_num;struct ceph_mds_cap_auth *s_cap_auths;
Signature · 1 line
2.47.3
Hi Max,
Thanks for the patch.
Reviewed-by Alex Markuze <[email protected]>
Signature · 1 line
Alex Markuze
LGTM.
Reviewed-by Xiubo Li <[email protected]>
Quoted 81 lines · Max Kellermann
MDS session OPEN handling replaces
mdsc->s_cap_authsundermdsc->mutex, freeing the previous array and its strings.
ceph_mds_check_access()traverses this array without holding the mutex. A concurrent session reopen can therefore free the array while it is being inspected, resulting in a use-after-free like this:Unable to handle kernel paging request at virtual address 003aaad64b2c8bb9 [...] Internal error: Oops: 0000000096000004 [#1] SMP Modules linked in: CPU: 56 UID: 2953037534 PID: 1253231 Comm: php-cgi8.4 Not tainted 6.18.45-i2-ampere #1146 NONE [..] pc : ceph_mds_check_access+0xd4/0x550 lr : ceph_mds_check_access+0xc8/0x550 [...] Call trace: ceph_mds_check_access+0xd4/0x550 (P) ceph_atomic_open+0x138/0xbe8 path_openat+0xa24/0xfa8 do_filp_open+0x94/0x158 do_sys_openat2+0x88/0xf8Fixes 596afb0b8933 ("ceph: add ceph_mds_check_access() helper")Signed-off-by Max Kellermann <[email protected]>--- fs/ceph/mds_client.c | 4 ++++ fs/ceph/mds_client.h | 1 + 2 files changed, 5 insertions(+)fs/ceph/mds_client.c +4
-0@@ -6532,11 +6532,13 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)doutc (cl,"tpath '%s', mask %d, caller_uid %d, caller_gid %d\n" , tpath, mask, caller_uid, caller_gid); +mutex_lock (&mdsc->mutex);for (i =0 ; i < mdsc->s_cap_auths_num; i++) {struct ceph_mds_cap_auth *s = &mdsc->s_cap_auths[i]; err =ceph_mds_auth_match (mdsc, s, cred, tpath);if (err <0 ) { +mutex_unlock (&mdsc->mutex);put_cred (cred);return err; }else if (err >0 ) {@@ -6558,6 +6560,7 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)doutc (cl,"root_squash_perms %d, rw_perms_s %p\n" , root_squash_perms, rw_perms_s);if (root_squash_perms && rw_perms_s ==NULL ) { +mutex_unlock (&mdsc->mutex);doutc (cl,"access allowed\n" );return 0 ; }@@ -6572,6 +6575,7 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask) !!(mask & MAY_READ), !!(mask & MAY_WRITE)); }doutc (cl,"access denied\n" ); +mutex_unlock (&mdsc->mutex);return -EACCES ; }fs/ceph/mds_client.h +1
-1@@ -603,6 +603,7 @@ struct ceph_mds_client {struct rw_semaphore pool_perm_rwsem;struct rb_root pool_perm_tree; +/* protected by mutex */ u32 s_cap_auths_num;struct ceph_mds_cap_auth *s_cap_auths; --2.47.3