ASoC: soc-generic-dmaengine: Fix DMA channel request warning
Subsystems (3)
PATCH 1/1 ASoC: soc-generic-dmaengine: Fix DMA channel request warning
From: bui duc phuc <[email protected]>
The DMA channel request code currently warns about legacy DMA failures when the channel name is not present in dma-names. This can report a firmware lookup failure as a legacy DMA failure.
Furthermore, failures from the legacy DMA path are already reported by find_candidate(), making these warnings redundant.
Only warn when the channel name is present in dma-names but the request fails, avoiding misleading and duplicate error messages.
--- sound/soc/soc-generic-dmaengine-pcm.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-)
sound/soc/soc-generic-dmaengine-pcm.c +2 -18
@@ -397,24 +397,8 @@ static int dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm,if (PTR_ERR (chan) == -EPROBE_DEFER )return -EPROBE_DEFER ; -bool has_fw_node = dev->of_node ||is_acpi_device_node (dev->fwnode); -bool name_exists_in_fw = false; - -if (has_fw_node) - name_exists_in_fw =device_property_match_string (dev, -"dma-names" , - name) >=0 ; - -if (has_fw_node && name_exists_in_fw) -dev_warn (dev,"DTS/ACPI DMA channel '%s' request failed (%ld)\n" , - name,PTR_ERR (chan)); - -if (has_fw_node && !name_exists_in_fw) -dev_warn (dev,"DTS/ACPI name '%s' not found, legacy failed (%ld)\n" , - name,PTR_ERR (chan)); - -if (!has_fw_node) -dev_warn (dev,"Legacy DMA channel '%s' request failed (%ld)\n" , +if (device_property_match_string (dev,"dma-names" , name) >=0 ) +dev_warn (dev,"dma-names has '%s' but request failed (%ld)\n" , name,PTR_ERR (chan)); pcm->chan[i] =NULL ;
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 1 line · On Tue, 25 Aug 2026 15:19:49 +0700, [email protected] wrote:
ASoC: soc-generic-dmaengine: Fix DMA channel request warning
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/1] ASoC: soc-generic-dmaengine: Fix DMA channel request warning
https://git.kernel.org/broonie/sound/c/84d2d96ac3f1
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark