Skip to contentSkip to conversation

ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants

PATCH In review Shengyu Qu 3 participants 3 messages Aug 26

Subsystems (3)
lore
Share & tools
lore

Shengyu Qu

author
#0 lore raw

PATCH 1/1 ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants

Existing quirks doesn't cover all known exising FA401EA devices, so add more quirk items to cover them.

Fixes 27d090f3ccd4 ("ASoC: amd: acp: add ACP70 DMI override for new ASUS TUF platforms")
---
 sound/soc/amd/acp-config.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
sound/soc/amd/acp-config.c +12 -0
index 3021dc498c855..509f24a26ffe7 100644
@@ -51,12 +51,24 @@ static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "83V9"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 11 lines · Shengyu Qu

Existing quirks doesn't cover all known exising FA401EA devices, so add more quirk items to cover them.

sound/soc/amd/acp-config.c +6 -0
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
+		},
+	},
 	{
 		.matches = {

sound/soc/amd/acp-config.c static const struct dmi_system_id acp70_acpi_flag_override_table[] = { · line 71

Quoted 10 lines
sound/soc/amd/acp-config.c +6 -0
 			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
+		},
+	},

Do we need all these entries, DMI matches use substr() so I'd expect the first entry to match on all the machines that the other two matches, unless I'm misunderstanding somehow?

#2 lore raw

Hi Mark,

I've tested your advice and it works well. It should cover all variants.

V2 already sent:
https://lore.kernel.org/all/[email protected]/

Best regards,
Shengyu

Quoted 26 lines · Mark Brown
Quoted 11 lines · Shengyu Qu

Existing quirks doesn't cover all known exising FA401EA devices, so add more quirk items to cover them.

sound/soc/amd/acp-config.c +6 -0
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
+		},
+	},
  	{
  		.matches = {

sound/soc/amd/acp-config.c static const struct dmi_system_id acp70_acpi_flag_override_table[] = { · line 71

Quoted 10 lines
sound/soc/amd/acp-config.c +6 -0
  			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
  			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
  		},
  	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
+		},
+	},

Do we need all these entries, DMI matches use substr() so I'd expect the first entry to match on all the machines that the other two matches, unless I'm misunderstanding somehow?