Skip to contentSkip to conversation

iio: temperature: make headers conform to IWYU

PATCH Applied Joshua Crofts 2 participants 15 messages Aug 31 – Sep 5

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover iio: temperature: make headers conform to IWYU

This series removes any instances of kernel.h in the temperature/ subdirectory and cleans up the headers in order to improve readability and enforce IYWU instead of relying on transitive dependencies during the build process.

I had Gemini generate a summary (a bit more verbose) of changed headers under the --- in each IWYU patch to improve the review process.

This is part of an ongoing effort to remove kernel.h entirely from IIO.

---
Changes in v2:
- Add missing headers pointed out by Sashiko.
- Swap <asm/div64.h> for <linux/math64.h> (Jonathan, Andy).
- Squash small reordering patches with iwyu changes.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Joshua Crofts (11):
iio: temperature: iqs620at-temp: make headers conform to IWYU
iio: temperature: ltc2983: reorder headers
iio: temperature: ltc2983: make headers conform to IWYU
iio: temperature: mlx90632: make headers conform to IWYU
iio: temperature: mlx90635: make headers conform to IWYU
iio: temperature: tmp117: sort headers alphabetically
iio: temperature: tmp117: make headers conform to IWYU
iio: temperature: tsys01: reorder headers
iio: temperature: tsys01: make headers conform to IWYU
iio: temperature: tsys02d: reorder headers
iio: temperature: tsys02d: make headers conform to IWYU

 drivers/iio/temperature/iqs620at-temp.c |  9 +++++++--
 drivers/iio/temperature/ltc2983.c       | 19 +++++++++++++++----
 drivers/iio/temperature/mlx90632.c      | 10 +++++++---
 drivers/iio/temperature/mlx90635.c      | 11 +++++++----
 drivers/iio/temperature/tmp117.c        |  9 +++++----
 drivers/iio/temperature/tsys01.c        | 17 +++++++++++------
 drivers/iio/temperature/tsys02d.c       | 12 +++++++++---
 7 files changed, 61 insertions(+), 26 deletions(-)

---
base-commit: 350d1fb9204b13c5f95e511e98b8bcb47574d425
change-id: 20260821-kernel-header-removal-d95efd197d78

Best regards,

Signature · 2 lines
Kind regards,
Joshua Crofts
#1 lore raw

PATCH v2 1/11 iio: temperature: iqs620at-temp: make headers conform to IWYU

Remove the catch-all kernel.h header and add the missing headers to enforce IWYU.

Additionally, separate the IIO specific header from the generic <linux/*> headers.

---
Header changes explained:
Added:
- <asm/byteorder.h>: for endianness helpers
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bits.h>: for GENMASK() and BIT() macros
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/kernel.h>: catch-all header no longer needed

---
 drivers/iio/temperature/iqs620at-temp.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/iio/temperature/iqs620at-temp.c +7 -2
index e2f878d57af7..3a3b1f256585 100644
@@ -5,13 +5,18 @@
  * Copyright (C) 2019 Jeff LaBundy <[email protected]>
  */
 
+#include <linux/array_size.h>
+#include <linux/bits.h>
 #include <linux/device.h>
-#include <linux/iio/iio.h>
-#include <linux/kernel.h>
 #include <linux/mfd/iqs62x.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
+#include <linux/types.h>
+
+#include <asm/byteorder.h>
+
+#include <linux/iio/iio.h>
 
 #define IQS620_TEMP_UI_OUT			0x1A
 
Signature · 1 line
2.55.0
#2 lore raw

PATCH v2 2/11 iio: temperature: ltc2983: reorder headers

In reply to Joshua Crofts

Separate the IIO specific header and group unaligned.h with the other generic <linux/*> headers.

No functional change.

---
 drivers/iio/temperature/ltc2983.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/temperature/ltc2983.c +3 -2
index 6efb5252a773..fe9eec3058d4 100644
@@ -11,7 +11,6 @@
 #include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
-#include <linux/iio/iio.h>
 #include <linux/interrupt.h>
 #include <linux/list.h>
 #include <linux/module.h>
@@ -19,9 +18,11 @@
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/spi/spi.h>
+#include <linux/unaligned.h>
 
 #include <asm/byteorder.h>
-#include <linux/unaligned.h>
+
+#include <linux/iio/iio.h>
 
 /* register map */
 #define LTC2983_STATUS_REG			0x0000
Signature · 1 line
2.55.0
#3 lore raw

PATCH v2 3/11 iio: temperature: ltc2983: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header and add the missing headers to enforce IWYU (some standard headers are already include subheaders, i.e. errno.h is included by err.h).

---
Header changes explained:
Added:
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bitops.h>: for bitwise operations
- <linux/container_of.h>: for container_of macro
- <linux/delay.h>: for usleep_range()
- <linux/gpio/consumer.h>: for GPIO functions
- <linux/math64.h>: for div64 functions
- <linux/mutex.h>: for struct mutex and mutex_lock/unlock
- <linux/pm_runtime.h>: for DEFINE_SIMPLE_DEV_PM_OPS
- <linux/slab.h>: for memory allocation
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/errno.h>: not directly used in this driver
- <linux/kernel.h>: catch-all header no longer needed

---
 drivers/iio/temperature/ltc2983.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/iio/temperature/ltc2983.c +12 -2
index fe9eec3058d4..6655453c9abf 100644
@@ -5,19 +5,29 @@
  *
  * Copyright 2019 Analog Devices Inc.
  */
+
+#include <linux/array_size.h>
 #include <linux/bitfield.h>
+#include <linux/bitops.h>
 #include <linux/completion.h>
+#include <linux/container_of.h>
+#include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/err.h>
-#include <linux/errno.h>
-#include <linux/kernel.h>
+#include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
 #include <linux/list.h>
+#include <linux/math64.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/pm_runtime.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
+#include <linux/slab.h>
 #include <linux/spi/spi.h>
+#include <linux/string.h>
+#include <linux/types.h>
 #include <linux/unaligned.h>
 
 #include <asm/byteorder.h>
Signature · 1 line
2.55.0
#4 lore raw

PATCH v2 4/11 iio: temperature: mlx90632: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header and add the missing headers to enforce IWYU.

Additionally, sort the entries alphabetically.

---
Header changes explained:
Added:
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bits.h>: for GENMASK() and BIT() macros
- <linux/dev_printk.h>: for dev_err(), dev_info(), etc.
- <linux/mutex.h>: for struct mutex and mutex_lock/unlock
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/gpio/consumer.h>: not directly used in this driver
- <linux/kernel.h>: catch-all header no longer needed

---
 drivers/iio/temperature/mlx90632.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/iio/temperature/mlx90632.c +7 -3
index 2fde48f337e2..74ae36f74e8b 100644
@@ -6,21 +6,25 @@
  *
  * Driver for the Melexis MLX90632 I2C 16-bit IR thermopile sensor
  */
+
+#include <linux/array_size.h>
 #include <linux/bitfield.h>
+#include <linux/bits.h>
 #include <linux/delay.h>
+#include <linux/dev_printk.h>
 #include <linux/device.h>
 #include <linux/err.h>
-#include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/iopoll.h>
 #include <linux/jiffies.h>
-#include <linux/kernel.h>
 #include <linux/limits.h>
-#include <linux/module.h>
 #include <linux/math64.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
+#include <linux/types.h>
 
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
Signature · 1 line
2.55.0
#5 lore raw

PATCH v2 5/11 iio: temperature: mlx90635: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header and add the missing headers to enforce IWYU.

Additionally, sort the headers alphabetically.

---
Header changes explained:
Added:
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bits.h>: for GENMASK() and BIT() macros
- <linux/dev_printk.h>: for dev_err(), dev_info(), etc.
- <linux/mutex.h>: for struct mutex and mutex_lock/unlock
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/gpio/consumer.h>: not directly used in this driver
- <linux/kernel.h>: catch-all header no longer needed
- <linux/limits.h>: not directly used in this driver

---
 drivers/iio/temperature/mlx90635.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/iio/temperature/mlx90635.c +7 -4
index 0f31879a4f64..48c760c980f3 100644
@@ -6,21 +6,24 @@
  *
  * Driver for the Melexis MLX90635 I2C 16-bit IR thermopile sensor
  */
+
+#include <linux/array_size.h>
 #include <linux/bitfield.h>
+#include <linux/bits.h>
 #include <linux/delay.h>
+#include <linux/dev_printk.h>
 #include <linux/device.h>
 #include <linux/err.h>
-#include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/iopoll.h>
 #include <linux/jiffies.h>
-#include <linux/kernel.h>
-#include <linux/limits.h>
-#include <linux/module.h>
 #include <linux/math64.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
+#include <linux/types.h>
 
 #include <linux/iio/iio.h>
 
Signature · 1 line
2.55.0
#6 lore raw

PATCH v2 6/11 iio: temperature: tmp117: sort headers alphabetically

In reply to Joshua Crofts

Sort the headers alphabetically to improve readability.

No functional change.

---
 drivers/iio/temperature/tmp117.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/temperature/tmp117.c +3 -3
index 74cb8d62bef3..fed8af2d81eb 100644
@@ -10,16 +10,16 @@
  */
 
 #include <linux/array_size.h>
+#include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
-#include <linux/module.h>
-#include <linux/bitops.h>
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/limits.h>
+#include <linux/module.h>
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
+#include <linux/types.h>
 
 #include <linux/iio/iio.h>
 
Signature · 1 line
2.55.0
#7 lore raw

PATCH v2 7/11 iio: temperature: tmp117: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header and add the missing <linux/dev_printk.h> header to enforce IWYU.

---
Header changes explained:
Added:
- <linux/dev_printk.h>: for dev_err(), dev_info(), etc.
- <linux/minmax.h>: for min/max limit macros Removed:
- <linux/kernel.h>: catch-all header no longer needed

---
 drivers/iio/temperature/tmp117.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iio/temperature/tmp117.c +2 -1
index fed8af2d81eb..25bc98e64e48 100644
@@ -12,10 +12,11 @@
 #include <linux/array_size.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
+#include <linux/dev_printk.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
-#include <linux/kernel.h>
 #include <linux/limits.h>
+#include <linux/minmax.h>
 #include <linux/module.h>
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
Signature · 1 line
2.55.0
#8 lore raw

PATCH v2 8/11 iio: temperature: tsys01: reorder headers

In reply to Joshua Crofts

Sort the headers alphabetically and group the IIO headers and vendor specific header separately.

No functional change.

---
 drivers/iio/temperature/tsys01.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/iio/temperature/tsys01.c +6 -4
index 28b3ce022ce7..14de67ee8be7 100644
@@ -8,14 +8,16 @@
  *  http://www.meas-spec.com/downloads/TSYS01_Digital_Temperature_Sensor.pdf
  */
 
-#include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/device.h>
-#include <linux/mutex.h>
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/stat.h>
+
+#include <linux/iio/iio.h>
+#include <linux/iio/sysfs.h>
+
 #include "../common/ms_sensors/ms_sensors_i2c.h"
 
 /* TSYS01 Commands */
Signature · 1 line
2.55.0
#9 lore raw

PATCH v2 9/11 iio: temperature: tsys01: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header, add missing headers and remove unused headers.

---
Header changes explained:
Added:
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bits.h>: for BIT()
- <linux/device.h>: for struct device
- <linux/i2c.h>: for i2c_client and i2c_device_id
- <linux/math64.h>: for div64 functions
- <linux/sprintf.h>: for sprintf functions
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/init.h>: not directly used in this driver
- <linux/kernel.h>: catch-all header no longer needed
- <linux/property.h>: not directly used in this driver
- <linux/stat.h>: not directly used in this driver

---
 drivers/iio/temperature/tsys01.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/iio/temperature/tsys01.c +6 -3
index 14de67ee8be7..b19b4a3ef038 100644
@@ -8,12 +8,15 @@
  *  http://www.meas-spec.com/downloads/TSYS01_Digital_Temperature_Sensor.pdf
  */
 
+#include <linux/array_size.h>
+#include <linux/bits.h>
 #include <linux/device.h>
-#include <linux/init.h>
-#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/math64.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
-#include <linux/stat.h>
+#include <linux/sprintf.h>
+#include <linux/types.h>
 
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
Signature · 1 line
2.55.0
#10 lore raw

PATCH v2 10/11 iio: temperature: tsys02d: reorder headers

In reply to Joshua Crofts

Sort the headers alphabetically and group the IIO specific headers separately.

No functional change.

---
 drivers/iio/temperature/tsys02d.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/temperature/tsys02d.c +3 -2
index 3ef72347456e..377e27b45fdd 100644
@@ -10,11 +10,12 @@
  *  http://www.meas-spec.com/downloads/Digital_Sensor_TSYS02D.pdf
  */
 
-#include <linux/init.h>
 #include <linux/device.h>
+#include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/stat.h>
 #include <linux/module.h>
+#include <linux/stat.h>
+
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
 
Signature · 1 line
2.55.0
#11 lore raw

PATCH v2 11/11 iio: temperature: tsys02d: make headers conform to IWYU

In reply to Joshua Crofts

Remove the catch-all kernel.h header, add missing headers and remove unused headers.

---
Header changes explained:
Added:
- <linux/array_size.h>: for ARRAY_SIZE()
- <linux/bits.h>: for GENMASK() and BIT() macros
- <linux/i2c.h>: for i2c_client and i2c_device_id
- <linux/mutex.h>: for struct mutex and mutex_lock/unlock
- <linux/sysfs.h>: for sysfs API
- <linux/types.h>: for fixed-width integer types (u8, u16, etc.) Removed:
- <linux/init.h>: not directly used in this driver
- <linux/kernel.h>: catch-all header no longer needed

---
 drivers/iio/temperature/tsys02d.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/iio/temperature/tsys02d.c +7 -2
index 377e27b45fdd..2c67faebd90c 100644
@@ -10,11 +10,16 @@
  *  http://www.meas-spec.com/downloads/Digital_Sensor_TSYS02D.pdf
  */
 
+#include <linux/array_size.h>
+#include <linux/bits.h>
+#include <linux/dev_printk.h>
 #include <linux/device.h>
-#include <linux/init.h>
-#include <linux/kernel.h>
+#include <linux/i2c.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/stat.h>
+#include <linux/sysfs.h>
+#include <linux/types.h>
 
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
Signature · 1 line
2.55.0
#12 lore raw
In reply to Joshua Crofts
Quoted 41 lines · Joshua Crofts

This series removes any instances of kernel.h in the temperature/ subdirectory and cleans up the headers in order to improve readability and enforce IYWU instead of relying on transitive dependencies during the build process.

I had Gemini generate a summary (a bit more verbose) of changed headers under the --- in each IWYU patch to improve the review process.

This is part of an ongoing effort to remove kernel.h entirely from IIO.

---
Changes in v2:
- Add missing headers pointed out by Sashiko.
- Swap <asm/div64.h> for <linux/math64.h> (Jonathan, Andy).
- Squash small reordering patches with iwyu changes.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Joshua Crofts (11):
iio: temperature: iqs620at-temp: make headers conform to IWYU
iio: temperature: ltc2983: reorder headers
iio: temperature: ltc2983: make headers conform to IWYU
iio: temperature: mlx90632: make headers conform to IWYU
iio: temperature: mlx90635: make headers conform to IWYU
iio: temperature: tmp117: sort headers alphabetically
iio: temperature: tmp117: make headers conform to IWYU
iio: temperature: tsys01: reorder headers
iio: temperature: tsys01: make headers conform to IWYU
iio: temperature: tsys02d: reorder headers
iio: temperature: tsys02d: make headers conform to IWYU

 drivers/iio/temperature/iqs620at-temp.c |  9 +++++++--
 drivers/iio/temperature/ltc2983.c       | 19 +++++++++++++++----
 drivers/iio/temperature/mlx90632.c      | 10 +++++++---
 drivers/iio/temperature/mlx90635.c      | 11 +++++++----
 drivers/iio/temperature/tmp117.c        |  9 +++++----
 drivers/iio/temperature/tsys01.c        | 17 +++++++++++------
 drivers/iio/temperature/tsys02d.c       | 12 +++++++++---
 7 files changed, 61 insertions(+), 26 deletions(-)
Quoted 1 line

---

I seem to be having b4 issues as this sent v2 again with the same mistakes?

Signature · 3 lines
Kind regards

CJD
#13 lore raw
Quoted 30 lines · Joshua Crofts
Quoted 28 lines

Changes in v2:
- Add missing headers pointed out by Sashiko.
- Swap <asm/div64.h> for <linux/math64.h> (Jonathan, Andy).
- Squash small reordering patches with iwyu changes.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Joshua Crofts (11):
iio: temperature: iqs620at-temp: make headers conform to IWYU
iio: temperature: ltc2983: reorder headers
iio: temperature: ltc2983: make headers conform to IWYU
iio: temperature: mlx90632: make headers conform to IWYU
iio: temperature: mlx90635: make headers conform to IWYU
iio: temperature: tmp117: sort headers alphabetically
iio: temperature: tmp117: make headers conform to IWYU
iio: temperature: tsys01: reorder headers
iio: temperature: tsys01: make headers conform to IWYU
iio: temperature: tsys02d: reorder headers
iio: temperature: tsys02d: make headers conform to IWYU

 drivers/iio/temperature/iqs620at-temp.c |  9 +++++++--
 drivers/iio/temperature/ltc2983.c       | 19 +++++++++++++++----
 drivers/iio/temperature/mlx90632.c      | 10 +++++++---
 drivers/iio/temperature/mlx90635.c      | 11 +++++++----
 drivers/iio/temperature/tmp117.c        |  9 +++++----
 drivers/iio/temperature/tsys01.c        | 17 +++++++++++------
 drivers/iio/temperature/tsys02d.c       | 12 +++++++++---
 7 files changed, 61 insertions(+), 26 deletions(-)
Quoted 1 line

---

Quoted 2 lines

I seem to be having b4 issues as this sent v2 again with the same mistakes?

Okay, never mind. b4 did send the right series but forgot to bump the version number up.

Anyway, some Sashiko remarks - just commit message issues (forgot to update some headers under the ---) + one remark about me including slab.h for GFP_KERNEL, but I suppose I could change this to gfp_types.h instead.

Signature · 2 lines
Kind regards,
Joshua Crofts
maintainer Applied
#14 lore raw
Quoted 34 lines · On Tue, 1 Sep 2026 09:55:09 +0200 Joshua Crofts <[email protected]>…
Quoted 30 lines · Joshua Crofts
Quoted 28 lines

Changes in v2:
- Add missing headers pointed out by Sashiko.
- Swap <asm/div64.h> for <linux/math64.h> (Jonathan, Andy).
- Squash small reordering patches with iwyu changes.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Joshua Crofts (11):
iio: temperature: iqs620at-temp: make headers conform to IWYU
iio: temperature: ltc2983: reorder headers
iio: temperature: ltc2983: make headers conform to IWYU
iio: temperature: mlx90632: make headers conform to IWYU
iio: temperature: mlx90635: make headers conform to IWYU
iio: temperature: tmp117: sort headers alphabetically
iio: temperature: tmp117: make headers conform to IWYU
iio: temperature: tsys01: reorder headers
iio: temperature: tsys01: make headers conform to IWYU
iio: temperature: tsys02d: reorder headers
iio: temperature: tsys02d: make headers conform to IWYU

 drivers/iio/temperature/iqs620at-temp.c |  9 +++++++--
 drivers/iio/temperature/ltc2983.c       | 19 +++++++++++++++----
 drivers/iio/temperature/mlx90632.c      | 10 +++++++---
 drivers/iio/temperature/mlx90635.c      | 11 +++++++----
 drivers/iio/temperature/tmp117.c        |  9 +++++----
 drivers/iio/temperature/tsys01.c        | 17 +++++++++++------
 drivers/iio/temperature/tsys02d.c       | 12 +++++++++---
 7 files changed, 61 insertions(+), 26 deletions(-)
Quoted 1 line

---

Quoted 2 lines

I seem to be having b4 issues as this sent v2 again with the same mistakes?

Quoted 7 lines

Okay, never mind. b4 did send the right series but forgot to bump the version number up.

Anyway, some Sashiko remarks - just commit message issues (forgot to update some headers under the ---) + one remark about me including slab.h for GFP_KERNEL, but I suppose I could change this to gfp_types.h instead.

Lets not go around the houses for ever. Close enough to perfect for me.

Applied, thanks!

Jonathan