Skip to contentSkip to conversation

go: Fix CVE-2026-33814

PATCH In review Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) 2 participants 5 messages Aug 31 – Oct 19

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 go: Fix CVE-2026-33814

From: Hetvi Thakar <[email protected]>

This patch applies the upstream fix as referenced in [2], using the commit shown in [1].

[1] https://github.com/golang/go/commit/9024c3f6b150fb1349d8a5dc5e9aa31d7896f67f
[2] https://pkg.go.dev/vuln/GO-2026-4918

---
 meta/recipes-devtools/go/go-1.22.12.inc       |  1 +
 .../go/go/CVE-2026-33814.patch                | 44 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/CVE-2026-33814.patch
meta/recipes-devtools/go/go-1.22.12.inc +1 -0
index 99c5f8b63b..ee2f5ca277 100644
@@ -62,6 +62,7 @@ SRC_URI += "\
     file://CVE-2026-25679.patch \
     file://CVE-2026-32288.patch \
     file://CVE-2026-27145.patch \
+    file://CVE-2026-33814.patch \
 "
 SRC_URI[main.sha256sum] = "012a7e1f37f362c0918c1dfa3334458ac2da1628c4b9cf4d9ca02db986e17d71"
 
meta/recipes-devtools/go/go/CVE-2026-33814.patch new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.35.6
#1 lore raw

PATCH 2/2 go: Fix CVE-2026-39823

From: Hetvi Thakar <[email protected]>

This patch applies the upstream fix as referenced in [2], using the commit shown in [1].

[1] https://github.com/golang/go/commit/f0384f7c664892ed3ee8c0fec68638d9b3b01811
[2] https://pkg.go.dev/vuln/GO-2026-4982

---
 meta/recipes-devtools/go/go-1.22.12.inc       |   1 +
 .../go/go/CVE-2026-39823.patch                | 100 ++++++++++++++++++
 2 files changed, 101 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/CVE-2026-39823.patch
meta/recipes-devtools/go/go-1.22.12.inc +1 -0
index ee2f5ca277..a2c0efa378 100644
@@ -63,6 +63,7 @@ SRC_URI += "\
     file://CVE-2026-32288.patch \
     file://CVE-2026-27145.patch \
     file://CVE-2026-33814.patch \
+    file://CVE-2026-39823.patch \
 "
 SRC_URI[main.sha256sum] = "012a7e1f37f362c0918c1dfa3334458ac2da1628c4b9cf4d9ca02db986e17d71"
 
meta/recipes-devtools/go/go/CVE-2026-39823.patch new file +100 -0

100 lines not on this page · raw message

Signature · 1 line
2.35.6
#2 lore raw
In reply to Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
Quoted 41 lines · On Sun, 2026-08-30 at 23:14 -0700, Hetvi Thakar -X (hthakar - E INFOCHIPS…

From: Hetvi Thakar <[email protected]>

This patch applies the upstream fix as referenced in [2], using the commit shown in [1].

[1] https://github.com/golang/go/commit/9024c3f6b150fb1349d8a5dc5e9aa31d7896f67f
[2] https://pkg.go.dev/vuln/GO-2026-4918

---
 meta/recipes-devtools/go/go-1.22.12.inc       |  1 +
 .../go/go/CVE-2026-33814.patch                | 44 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/CVE-2026-33814.patch
meta/recipes-devtools/go/go-1.22.12.inc +1 -0
index 99c5f8b63b..ee2f5ca277 100644
@@ -62,6 +62,7 @@ SRC_URI += "\
     file://CVE-2026-25679.patch \
     file://CVE-2026-32288.patch \
     file://CVE-2026-27145.patch \
+    file://CVE-2026-33814.patch \
 "
 SRC_URI[main.sha256sum] = "012a7e1f37f362c0918c1dfa3334458ac2da1628c4b9cf4d9ca02db986e17d71"
 
meta/recipes-devtools/go/go/CVE-2026-33814.patch new file +8 -0
new file mode 100644
index 0000000000..8265bf205f
@@ -0,0 +1,44 @@
+From 825d42a14d8ffbdbdda87a39e78795eb17e4f0f2 Mon Sep 17 00:00:00 2001
+From: Mark Freeman <[email protected]>
+Date: Fri, 17 Apr 2026 16:28:03 -0400
+Subject: [PATCH] [release-branch.go1.25] all: update x/net to a9171bc8
+
+Fixes #78477
+
+Change-Id: I0a4c8e25f569fc1bfb8ac39ff728bfe7300b751f

meta/recipes-devtools/go/go/CVE-2026-33814.patch line 18

Quoted 10 lines
meta/recipes-devtools/go/go/CVE-2026-33814.patch new file +10 -0
+Reviewed-on: https://go-review.googlesource.com/c/go/+/768323
+Reviewed-by: Dmitri Shuralyov <[email protected]>
+TryBot-Bypass: Dmitri Shuralyov <[email protected]>
+
+CVE: CVE-2026-33814
+Upstream-Status: Backport [https://github.com/golang/go/commit/9024c3f6b150fb1349d8a5dc5e9aa31d7896f67f]
+
+Backport Changes:
+- Omitted src/go.mod, src/go.sum, and src/vendor/modules.txt because
+  their x/net version updates are not required for this focused backport.

Hi Hetvi, Yoann,

My Go knowledge is limited, but omitting the go.mod/go.sum changes didn't seem right to me. Those files track dependencies.

Looking in to it a bit further, the CVE description is:

When processing HTTP/2 SETTINGS frames, transport will enter an infinite loop of writing CONTINUATION frames if it receives a SETTINGS_MAX_FRAME_SIZE with a value of 0.

The commit message is "all: update x/net to a9171bc8", if we look at that commit in the x/net go module [1] it makes other changes which look relevant to this CVE.

[1]: https://go.googlesource.com/net/+/a9171bc8c6f19c50efad8880f96e361359ed5307%5E%21/

Could we check if the backport submitted here is a complete fix? As I say, my Go knowledge is limited, and I'm not sure how we would pick up changes to the x/net module if we need to.

Best regards,

Signature · 1 line
Paul Barker
#3 lore raw

Hi Paul, Yoann,

Thanks for the review.

The go.mod, go.sum, and vendor/modules.txt changes are not required for this Go 1.22 backport, as the upstream Go 1.25 commit updates the entire x/net dependency to revision a9171bc8 [1].

For Go 1.22, the required security fix is applied directly to src/net/http/h2_bundle.go [2]. The fix addresses the infinite CONTINUATION frame loop described in the CVE.

Updating only the dependency metadata without updating the complete vendored x/net source would be inconsistent. Since this is a focused security backport, the dependency update is not needed.

The additional validation-related change in the upstream commit is not applicable to Go 1.22, as the corresponding code is not present in this version [2].

References:
[1] https://go.googlesource.com/net/+/a9171bc8c6f19c50efad8880f96e361359ed5307%5E%21/
[2] https://github.com/golang/go/blob/go1.22.12/src/net/http/h2_bundle.go

Regards,
Hetvi
________________________________
From: Paul Barker <[email protected]>
Sent: 17 September 2026 19:28
To: Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) <[email protected]>; [email protected] <[email protected]>
Cc: xe-linux-external (Internal Group) <[email protected]>; Yoann Congal <[email protected]>
Subject: Re: [OE-core][scarthgap][PATCH 1/2] go: Fix CVE-2026-33814

Quoted 41 lines · On Sun, 2026-08-30 at 23:14 -0700, Hetvi Thakar -X (hthakar - E INFOCHIPS…

From: Hetvi Thakar <[email protected]>

This patch applies the upstream fix as referenced in [2], using the commit shown in [1].

[1] https://github.com/golang/go/commit/9024c3f6b150fb1349d8a5dc5e9aa31d7896f67f
[2] https://pkg.go.dev/vuln/GO-2026-4918

---
 meta/recipes-devtools/go/go-1.22.12.inc       |  1 +
 .../go/go/CVE-2026-33814.patch                | 44 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/CVE-2026-33814.patch
meta/recipes-devtools/go/go-1.22.12.inc +1 -0
index 99c5f8b63b..ee2f5ca277 100644
@@ -62,6 +62,7 @@ SRC_URI += "\
     file://CVE-2026-25679.patch \
     file://CVE-2026-32288.patch \
     file://CVE-2026-27145.patch \
+    file://CVE-2026-33814.patch \
 "
 SRC_URI[main.sha256sum] = "012a7e1f37f362c0918c1dfa3334458ac2da1628c4b9cf4d9ca02db986e17d71"
 
meta/recipes-devtools/go/go/CVE-2026-33814.patch new file +8 -0
new file mode 100644
index 0000000000..8265bf205f
@@ -0,0 +1,44 @@
+From 825d42a14d8ffbdbdda87a39e78795eb17e4f0f2 Mon Sep 17 00:00:00 2001
+From: Mark Freeman <[email protected]>
+Date: Fri, 17 Apr 2026 16:28:03 -0400
+Subject: [PATCH] [release-branch.go1.25] all: update x/net to a9171bc8
+
+Fixes #78477
+
+Change-Id: I0a4c8e25f569fc1bfb8ac39ff728bfe7300b751f

meta/recipes-devtools/go/go/CVE-2026-33814.patch line 18

Quoted 10 lines
meta/recipes-devtools/go/go/CVE-2026-33814.patch new file +10 -0
+Reviewed-on: https://go-review.googlesource.com/c/go/+/768323
+Reviewed-by: Dmitri Shuralyov <[email protected]>
+TryBot-Bypass: Dmitri Shuralyov <[email protected]>
+
+CVE: CVE-2026-33814
+Upstream-Status: Backport [https://github.com/golang/go/commit/9024c3f6b150fb1349d8a5dc5e9aa31d7896f67f]
+
+Backport Changes:
+- Omitted src/go.mod, src/go.sum, and src/vendor/modules.txt because
+  their x/net version updates are not required for this focused backport.

Hi Hetvi, Yoann,

My Go knowledge is limited, but omitting the go.mod/go.sum changes didn't seem right to me. Those files track dependencies.

Looking in to it a bit further, the CVE description is:

When processing HTTP/2 SETTINGS frames, transport will enter an infinite loop of writing CONTINUATION frames if it receives a SETTINGS_MAX_FRAME_SIZE with a value of 0.

The commit message is "all: update x/net to a9171bc8", if we look at that commit in the x/net go module [1] it makes other changes which look relevant to this CVE.

[1]: https://go.googlesource.com/net/+/a9171bc8c6f19c50efad8880f96e361359ed5307%5E%21/

Could we check if the backport submitted here is a complete fix? As I say, my Go knowledge is limited, and I'm not sure how we would pick up changes to the x/net module if we need to.

Best regards,

--
Paul Barker

#4 lore raw
Quoted 8 lines · On Mon, 2026-10-19 at 09:52 +0000, Hetvi Thakar -X (hthakar - E INFOCHIPS…

Hi Paul, Yoann,

Thanks for the review.

The go.mod, go.sum, and vendor/modules.txt changes are not required for this Go 1.22 backport, as the upstream Go 1.25 commit updates the entire x/net dependency to revision a9171bc8 [1].

For Go 1.22, the required security fix is applied directly to src/net/http/h2_bundle.go [2]. The fix addresses the infinite CONTINUATION frame loop described in the CVE.

Quoted 7 lines

Updating only the dependency metadata without updating the complete vendored x/net source would be inconsistent. Since this is a focused security backport, the dependency update is not needed.

The additional validation-related change in the upstream commit is not applicable to Go 1.22, as the corresponding code is not present in this version [2].

References:
[1] https://go.googlesource.com/net/+/a9171bc8c6f19c50efad8880f96e361359ed5307%5E%21/
[2] https://github.com/golang/go/blob/go1.22.12/src/net/http/h2_bundle.go

Hi Hetvi,

If you've checked this and you're confident that the go.mod/go.sum changes are not needed then this patch can go ahead.

Best regards,

Signature · 1 line
Paul Barker