Skip to contentSkip to conversation

mm/damon/core: remove unused helper functions

PATCH Applied SJ Park 2 participants 5 messages Aug 31 – Sep 1

Subsystems (2)
lore
Share & tools
lore

SJ Park

author maintainer
#0 lore raw

v2 cover mm/damon/core: remove unused helper functions

Both damon_targets_empty() and damon_nr_running_ctxs() have had no in-tree users since commit 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") removed their remaining callers.

Remove the unused declarations and definitions.

Tested with:
make O=../linux-build-mm W=1 mm/damon

Changes from v1
- v1: https://lore.kernel.org/[email protected]
- Collect R-b: from SJ.
- Rebase to latest mm-new.

Cheng-Han Wu (1):
mm/damon/core: remove unused damon_nr_running_ctxs()

SJ Park (1):
mm/damon/core: remove unused damon_targets_empty()

 include/linux/damon.h |  2 --
 mm/damon/core.c       | 19 -------------------
 2 files changed, 21 deletions(-)

base-commit: 1faa74d984626dfc33182c71145f2ccda03179e8

Signature · 1 line
2.47.3
author maintainer
#1 lore raw

PATCH v2 1/2 mm/damon/core: remove unused damon_targets_empty()

damon_targets_empty() has had no in-tree users since commit 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") removed its last caller.

Remove the unused declaration and definition.

---
 include/linux/damon.h | 1 -
 mm/damon/core.c       | 5 -----
 2 files changed, 6 deletions(-)
include/linux/damon.h +0 -1
index 310509455db13..9835b864a8db9 100644
@@ -1056,7 +1056,6 @@ int damos_commit_quota_goals(struct damos_quota *dst, struct damos_quota *src);
 
 struct damon_target *damon_new_target(void);
 void damon_add_target(struct damon_ctx *ctx, struct damon_target *t);
-bool damon_targets_empty(struct damon_ctx *ctx);
 int damon_set_target_pid(struct damon_target *t, int pid);
 void damon_free_target(struct damon_target *t);
 void damon_destroy_target(struct damon_target *t, struct damon_ctx *ctx);
mm/damon/core.c +0 -5
index 3fa1b096c8330..043eb38de5fd3 100644
@@ -798,11 +798,6 @@ void damon_add_target(struct damon_ctx *ctx, struct damon_target *t)
 	list_add_tail(&t->list, &ctx->adaptive_targets);
 }
 
-bool damon_targets_empty(struct damon_ctx *ctx)
-{
-	return list_empty(&ctx->adaptive_targets);
-}
-
 /*
  * Assign the struct pid of the given pid number to the given target.
  */
Signature · 1 line
2.47.3
author maintainer
#4 lore raw

PATCH v2 2/2 mm/damon/core: remove unused damon_nr_running_ctxs()

In reply to SJ Park

From: Cheng-Han Wu <[email protected]>

damon_nr_running_ctxs() has had no in-tree users since commit 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") removed all of its callers.

Remove the unused declaration and definition.

---
 include/linux/damon.h |  1 -
 mm/damon/core.c       | 14 --------------
 2 files changed, 15 deletions(-)
include/linux/damon.h +0 -1
index 9835b864a8db9..6842a336291e8 100644
@@ -1067,7 +1067,6 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs);
 void damon_set_schemes(struct damon_ctx *ctx,
 			struct damos **schemes, ssize_t nr_schemes);
 int damon_commit_ctx(struct damon_ctx *old_ctx, struct damon_ctx *new_ctx);
-int damon_nr_running_ctxs(void);
 bool damon_is_registered_ops(enum damon_ops_id id);
 int damon_register_ops(struct damon_operations *ops);
 int damon_select_ops(struct damon_ctx *ctx, enum damon_ops_id id);
mm/damon/core.c +0 -14
index 043eb38de5fd3..53c3f97e3f126 100644
@@ -1866,20 +1866,6 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
 	return err;
 }
 
-/**
- * damon_nr_running_ctxs() - Return number of currently running contexts.
- */
-int damon_nr_running_ctxs(void)
-{
-	int nr_ctxs;
-
-	mutex_lock(&damon_lock);
-	nr_ctxs = nr_running_ctxs;
-	mutex_unlock(&damon_lock);
-
-	return nr_ctxs;
-}
-
 /* Returns the size upper limit for each monitoring region */
 static unsigned long damon_region_sz_limit(struct damon_ctx *ctx)
 {
Signature · 1 line
2.47.3
maintainer
#2 lore raw

Re: [PATCH v2 1/2] mm/damon/core: remove unused damon_targets_empty()

In reply to SJ Park
Quoted 7 lines · On Mon, 31 Aug 2026 07:57:21 -0700 SJ Park <[email protected]> wrote:

damon_targets_empty() has had no in-tree users since commit 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") removed its last caller.

Remove the unused declaration and definition.

I assumed that a From:Cheng-Han was intended in this patch.

Quoted 2 lines
author maintainer
#3 lore raw

Re: [PATCH v2 1/2] mm/damon/core: remove unused damon_targets_empty()

Quoted 11 lines · On Mon, 31 Aug 2026 16:19:07 -0700 Andrew Morton <[email protected]>…
Quoted 7 lines · On Mon, 31 Aug 2026 07:57:21 -0700 SJ Park <[email protected]> wrote:

damon_targets_empty() has had no in-tree users since commit 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") removed its last caller.

Remove the unused declaration and definition.

I assumed that a From:Cheng-Han was intended in this patch.

You're correct. Seems I mistakenly dropped it while resolving a conflict. I will keep this in my mind to not make same mistake next time. I found you already fixed this when you applying this to mm-new. Appreicate!

Quoted 3 lines
Quoted 3 lines

Thanks,
SJ