dt-bindings: hwmon: tmp102: Document TMP113
Subsystems (2)
PATCH v2 1/1 dt-bindings: hwmon: tmp102: Document TMP113
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.
--- .../devicetree/bindings/hwmon/ti,tmp102.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +6 -5
@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>
@@ -13,11 +13,12 @@ properties: compatible: oneOf: - items: + - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - - const: ti,tmp103 - - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103 interrupts: maxItems: 1
Signature · 1 line
2.53.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 48 lines · Marek Vasut
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.--- .../devicetree/bindings/hwmon/ti,tmp102.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +1
-1@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>@@ -13,11 +13,12 @@ properties: compatible: oneOf: - items:
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml properties: · line 21
Quoted 10 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +5
-4+ - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - - const: ti,tmp103 - - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103
Should this not be two patches, one fixing the existing stuff and one adding the 113?
Quoted 6 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +0
-0interrupts: maxItems: 1Signature · 1 line
2.53.0
Quoted 54 lines · Conor Dooley
Quoted 53 lines · Marek Vasut
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.--- .../devicetree/bindings/hwmon/ti,tmp102.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +4
-2@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>@@ -13,11 +13,12 @@ properties: compatible: oneOf: - items: + - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - - const: ti,tmp103
Quoted 8 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml properties: · line 21
Quoted 5 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +2
-3- - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103Should this not be two patches, one fixing the existing stuff and one adding the 113?
I can send this as two, sure, will do in v3.
Guenter Roeck
maintainerQuoted 54 lines · Conor Dooley
Quoted 53 lines · Marek Vasut
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.--- .../devicetree/bindings/hwmon/ti,tmp102.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +4
-2@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>@@ -13,11 +13,12 @@ properties: compatible: oneOf: - items: + - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - - const: ti,tmp103
Quoted 9 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml properties: · line 21
Quoted 5 lines
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +2
-3- - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103Should this not be two patches, one fixing the existing stuff and one adding the 113?
It is all in -next. Looks like I resolved the conflict when combining "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml" and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way. Sorry for that.
Instead of adding more patches on top of it, how about providing a single patch moving tmp103 and adding tmp110 as well as tmp113 together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
Document TMP110", apply the original (non-conflicting version) of "dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml", and then tmp110 and tmp113 could be added in a single patch.
Please let me know.
Thanks,
Guenter
On 9/1/26 7:48 PM, Guenter Roeck wrote:
Hello Guenter,
Quoted 19 lines
Quoted 9 lines
Quoted 9 lines
(quoted diff) +0
-0@@ -13,11 +13,12 @@ properties:compatible:
oneOf:
- items:
+ - enum:
+ - ti,tmp110
+ - ti,tmp113
- const: ti,tmp102
- - const: ti,tmp103Quoted 9 lines
Quoted 5 lines
- - const: ti,tmp110
- - enum:
- - ti,tmp102
+ - const: ti,tmp102
+ - const: ti,tmp103Should this not be two patches, one fixing the existing stuff and one adding the 113?
Quoted 4 lines
It is all in -next. Looks like I resolved the conflict when combining "dt-bindings: hwmon: tmp102: move ti,tmp103 out of
trivial-devices.yaml" and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way. Sorry for that.
No worries, I hope V3 I just sent fixes it up.
Quoted 8 lines
Instead of adding more patches on top of it, how about providing a single patch moving tmp103 and adding tmp110 as well as tmp113 together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
Document TMP110", apply the original (non-conflicting version) of "dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml", and then tmp110 and tmp113 could be added in a single patch.Please let me know.
I think the broken commit is d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and v3 1/2 is the fix for that broken commit. V3 2/2 only adds the missing TMP113 .
So I think there are two options:
- The complicated one -- squash d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and V3 1/2 (and either do it in tree, or drop d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") and ask for it to be updated and resent), then apply that, and apply V3 2/2 (or newer) .
- The simple one -- apply both V3 patches (or whatever newer version is good enough) and move on.
Just let me know what you like better.
Quoted 51 lines · Marek Vasut
On 9/1/26 7:48 PM, Guenter Roeck wrote:
Hello Guenter,
Quoted 19 lines
Quoted 9 lines
Quoted 9 lines
(quoted diff) +0
-0@@ -13,11 +13,12 @@ properties:compatible:
oneOf:
- items:
+ - enum:
+ - ti,tmp110
+ - ti,tmp113
- const: ti,tmp102
- - const: ti,tmp103Quoted 9 lines
Quoted 5 lines
- - const: ti,tmp110
- - enum:
- - ti,tmp102
+ - const: ti,tmp102
+ - const: ti,tmp103Should this not be two patches, one fixing the existing stuff and one adding the 113?
Quoted 4 lines
It is all in -next. Looks like I resolved the conflict when combining "dt-bindings: hwmon: tmp102: move ti,tmp103 out of
trivial-devices.yaml" and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way. Sorry for that.No worries, I hope V3 I just sent fixes it up.
Quoted 8 lines
Instead of adding more patches on top of it, how about providing a single patch moving tmp103 and adding tmp110 as well as tmp113 together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
Document TMP110", apply the original (non-conflicting version) of "dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml", and then tmp110 and tmp113 could be added in a single patch.Please let me know.
I think the broken commit is
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") and v3 1/2 is the fix for that broken commit. V3 2/2 only adds the missing TMP113 .So I think there are two options:
- The complicated one -- squashd67ec24d3f07("dt-bindings: hwmon: tmp102:
move ti,tmp103 out oftrivial-devices.yaml") and V3 1/2 (and either do it in tree, or dropd67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") and ask for it to be updated and resent), then apply that, and apply V3 2/2 (or newer) .
- The simple one -- apply both V3 patches (or whatever newer version is good enough) and move on.
Quoted 1 line
Just let me know what you like better.
Either works for me fwiw, v3 looks fine.
Guenter Roeck
maintainerQuoted 37 lines · Marek Vasut
On 9/1/26 7:48 PM, Guenter Roeck wrote:
Hello Guenter,
Quoted 19 lines
Quoted 9 lines
Quoted 9 lines
(quoted diff) +0
-0@@ -13,11 +13,12 @@ properties:compatible:
oneOf:
- items:
+ - enum:
+ - ti,tmp110
+ - ti,tmp113
- const: ti,tmp102
- - const: ti,tmp103Quoted 9 lines
Quoted 5 lines
- - const: ti,tmp110
- - enum:
- - ti,tmp102
+ - const: ti,tmp102
+ - const: ti,tmp103Should this not be two patches, one fixing the existing stuff and one adding the 113?
Quoted 4 lines
It is all in -next. Looks like I resolved the conflict when combining "dt-bindings: hwmon: tmp102: move ti,tmp103 out of
trivial-devices.yaml" and "dt-bindings: hwmon: tmp102: Document TMP110" the wrong way. Sorry for that.No worries, I hope V3 I just sent fixes it up.
Quoted 7 lines
Instead of adding more patches on top of it, how about providing a single patch moving tmp103 and adding tmp110 as well as tmp113 together ? Alternatively, I could drop "dt-bindings: hwmon: tmp102:
Document TMP110", apply the original (non-conflicting version) of "dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml", and then tmp110 and tmp113 could be added in a single patch.
Quoted 5 lines
Quoted 1 line
Please let me know.
I think the broken commit is
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") and v3 1/2 is the fix for that broken commit. V3 2/2 only adds the missing TMP113 .So I think there are two options:
- The complicated one -- squashd67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") and V3 1/2 (and either do it in tree, or dropd67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") and ask for it to be updated and resent), then apply that, and apply V3 2/2 (or newer) .
I'll do that, assuming that Conor is ok with both patches. No need to resend anything.
Thanks,
Guenter