Skip to contentSkip to conversation

FAILED: patch "[PATCH] platform/x86: ISST: Validate parameter for core power state" failed to apply to 6.6-stable tree

PATCH New [email protected] 2 participants 2 messages Sep 3 – Sep 9

Subsystems (3)
Stable branch x86 platform drivers Intel speed select technology
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x 1700b4f804555467b7eff58dff7acc11d508b3a1
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026090321-shock-prewashed-03da@gregkh' --subject-prefix 'PATCH 6.6.y' 'HEAD^..'

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 1700b4f804555467b7eff58dff7acc11d508b3a1 Mon Sep 17 00:00:00 2001
From: Srinivas Pandruvada <[email protected]>
Date: Tue, 11 Aug 2026 15:15:11 -0700
Subject: [PATCH] platform/x86: ISST: Validate parameter for core power state
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Allow only 0 or 1 for core_power enable and priority_type parameters.

Fixes 12a7d2cb811d ("platform/x86: ISST: Add SST-CP support via TPMI")
Cc [email protected]
Signed-off-by Srinivas Pandruvada <[email protected]>
Link https://patch.msgid.link/[email protected] open here
Reviewed-by Ilpo Järvinen <[email protected]>
Signed-off-by Ilpo Järvinen <[email protected]>
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +7 -0
index 7be50d4167be..8f63694da897 100644
@@ -599,6 +599,9 @@ static bool disable_dynamic_sst_features(void)
 #define SST_CP_PRIORITY_TYPE_START	1
 #define SST_CP_PRIORITY_TYPE_WIDTH	1
 
+#define SST_CP_MAX_ENABLE		1
+#define SST_CP_MAX_PRIORITY_TYPE	1
+
 static long isst_if_core_power_state(void __user *argp)
 {
 	struct tpmi_per_power_domain_info *power_domain_info;

@@ -618,6 +621,10 @@ static long isst_if_core_power_state(void __user *argp)
 		if (power_domain_info->write_blocked || !capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
+		if (core_power.enable > SST_CP_MAX_ENABLE ||
+		    core_power.priority_type > SST_CP_MAX_PRIORITY_TYPE)
+			return -EINVAL;
+
 		_write_cp_info("cp_enable", core_power.enable, SST_CP_CONTROL_OFFSET,
 			       SST_CP_ENABLE_START, SST_CP_ENABLE_WIDTH, SST_MUL_FACTOR_NONE)
 		_write_cp_info("cp_prio_type", core_power.priority_type, SST_CP_CONTROL_OFFSET,
maintainer
#1 lore raw

PATCH 1/1 platform/x86: ISST: Validate parameter for core power state

From: Srinivas Pandruvada <[email protected]>

[ Upstream commit 1700b4f804555467b7eff58dff7acc11d508b3a1 ]

Allow only 0 or 1 for core_power enable and priority_type parameters.

Fixes 12a7d2cb811d ("platform/x86: ISST: Add SST-CP support via TPMI")
Cc [email protected]
Signed-off-by Srinivas Pandruvada <[email protected]>
Link https://patch.msgid.link/[email protected] open here
Reviewed-by Ilpo Järvinen <[email protected]>
Signed-off-by Ilpo Järvinen <[email protected]>
[ adjusted context for the missing write_blocked/CAP_SYS_ADMIN permission check. ]
Signed-off-by Sasha Levin <[email protected]>
---
 .../platform/x86/intel/speed_select_if/isst_tpmi_core.c    | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +7 -0
index df0b0118b751f..64a7eefb99674 100644
@@ -450,6 +450,9 @@ static bool disable_dynamic_sst_features(void)
 #define SST_CP_PRIORITY_TYPE_START	1
 #define SST_CP_PRIORITY_TYPE_WIDTH	1
 
+#define SST_CP_MAX_ENABLE		1
+#define SST_CP_MAX_PRIORITY_TYPE	1
+
 static long isst_if_core_power_state(void __user *argp)
 {
 	struct tpmi_per_power_domain_info *power_domain_info;

@@ -466,6 +469,10 @@ static long isst_if_core_power_state(void __user *argp)
 		return -EINVAL;
 
 	if (core_power.get_set) {
+		if (core_power.enable > SST_CP_MAX_ENABLE ||
+		    core_power.priority_type > SST_CP_MAX_PRIORITY_TYPE)
+			return -EINVAL;
+
 		_write_cp_info("cp_enable", core_power.enable, SST_CP_CONTROL_OFFSET,
 			       SST_CP_ENABLE_START, SST_CP_ENABLE_WIDTH, SST_MUL_FACTOR_NONE)
 		_write_cp_info("cp_prio_type", core_power.priority_type, SST_CP_CONTROL_OFFSET,
Signature · 1 line
2.53.0