FAILED: patch "[PATCH] power: supply: twl4030_charger: cancel workers via devm" failed to apply to 5.10-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x 6eba34732524067da2aad5ddfdfbc641ded10e9e
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026090356-iphone-deviate-2dac@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 6eba34732524067da2aad5ddfdfbc641ded10e9e Mon Sep 17 00:00:00 2001
From: Maoyi Xie <[email protected]>
Date: Sat, 25 Jul 2026 15:25:40 +0800
Subject: [PATCH] power: supply: twl4030_charger: cancel workers via devm
bci is devm-allocated. Two workers (bci->work and bci->current_worker) dereference it. twl4030_bci_remove() disables charging and masks interrupts. It cancels neither worker. A worker pending at remove() can run after devm frees bci.
The USB transceiver comes from devm_usb_get_phy_by_node(). devm unregisters its notifier only after remove() returns. A cancel_work_sync() in remove() can then race a notifier reschedule. devm_work_autocancel() and devm_delayed_work_autocancel() avoid that. They cancel the workers during devm release, before bci is freed.
The current_worker is registered first, since devm will cancel in reverse order and bci->work can reschedule current_worker.
drivers/power/supply/twl4030_charger.c +10 -2
@@ -14,6 +14,7 @@#include <linux/err.h> #include <linux/of.h> #include <linux/platform_device.h> +#include <linux/devm-helpers.h> #include <linux/interrupt.h> #include <linux/mfd/twl.h> #include <linux/power_supply.h>
@@ -1002,8 +1003,15 @@ static int twl4030_bci_probe(struct platform_device *pdev)platform_set_drvdata (pdev, bci); -INIT_WORK (&bci->work, twl4030_bci_usb_work); -INIT_DELAYED_WORK (&bci->current_worker, twl4030_current_worker); + ret =devm_delayed_work_autocancel (&pdev->dev, &bci->current_worker, + twl4030_current_worker); +if (ret) +return ret; + + ret =devm_work_autocancel (&pdev->dev, &bci->work, + twl4030_bci_usb_work); +if (ret) +return ret; bci->channel_vac =devm_iio_channel_get (&pdev->dev,"vac" );if (IS_ERR (bci->channel_vac)) {
Sasha Levin
maintainerPATCH 1/3 workqueue: Add resource managed version of delayed work init
From: Matti Vaittinen <[email protected]>
[ Upstream commit 0341ce5443949588e93581b49b934cdde2befbf8 ]
A few drivers which need a delayed work-queue must cancel work at driver detach. Some of those implement remove() solely for this purpose. Help drivers to avoid unnecessary remove and error-branch implementation by adding managed verision of delayed work initialization. This will also help drivers to avoid mixing manual and devm based unwinding when other resources are handled by devm.
Stable-dep-of: 6eba34732524 ("power: supply: twl4030_charger: cancel workers via devm")
--- include/linux/devm-helpers.h | 53 ++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 include/linux/devm-helpers.h
include/linux/devm-helpers.h new file +53 -0
@@ -0,0 +1,53 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __LINUX_DEVM_HELPERS_H +#define __LINUX_DEVM_HELPERS_H + +/* +* Functions which do automatically cancel operations or release resources upon +* driver detach. +* +* These should be helpful to avoid mixing the manual and devm-based resource +* management which can be source of annoying, rarely occurring, +* hard-to-reproduce bugs. +* +* Please take into account that devm based cancellation may be performed some +* time after the remove() is ran. +* +* Thus mixing devm and manual resource management can easily cause problems +* when unwinding operations with dependencies. IRQ scheduling a work in a queue +* is typical example where IRQs are often devm-managed and WQs are manually +* cleaned at remove(). If IRQs are not manually freed at remove() (and this is +* often the case when we use devm for IRQs) we have a period of time after +* remove() - and before devm managed IRQs are freed - where new IRQ may fire +* and schedule a work item which won't be cancelled because remove() was +* already ran. +*/ + +#include <linux/device.h> +#include <linux/workqueue.h> + +static inline void devm_delayed_work_drop (void *res) +{ +cancel_delayed_work_sync (res); +} + +/** +* devm_delayed_work_autocancel - Resource-managed work allocation +* @dev: Device which lifetime work is bound to +* @pdata: work to be cancelled when driver is detached +* +* Initialize work which is automatically cancelled when driver is detached. +* A few drivers need delayed work which must be cancelled before driver +* is detached to avoid accessing removed resources. +* devm_delayed_work_autocancel() can be used to omit the explicit +* cancelleation when driver is detached. +*/ +static inline int devm_delayed_work_autocancel (struct device *dev, +struct delayed_work *w, +work_func_t worker) +{ +INIT_DELAYED_WORK (w, worker); +return devm_add_action (dev, devm_delayed_work_drop, w); +} + +#endif
Signature · 1 line
2.53.0
Sasha Levin
maintainerPATCH 2/3 devm-helpers: Add resource managed version of work init
From: Matti Vaittinen <[email protected]>
[ Upstream commit 7a2c4cc537fa9f05fe90812e7d789b9faf7eb869 ]
A few drivers which need a work-queue must cancel work at driver detach. Some of those implement remove() solely for this purpose. Help drivers to avoid unnecessary remove and error-branch implementation by adding managed verision of work initialization. This will also help drivers to avoid mixing manual and devm based unwinding when other resources are handled by devm.
Stable-dep-of: 6eba34732524 ("power: supply: twl4030_charger: cancel workers via devm")
--- include/linux/devm-helpers.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
include/linux/devm-helpers.h +25 -0
@@ -50,4 +50,29 @@ static inline int devm_delayed_work_autocancel(struct device *dev, return devm_add_action(dev, devm_delayed_work_drop, w); } +static inline void devm_work_drop (void *res) +{ +cancel_work_sync (res); +} + +/** +* devm_work_autocancel - Resource-managed work allocation +* @dev: Device which lifetime work is bound to +* @w: Work to be added (and automatically cancelled) +* @worker: Worker function +* +* Initialize work which is automatically cancelled when driver is detached. +* A few drivers need to queue work which must be cancelled before driver +* is detached to avoid accessing removed resources. +* devm_work_autocancel() can be used to omit the explicit +* cancelleation when driver is detached. +*/ +static inline int devm_work_autocancel (struct device *dev, +struct work_struct *w, +work_func_t worker) +{ +INIT_WORK (w, worker); +return devm_add_action (dev, devm_work_drop, w); +} +#endif
Signature · 1 line
2.53.0
Sasha Levin
maintainerPATCH 3/3 power: supply: twl4030_charger: cancel workers via devm
In reply to Sasha LevinFrom: Maoyi Xie <[email protected]>
[ Upstream commit 6eba34732524067da2aad5ddfdfbc641ded10e9e ]
bci is devm-allocated. Two workers (bci->work and bci->current_worker) dereference it. twl4030_bci_remove() disables charging and masks interrupts. It cancels neither worker. A worker pending at remove() can run after devm frees bci.
The USB transceiver comes from devm_usb_get_phy_by_node(). devm unregisters its notifier only after remove() returns. A cancel_work_sync() in remove() can then race a notifier reschedule. devm_work_autocancel() and devm_delayed_work_autocancel() avoid that. They cancel the workers during devm release, before bci is freed.
The current_worker is registered first, since devm will cancel in reverse order and bci->work can reschedule current_worker.
--- drivers/power/supply/twl4030_charger.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/power/supply/twl4030_charger.c +10 -2
@@ -13,6 +13,7 @@#include <linux/slab.h> #include <linux/err.h> #include <linux/platform_device.h> +#include <linux/devm-helpers.h> #include <linux/interrupt.h> #include <linux/mfd/twl.h> #include <linux/power_supply.h>
@@ -1004,8 +1005,15 @@ static int twl4030_bci_probe(struct platform_device *pdev)platform_set_drvdata (pdev, bci); -INIT_WORK (&bci->work, twl4030_bci_usb_work); -INIT_DELAYED_WORK (&bci->current_worker, twl4030_current_worker); + ret =devm_delayed_work_autocancel (&pdev->dev, &bci->current_worker, + twl4030_current_worker); +if (ret) +return ret; + + ret =devm_work_autocancel (&pdev->dev, &bci->work, + twl4030_bci_usb_work); +if (ret) +return ret; bci->channel_vac =devm_iio_channel_get (&pdev->dev,"vac" );if (IS_ERR (bci->channel_vac)) {
Signature · 1 line
2.53.0