dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible
Subsystems (2)
PATCH 1/1 dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible
The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO expander and is register-compatible with it. The addition of the compatible in the driver missed the documentation update.
--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +1 -0
@@ -67,6 +67,7 @@ properties: - nxp,pcal9555a - onnn,cat9554 - onnn,pca9654 + - onnn,pca9655 - ti,pca6107 - ti,pca9536 - ti,tca6408
Signature · 1 line
2.55.0
Quoted 3 lines · Rosen Penev
The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO expander and is register-compatible with it. The addition of the compatible in the driver missed the documentation update.
The commit message makes it sound like this device should use a fallback. Why doesn't it? Either it should, or the commit message needs an update.
pw-bot: changes-requested
Thanks,
Conor.
Quoted 23 lines
Fixes 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi pca9655")Assisted-by opencode:big-pickleSigned-off-by Rosen Penev <[email protected]>--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +1
-0@@ -67,6 +67,7 @@ properties: - nxp,pcal9555a - onnn,cat9554 - onnn,pca9654 + - onnn,pca9655 - ti,pca6107 - ti,pca9536 - ti,tca6408Signature · 1 line
2.55.0
Bartosz Golaszewski
maintainerQuoted 10 lines · Conor Dooley
Quoted 3 lines · Rosen Penev
The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO expander and is register-compatible with it. The addition of the compatible in the driver missed the documentation update.
The commit message makes it sound like this device should use a fallback. Why doesn't it? Either it should, or the commit message needs an update.
pw-bot: changes-requested
Actually commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi pca9655") added this compatible to the driver back in 2021 but it had remained undocumented until now. Unfortunately there's no denying I signed off on it. :(
This commit should probably contain a Fixes: tag pointing at this commit.
Bart
Quoted 12 lines · Bartosz Golaszewski
Quoted 10 lines · Conor Dooley
Quoted 3 lines · Rosen Penev
The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO expander and is register-compatible with it. The addition of the compatible in the driver missed the documentation update.
The commit message makes it sound like this device should use a fallback. Why doesn't it? Either it should, or the commit message needs an update.
pw-bot: changes-requested
Quoted 3 lines
Actually commit
6d49b3a0f351("gpio: pca953x: Add support for the On Semi pca9655") added this compatible to the driver back in 2021 but it had remained undocumented until now. Unfortunately there's no denying I signed off on it. :(
Ye, but if patches like this appear for things that were undocumented but ended up in drivers we still try to get the bindings correct when they do show up. The commit message is basically telling me that this patch is wrong and that a fallback to the pca9555 should be used. There's no impact on the driver, so I don't see any harm in getting the binding right.
Quoted 1 line
This commit should probably contain a Fixes: tag pointing at this commit.
Perhaps, but I'm not convinced that binding patches should ever have Fixes tags citing drivers.