Skip to contentSkip to conversation

sound/soc/ux500/ux500_msp_i2s.h:150:38: warning: suggest parentheses around arithmetic in operand of '^'

PATCH kernel test robot 1 participant 1 message Sep 5

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git b4/ux500-msp-fixes
head:   2f95df02f538f1fca7974cb317d05bea56b96a82
commit: a68d4e15f02ffb40f55509d32630a549168d1b5d [5/10] ASoC: ux500: Validate MSP DAI configuration
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20260905/[email protected]/config)
compiler: arm-linux-gnueabi-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260905/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

In file included from sound/soc/ux500/ux500_msp_i2s.c:20:
sound/soc/ux500/ux500_msp_i2s.c: In function 'configure_protocol':

>> sound/soc/ux500/ux500_msp_i2s.h:150:38: warning: suggest parentheses around arithmetic in operand of '^' [-Wparentheses]
     150 | #define MSP_TX_CLKPOL_BIT(n)     ((n & TCKPOL_MASK) << TCKPOL_SHIFT)
   sound/soc/ux500/ux500_msp_i2s.c:204:21: note: in expansion of macro 'MSP_TX_CLKPOL_BIT'
     204 |         temp_reg |= MSP_TX_CLKPOL_BIT(!protdesc->tx_clk_pol ^
         |                     ^~~~~~~~~~~~~~~~~
   sound/soc/ux500/ux500_msp_i2s.h:149:38: warning: suggest parentheses around arithmetic in operand of '^' [-Wparentheses]
     149 | #define MSP_RX_CLKPOL_BIT(n)     ((n & RCKPOL_MASK) << RCKPOL_SHIFT)
   sound/soc/ux500/ux500_msp_i2s.c:208:21: note: in expansion of macro 'MSP_RX_CLKPOL_BIT'
     208 |         temp_reg |= MSP_RX_CLKPOL_BIT(protdesc->rx_clk_pol ^
         |                     ^~~~~~~~~~~~~~~~~

vim +150 sound/soc/ux500/ux500_msp_i2s.h

3592b7f69a54388 Ola Lilja 2012-05-08  145  
3592b7f69a54388 Ola Lilja 2012-05-08  146  #define RCKPOL_MASK		BIT(0)
3592b7f69a54388 Ola Lilja 2012-05-08  147  #define TCKPOL_MASK		BIT(0)
3592b7f69a54388 Ola Lilja 2012-05-08  148  #define SPICKM_MASK		(BIT(1) | BIT(0))
3592b7f69a54388 Ola Lilja 2012-05-08  149  #define MSP_RX_CLKPOL_BIT(n)     ((n & RCKPOL_MASK) << RCKPOL_SHIFT)

3592b7f69a54388 Ola Lilja 2012-05-08 @150 #define MSP_TX_CLKPOL_BIT(n) ((n & TCKPOL_MASK) << TCKPOL_SHIFT)
3592b7f69a54388 Ola Lilja 2012-05-08 151

:::::: The code at line 150 was first introduced by commit
:::::: 3592b7f69a5438812381ff0aacdea1725ffa1c1c ASoC: Ux500: Add MSP I2S-driver

:::::: TO: Ola Lilja <[email protected]> :::::: CC: Mark Brown <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki