usb: musb: omap2430: propagate PHY setup errors
cover usb: musb: omap2430: propagate PHY setup errors
The OMAP2430 glue ignores generic PHY initialization and power-on failures during initial setup, runtime resume and system resume. The callers can therefore access glue registers or publish resumed state without a usable PHY.
Keep the three lifecycle transitions separate so each patch has one failure state and one introducing commit. Each power-on failure exits a PHY that was initialized by the same transition.
The issues were found by our static-analysis tool and manually reviewed.
Pengpeng Hou (3):
usb: musb: omap2430: Propagate PHY errors from init
usb: musb: omap2430: Propagate PHY errors from runtime resume
usb: musb: omap2430: Propagate PHY errors from system resume
drivers/usb/musb/omap2430.c | 35 +++++++++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 6 deletions(-)
Signature · 1 line
2.50.1 (Apple Git-155)
Greg Kroah-Hartman
maintainerQuoted 10 lines · Pengpeng Hou
The OMAP2430 glue ignores generic PHY initialization and power-on failures during initial setup, runtime resume and system resume. The callers can therefore access glue registers or publish resumed state without a usable PHY.
Keep the three lifecycle transitions separate so each patch has one failure state and one introducing commit. Each power-on failure exits a PHY that was initialized by the same transition.
The issues were found by our static-analysis tool and manually reviewed.
None of these were properly "threaded" and can't be picked up by our tools. Please fix that up and resend the full series.
thanks,
greg k-h