Skip to contentSkip to conversation

Add process_mrelease testing suite

PATCH In review Andrea Cervesato 3 participants 6 messages Sep 7 – Oct 27

lore
Share & tools
lore
#0 lore raw

v3 cover Add process_mrelease testing suite

This testing suite is meant to add coverage for process_mrelease() syscall, introduced in the kernel 5.15.

The testing suite is providing following tests:
- process_mrelease01
- process_mrelease02

Since there's no man pages, please consider the following documentation instead:

https://lwn.net/Articles/864184/
https://lwn.net/Articles/865341/

---
Changes in v3:
process_mrelease01:
- drop /proc/<pid>/maps check and unused shared memory setup
- retry on ESRCH with exponentially increasing memory allocations
- pass immediately when process_mrelease() returns success
- remove unneeded needs_root flag
- fix author name typo and description formatting

process_mrelease02:
- wait for child process after checkpoint wake to avoid zombies
- remove unneeded needs_root flag
- update doc comment formatting

Changes in v2:
- process_mrelease01: change the algorithm to ensure we released the
memory after process_mrelease() is called
- process_mrelease02: verify ESRCH error
- Link to v1: https://lore.kernel.org/r/[email protected]

To: Linux Test Project <[email protected]>

---
Andrea Cervesato (2):
Add process_mrelease01 test
Add process_mrelease02 test

 runtest/syscalls                                   |  3 +
 .../kernel/syscalls/process_mrelease/.gitignore    |  2 +
 .../kernel/syscalls/process_mrelease/Makefile      |  7 ++
 .../syscalls/process_mrelease/process_mrelease01.c | 94 ++++++++++++++++++++++
 .../syscalls/process_mrelease/process_mrelease02.c | 90 +++++++++++++++++++++
 5 files changed, 196 insertions(+)

---
base-commit: 463b33ad464b6840d0a1df5d41939e50d55d542c
change-id: 20240522-process_mrelease-3f2632b432e6

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v3 1/2 Add process_mrelease01 test

From: Andrea Cervesato <[email protected]>

Verify process_mrelease() releases memory from a dying process. If the child process terminates before the syscall can reap its address space, retry with larger memory allocations to extend teardown duration.

---
 runtest/syscalls                                   |  2 +
 .../kernel/syscalls/process_mrelease/.gitignore    |  1 +
 .../kernel/syscalls/process_mrelease/Makefile      |  7 ++
 .../syscalls/process_mrelease/process_mrelease01.c | 94 ++++++++++++++++++++++
 4 files changed, 104 insertions(+)
runtest/syscalls +2 -0
index 737c63e31..cfe76efca 100644
@@ -1151,6 +1151,8 @@ preadv203_64 preadv203_64
 
 profil01 profil01
 
+process_mrelease01 process_mrelease01
+
 process_vm_readv01 process_vm01 -r
 process_vm_readv02 process_vm_readv02
 process_vm_readv03 process_vm_readv03
testcases/kernel/syscalls/process_mrelease/.gitignore new file +1 -0
new file mode 100644
index 000000000..673983858
@@ -0,0 +1 @@
+/process_mrelease01
testcases/kernel/syscalls/process_mrelease/Makefile new file +7 -0
new file mode 100644
index 000000000..8cf1b9024
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]>
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/process_mrelease/process_mrelease01.c new file +94 -0

94 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] Add process_mrelease01 test

Hi Andrea,

Quoted 1 line · Andrea Cervesato

Add process_mrelease01 test

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

PATCH v3 2/2 Add process_mrelease02 test

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

Verify that process_mrelease() returns expected error codes on invalid file descriptors, non-zero flags, alive processes without pending exit, and terminated processes.

---
 runtest/syscalls                                   |  1 +
 .../kernel/syscalls/process_mrelease/.gitignore    |  1 +
 .../syscalls/process_mrelease/process_mrelease02.c | 90 ++++++++++++++++++++++
 3 files changed, 92 insertions(+)
runtest/syscalls +1 -0
index cfe76efca..b456afe20 100644
@@ -1152,6 +1152,7 @@ preadv203_64 preadv203_64
 profil01 profil01
 
 process_mrelease01 process_mrelease01
+process_mrelease02 process_mrelease02
 
 process_vm_readv01 process_vm01 -r
 process_vm_readv02 process_vm_readv02
testcases/kernel/syscalls/process_mrelease/.gitignore +1 -0
index 673983858..f1e7a8fea 100644
@@ -1 +1,2 @@
 /process_mrelease01
+/process_mrelease02
testcases/kernel/syscalls/process_mrelease/process_mrelease02.c new file +90 -0

90 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

Re: [LTP] [PATCH v3 2/2] Add process_mrelease02 test

Hi!
Pushed, thanks.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp