Skip to contentSkip to conversation

package/sdl3: fix X11 dependencies

PATCH Superseded Bernd Kuhls 2 participants 2 messages Sep 8 – Sep 22

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sdl3: fix X11 dependencies

Add handling for optional X11 dependencies to fix configure errors:

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XCURSOR. Please install the needed packages or configure with -DSDL_X11_XCURSOR=OFF

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XINPUT. Please install the needed packages or configure with -DSDL_X11_XINPUT=OFF

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XSCRNSAVER. Please install the needed packages or configure with -DSDL_X11_XSCRNSAVER=OFF

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XTEST. Please install the needed packages or configure with -DSDL_X11_XTEST=OFF

Please note that SDL3 only checks for these dependencies when X11 support is enabled so we do not need to add =OFF options to the else- clause -DSDL_X11=OFF:
https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325

---
 package/sdl3/sdl3.mk | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
package/sdl3/sdl3.mk +24 -0
index ecbcbf4bc2..83c28b1b04 100644
@@ -59,6 +59,30 @@ endif
 ifeq ($(BR2_PACKAGE_SDL3_X11),y)
 SDL3_DEPENDENCIES += xlib_libX11 xlib_libXext
 SDL3_CONF_OPTS += -DSDL_X11=ON
+ifeq ($(BR2_PACKAGE_XAPP_XINPUT),y)
+SDL3_DEPENDENCIES += xapp_xinput
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXCURSOR),y)
+SDL3_DEPENDENCIES += xlib_libXcursor
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXSCRNSAVER),y)
+SDL3_DEPENDENCIES += xlib_libXScrnSaver
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=OFF
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXTST),y)
+SDL3_DEPENDENCIES += xlib_libXtst
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=OFF
+endif
 else
 SDL3_CONF_OPTS += -DSDL_X11=OFF
 endif
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Bernd,

Thanks for the patch.

Quoted 17 lines · Bernd Kuhls

Add handling for optional X11 dependencies to fix configure errors:

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XCURSOR. Please install the
needed
packages or configure with -DSDL_X11_XCURSOR=OFF

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XINPUT. Please install the
needed
packages or configure with -DSDL_X11_XINPUT=OFF

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XSCRNSAVER. Please install the
needed
packages or configure with -DSDL_X11_XSCRNSAVER=OFF

Quoted 4 lines

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XTEST. Please install the
needed
packages or configure with -DSDL_X11_XTEST=OFF

While trying this patch with the following commands:

cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_SDL3=y
BR2_PACKAGE_SDL3_X11=y
BR2_PACKAGE_XORG7=y
EOF
make olddefconfig
make sdl3

I had the following error:

CMake Error at cmake/macros.cmake:433 (message):
Couldn't find dependency package for XFIXES. Please install the
needed
packages or configure with -DSDL_X11_XFIXES=OFF

Could you have a look, please?

I did not checked if there is other instances of those dependency checks.

Quoted 6 lines

Please note that SDL3 only checks for these dependencies when X11 support is enabled so we do not need to add =OFF options to the else- clause -DSDL_X11=OFF:
https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot