arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
Subsystems (2)
PATCH 1/1 arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
Describe ID EEPROM nWP GPIO, label and nvmem layout. The i.MX8MM eDM SBC and i.MX8MP eDM SBC nvmem layout is almost identical, except for length of product-name@32 field, which is 19 Bytes on the Mini and 24 Bytes on the Plus.
---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frank Li <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- .../freescale/imx8mm-data-modul-edm-sbc.dts | 56 ++++++++ .../freescale/imx8mp-data-modul-edm-sbc.dts | 128 ++++++++++++++++++ 2 files changed, 184 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +56 -0
@@ -431,7 +431,63 @@ usb-hub@2c { eeprom: eeprom@50 { compatible = "atmel,24c32"; reg = <0x50>; + label = "dmo-board-info"; pagesize = <32>; + wp-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; + + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + company-name@24 { + reg = <0x24 0xd>; + }; + + product-name@32 { + reg = <0x32 0x13>; + }; + + board-revision@4b { + reg = <0x4b 0x3>; + }; + + serial-number@4f { + reg = <0x4f 0x8>; + }; + + manufacturing-date@70 { + reg = <0x70 0xa>; + }; + + test-date@7b { + reg = <0x7b 0xa>; + }; + + product-number@86 { + reg = <0x86 0x8>; + }; + + board-variant@9a { + reg = <0x9a 0x9>; + }; + + company-acronym@a4 { + reg = <0xa4 0x3>; + }; + + mac-address@b0 { + reg = <0xb0 0x6>; + }; + + board-id@100 { + reg = <0x100 0x4>; + }; + + wifi-id@1200 { + reg = <0x120 0x4>; + }; + }; }; rtc: rtc@68 {
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +128 -0
142 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Devicetree unit address mismatch for `wifi-id` node --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch for wifi-id node
--
commit 082793f42f1059431835df44206b8d1014d852b6
Author: Marek Vasut <[email protected]>
arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
This commit describes the ID EEPROM nWP GPIO, label, and nvmem layout for the i.MX8MM and i.MX8MP eDM SBCs.
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +0
-0
[ ... ]
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts usb-hub@2c { · line 489
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +7
-0+ board-id@100 { + reg = <0x100 0x4>; + }; + + wifi-id@1200 { + reg = <0x120 0x4>; + };
[Severity: Low]
Does this unit address mismatch the reg property? The node name uses 1200, but the base address in the reg property is 120. This will likely cause a dtc compiler warning for a simple-bus unit address format error.
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +1
-0+ }; };arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0
-0
[ ... ]
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +7
-0+ board-id@100 { + reg = <0x100 0x4>; + }; + + wifi-id@1200 { + reg = <0x120 0x4>; + };
[Severity: Low]
Is the unit address 1200 a typo here as well? The reg property specifies 120 for the i.MX8MP SBC rev.900, which does not match the node name.
[ ... ]
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +7
-0+ board-id@100 { + reg = <0x100 0x4>; + }; + + wifi-id@1200 { + reg = <0x120 0x4>; + };
[Severity: Low]
Similarly for the i.MX8MP SBC rev.902, should this unit address be updated to match the 120 specified in the reg property?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1