perf stat: Avoid uninitialized memory read on error
Ian Rogers
reviewerPATCH 1/1 perf stat: Avoid uninitialized memory read on error
If has_supported_counters fails then msg was passed to ui__error regardless of whether an error was written into msg leading to reading uninitialized memory. Avoid this by always terminating msg at initialization.
Opportunistically reduce the scope of msg to make its use clearer.
--- tools/perf/builtin-stat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-stat.c +3 -1
@@ -777,7 +777,6 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)int interval = stat_config.interval;int times = stat_config.times;int timeout = stat_config.timeout; -char msg[BUFSIZ ];unsigned long long t0, t1;struct evsel *counter;size_t l;
@@ -908,6 +907,9 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx) } }if (!has_supported_counters && !stat_config.null_run) { +char msg[BUFSIZ ]; + + msg[0 ] ='\0' ;if (open_err) {evsel__open_strerror (evlist__first (evsel_list), &target, open_err, msg,sizeof (msg));
Signature · 1 line
2.55.0.979.g7e5102b832-goog
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Atomic Conclusion: Unchecked ERR_PTR from hashmap__new() causes predictable application crashes. The return value is incorrectly checked against NULL instead of IS_ERR(). --
commit 525c560536a62c39331ec585b1ce897decf7179c
Author: Ian Rogers <[email protected]>
perf stat: Avoid uninitialized memory read on error
If has_supported_counters fails then msg was passed to ui__error regardless of whether an error was written into msg leading to reading uninitialized memory. Avoid this by always terminating msg at initialization.
tools/perf/builtin-stat.c
Quoted 4 lines
tools/perf/builtin-stat.c +0
-0
[ ... ]
[Severity: High]
This isn't a bug introduced by this patch, but I noticed that the return value of hashmap__new() is incorrectly checked against NULL instead of IS_ERR().
Since hashmap__new() returns an ERR_PTR on failure, this will cause predictable crashes under memory pressure instead of graceful error handling.
For example, in tools/perf/util/pmu.c:perf_pmu__init():
pmu->aliases = hashmap__new(aliases__hash, aliases__equal, /*ctx=*/ NULL);
if (!pmu->aliases)
return -ENOMEM;And similarly in tools/perf/util/pmu.c:perf_pmu__create_placeholder_core_pmu():
pmu->aliases = hashmap__new(aliases__hash, aliases__equal, /*ctx=*/ NULL);
INIT_LIST_HEAD(&pmu->caps);Also in tools/perf/util/fncache.c:fncache__init():
fncache = hashmap__new(fncache__hash, fncache__equal, /*ctx=*/NULL);
Should these locations be updated to use IS_ERR() when validating the result of hashmap__new()?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Ian Rogers
reviewerQuoted 5 lines · On Tue, Sep 8, 2026 at 3:23 PM <[email protected]> wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Atomic Conclusion: UncheckedERR_PTRfromhashmap__new()causes predictable application crashes. The return value is incorrectly checked against NULL instead ofIS_ERR().
Yep, libbpf's hashmap is a thorn in the side of correctness and ERR_PTRs are the devil's work. The hashmap code also intentionally has undefined behavior. I sent this series:
https://lore.kernel.org/linux-perf-users/[email protected]/
to address this. Since the BPF folks are happy with the current state, I think we should fork the code to avoid issues in perf - we'll still suffer with the hashmaps in libbpf. I was investigating whether we can add some form of generics to hashmaps too. Anyway, the issues reported here are correct and genuine bugs, but they aren't relevant to this patch.
Thanks,
Ian
Quoted 48 lines
--
commit
525c560536a62c39331ec585b1ce897decf7179c
Author: Ian Rogers <[email protected]>perf stat: Avoid uninitialized memory read on error
If
has_supported_countersfails then msg was passed toui__errorregardless of whether an error was written into msg leading to reading uninitialized memory. Avoid this by always terminating msg at initialization.tools/perf/builtin-stat.c
Quoted 4 lines
tools/perf/builtin-stat.c +0
-0[ ... ]
[Severity: High]
This isn't a bug introduced by this patch, but I noticed that the return value ofhashmap__new()is incorrectly checked against NULL instead ofIS_ERR().Since
hashmap__new()returns anERR_PTRon failure, this will cause predictable crashes under memory pressure instead of graceful error handling.For example, in tools/perf/util/pmu.c:perf_pmu__init():
pmu->aliases = hashmap__new(aliases__hash, aliases__equal, /*ctx=*/ NULL); if (!pmu->aliases) return -ENOMEM;And similarly in tools/perf/util/pmu.c:perf_pmu__create_placeholder_core_pmu():
pmu->aliases = hashmap__new(aliases__hash, aliases__equal, /*ctx=*/ NULL); INIT_LIST_HEAD(&pmu->caps);Also in tools/perf/util/fncache.c:fncache__init():
fncache = hashmap__new(fncache__hash, fncache__equal, /*ctx=*/NULL);Should these locations be updated to use
IS_ERR()when validating the result ofhashmap__new()?--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 6 lines · Ian Rogers
If
has_supported_countersfails then msg was passed toui__errorregardless of whether an error was written into msg leading to reading uninitialized memory. Avoid this by always terminating msg at initialization.Opportunistically reduce the scope of msg to make its use clearer.
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
Quoted 31 lines
Fixes c9a8c343ef2f ("perf stat: When no events, don't report an error if there is none")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/builtin-stat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)tools/perf/builtin-stat.c +3
-1@@ -777,7 +777,6 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)int interval = stat_config.interval;int times = stat_config.times;int timeout = stat_config.timeout; -char msg[BUFSIZ ];unsigned long long t0, t1;struct evsel *counter;size_t l;@@ -908,6 +907,9 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx) } }if (!has_supported_counters && !stat_config.null_run) { +char msg[BUFSIZ ]; + + msg[0 ] ='\0' ;if (open_err) {evsel__open_strerror (evlist__first (evsel_list), &target, open_err, msg,sizeof (msg));Signature · 1 line
2.55.0.979.g7e5102b832-goog