Skip to contentSkip to conversation

staging: rtl8723bs: fix unnecessary else block with only a break statement

PATCH In review Isaac Aneek Sarker 2 participants 4 messages Sep 9 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: fix unnecessary else block with only a break statement

Warning found by checkpatch.pl : else is not generally useful after a break or return. The function would reach the break statement after if-elseif block even if the else block is not used.

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -2
index 3c82012fdc6c..a203ef8bd6f6 100644
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
 			/* Duplicate entry is found!! Do not insert current entry. */
 			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
 			return false;
-		else
-			break;
+
+		break;
 	}
 
 	/* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */
Signature · 1 line
2.53.0
#1 lore raw
Quoted 14 lines · Isaac Aneek Sarker

Warning found by checkpatch.pl : else is not generally useful after a break or return. The function would reach the break statement after if-elseif block even if the else block is not used.

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index 3c82012fdc6c..a203ef8bd6f6 100644

drivers/staging/rtl8723bs/core/rtw_recv.c static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un · line 1793

Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -2
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
 			/* Duplicate entry is found!! Do not insert current entry. */
 			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
 			return false;
-		else
-			break;
+
+		break;

Did you test this code? It looks like you now just changed the logic a lot, right?

thanks,

greg k-h

#2 lore raw
Quoted 26 lines · On Wed, 9 Sep 2026 11:33:49 +0200 Greg Kroah-Hartman…
Quoted 14 lines · Isaac Aneek Sarker

Warning found by checkpatch.pl : else is not generally useful after a break or return. The function would reach the break statement after if-elseif block even if the else block is not used.

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index 3c82012fdc6c..a203ef8bd6f6 100644

drivers/staging/rtl8723bs/core/rtw_recv.c static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un · line 1793

Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -2
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
 			/* Duplicate entry is found!! Do not insert current entry. */
 			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
 			return false;
-		else
-			break;
+
+		break;

Did you test this code? It looks like you now just changed the logic a lot, right?

Quoted 3 lines

thanks,

greg k-h

No I didn't test the code. And I don't have the required hardware. But I would like to know what are widely used test methods in linux kernel dev to test a driver when you don't have the relevant hardware vs when you have one for and finally test the code. At first it seemed a trivial change to me because that else block would only execute if the if-elseif block didnt execute, which made me come to the decision that the else block was unnecessary.

#3 lore raw
Quoted 29 lines · Isaac Aneek Sarker
Quoted 26 lines · On Wed, 9 Sep 2026 11:33:49 +0200 Greg Kroah-Hartman…
Quoted 14 lines · Isaac Aneek Sarker

Warning found by checkpatch.pl : else is not generally useful after a break or return. The function would reach the break statement after if-elseif block even if the else block is not used.

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index 3c82012fdc6c..a203ef8bd6f6 100644

drivers/staging/rtl8723bs/core/rtw_recv.c static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un · line 1793

Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -2
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
 			/* Duplicate entry is found!! Do not insert current entry. */
 			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
 			return false;
-		else
-			break;
+
+		break;

Did you test this code? It looks like you now just changed the logic a lot, right?

Quoted 5 lines
Quoted 3 lines

thanks,

greg k-h

No I didn't test the code. And I don't have the required hardware. But I would like to know what are widely used test methods in linux kernel dev to test a driver when you don't have the relevant hardware vs when you have one for and finally test the code. At first it seemed a trivial change to me because that else block would only execute if the if-elseif block didnt execute, which made me come to the decision that the else block was unnecessary.

Please wrap your lines :)

Look at the logic of what you just changed here, is it identical to what was present before your change? If not, what is different? checkpatch is for coding style issues, not logic changes, right?

See the mailing list archives for many discussions about this type of "cleanup".

thanks,

greg k-h