FAILED: patch "[PATCH] scsi: qla2xxx: Skip NVMe LS reject IOCB when FW not started" failed to apply to 7.2-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 7.2-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-7.2.y
git checkout FETCH_HEAD
git cherry-pick -x f7e46ebffc5781aab3f1f5a5d4350addbb5833f4
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026090921-shiny-wired-026c@gregkh' --subject-prefix 'PATCH 7.2.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From f7e46ebffc5781aab3f1f5a5d4350addbb5833f4 Mon Sep 17 00:00:00 2001
From: Nilesh Javali <[email protected]>
Date: Thu, 30 Jul 2026 21:28:30 +0530
Subject: [PATCH] scsi: qla2xxx: Skip NVMe LS reject IOCB when FW not started
qla_nvme_xmt_ls_rsp() bails out to the out: label when firmware is not started (!ha->flags.fw_started), but the out: path unconditionally calls qla_nvme_ls_reject_iocb(), which ends in qla2x00_start_iocbs() and an unconditional doorbell write to the request queue in-pointer register. This rings the firmware doorbell and queues an IOCB that stopped or resetting firmware cannot consume, and touches MMIO during the reset/EEH window where fw_started is also clear.
Only emit the LS reject IOCB (and ring the doorbell) when fw_started is set; otherwise just clean up and return. The post-allocation failure cases (SRB alloc / qla2x00_start_sp() failure) run with firmware started and still send the reject. Apply the same guard to the reject emission in qla2xxx_process_purls_pkt().
drivers/scsi/qla2xxx/qla_nvme.c +13 -6
@@ -441,9 +441,11 @@ static int qla_nvme_xmt_ls_rsp(struct nvme_fc_local_port *lport, a.vp_idx = vha->vp_idx; a.nport_handle = uctx->nport_handle; a.xchg_address = uctx->exchange_address; -spin_lock_irqsave (ha->base_qpair->qp_lock_ptr, flags); -qla_nvme_ls_reject_iocb (vha, ha->base_qpair, &a, true); -spin_unlock_irqrestore (ha->base_qpair->qp_lock_ptr, flags); +if (ha->flags.fw_started) { +spin_lock_irqsave (ha->base_qpair->qp_lock_ptr, flags); +qla_nvme_ls_reject_iocb (vha, ha->base_qpair, &a, true); +spin_unlock_irqrestore (ha->base_qpair->qp_lock_ptr, flags); + }kfree (uctx);return rval; }
@@ -1321,9 +1323,14 @@ qla2xxx_process_purls_pkt(struct scsi_qla_host *vha, struct purex_item *item) a.vp_idx = vha->vp_idx; a.nport_handle = uctx->nport_handle; a.xchg_address = uctx->exchange_address; -spin_lock_irqsave (vha->hw->base_qpair->qp_lock_ptr, flags); -qla_nvme_ls_reject_iocb (vha, vha->hw->base_qpair, &a, true); -spin_unlock_irqrestore (vha->hw->base_qpair->qp_lock_ptr, flags); +if (vha->hw->flags.fw_started) { +spin_lock_irqsave (vha->hw->base_qpair->qp_lock_ptr, + flags); +qla_nvme_ls_reject_iocb (vha, vha->hw->base_qpair, &a, + true); +spin_unlock_irqrestore (vha->hw->base_qpair->qp_lock_ptr, + flags); + }list_del (&uctx->elem);kfree (uctx); }