FAILED: patch "[PATCH] scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring" failed to apply to 6.1-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x 626e44f3d8a924a97a3848a9fd45833947e081e9
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026090950-suitor-quake-2aad@gregkh' --subject-prefix 'PATCH 6.1.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 626e44f3d8a924a97a3848a9fd45833947e081e9 Mon Sep 17 00:00:00 2001
From: Nilesh Javali <[email protected]>
Date: Thu, 30 Jul 2026 21:28:16 +0530
Subject: [PATCH] scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring
slot
For QLAFX00 the request ring is ioremapped device I/O memory (ha->iobase + req_que_off), not DMA-coherent RAM, which is why the rest of the FX00 path accesses it through memcpy_toio() and the wrt_reg_* helpers. __qla2x00_alloc_iocbs() however zeroed the producer slot with a plain memset(). On architectures such as ARM64 a regular memset() may emit unaligned or block-zeroing instructions (e.g. DC ZVA) that are invalid on Device memory, leading to a synchronous external abort.
Use memset_io() to clear the slot for QLAFX00, matching the I/O accessors used elsewhere on this ring. Other adapters keep the plain memset() on their DMA-coherent rings. The zero-fill is retained for FX00 because its IOCB builders (e.g. qlafx00_fxdisc_iocb()) copy only part of the entry and rely on the unused tail being pre-zeroed.
drivers/scsi/qla2xxx/qla_iocb.c +3 -1
@@ -2530,11 +2530,13 @@ __qla2x00_alloc_iocbs(struct qla_qpair *qpair, srb_t *sp)*/ req->cnt -= req_cnt; pkt =qla_req_ring_slot (ha, req); -memset (pkt,0 ,qla_req_entry_size (ha));if (IS_QLAFX00 (ha)) { +memset_io ((void __iomem __force *)pkt,0 , +qla_req_entry_size (ha));wrt_reg_byte ((u8 __force __iomem *)&pkt->entry_count, req_cnt);wrt_reg_dword ((__le32 __force __iomem *)&pkt->handle, handle); }else { +memset (pkt,0 ,qla_req_entry_size (ha)); pkt->entry_count = req_cnt; pkt->handle = handle; }
Sasha Levin
maintainerPATCH 1/1 scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring slot
From: Nilesh Javali <[email protected]>
[ Upstream commit 626e44f3d8a924a97a3848a9fd45833947e081e9 ]
For QLAFX00 the request ring is ioremapped device I/O memory (ha->iobase + req_que_off), not DMA-coherent RAM, which is why the rest of the FX00 path accesses it through memcpy_toio() and the wrt_reg_* helpers. __qla2x00_alloc_iocbs() however zeroed the producer slot with a plain memset(). On architectures such as ARM64 a regular memset() may emit unaligned or block-zeroing instructions (e.g. DC ZVA) that are invalid on Device memory, leading to a synchronous external abort.
Use memset_io() to clear the slot for QLAFX00, matching the I/O accessors used elsewhere on this ring. Other adapters keep the plain memset() on their DMA-coherent rings. The zero-fill is retained for FX00 because its IOCB builders (e.g. qlafx00_fxdisc_iocb()) copy only part of the entry and rely on the unused tail being pre-zeroed.
--- drivers/scsi/qla2xxx/qla_iocb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_iocb.c +3 -1
@@ -2347,11 +2347,13 @@ __qla2x00_alloc_iocbs(struct qla_qpair *qpair, srb_t *sp)/* Prep packet */ req->cnt -= req_cnt; pkt = req->ring_ptr; -memset (pkt,0 ,REQUEST_ENTRY_SIZE );if (IS_QLAFX00 (ha)) { +memset_io ((void __iomem __force *)pkt,0 , +REQUEST_ENTRY_SIZE );wrt_reg_byte ((u8 __force __iomem *)&pkt->entry_count, req_cnt);wrt_reg_dword ((__le32 __force __iomem *)&pkt->handle, handle); }else { +memset (pkt,0 ,REQUEST_ENTRY_SIZE ); pkt->entry_count = req_cnt; pkt->handle = handle; }
Signature · 1 line
2.53.0