staging: rtl8723bs: avoid CamelCase in odm_DynamicBBPowerSaving.c
PATCH 1/1 staging: rtl8723bs: avoid CamelCase in odm_DynamicBBPowerSaving.c
Rename odm_DynamicBBPowerSavingInit to odm_dynamic_bb_power_saving_init, and rename local variables and struct ps_t fields (PreCCAState, CurCCAState, PreRFState, CurRFState, Rssi_val_min, Reg874, RegC70, Reg85C, RegA74, bForceInNormal, Rssi_Up_bound, Rssi_Low_bound) to avoid CamelCase, which is not accepted by checkpatch.pl.
--- drivers/staging/rtl8723bs/hal/odm.c | 2 +- .../rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 72 +++++++++---------- .../rtl8723bs/hal/odm_DynamicBBPowerSaving.h | 16 ++--- 3 files changed, 45 insertions(+), 45 deletions(-)
drivers/staging/rtl8723bs/hal/odm.c +1 -1
@@ -580,7 +580,7 @@ void ODM_DMInit(struct dm_odm_t *pDM_Odm)ODM_ClearTxPowerTrackingState (pDM_Odm); -odm_DynamicBBPowerSavingInit (pDM_Odm); +odm_dynamic_bb_power_saving_init (pDM_Odm);odm_DynamicTxPowerInit (pDM_Odm);odm_SwAntDetectInit (pDM_Odm);
drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c +36 -36
117 lines not on this page · raw message
drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h +8 -8
@@ -9,23 +9,23 @@#define __ODMDYNAMICBBPOWERSAVING_H__struct ps_t {/* _Dynamic_Power_Saving_ */ -u8 PreCCAState; -u8 CurCCAState; +u8 pre_cca_state; +u8 cur_cca_state; -u8 PreRFState; -u8 CurRFState; +u8 pre_rf_state; +u8 cur_rf_state; -int Rssi_val_min; +int rssi_val_min;u8 initialize; -u32 Reg874, RegC70, Reg85C, RegA74; +u32 reg874, regc70, reg85c, rega74; };#define dm_RF_Saving ODM_RF_Saving -void ODM_RF_Saving (void *pDM_VOID,u8 bForceInNormal); +void ODM_RF_Saving (void *pDM_VOID,u8 force_in_normal); -void odm_DynamicBBPowerSavingInit (void *pDM_VOID); +void odm_dynamic_bb_power_saving_init (void *pDM_VOID);#endif
Signature · 1 line
2.43.0
Greg KH
maintainerQuoted 6 lines · Enzo Frese
Rename
odm_DynamicBBPowerSavingInittoodm_dynamic_bb_power_saving_init, and rename local variables and structps_tfields (PreCCAState, CurCCAState, PreRFState, CurRFState,Rssi_val_min, Reg874, RegC70, Reg85C, RegA74, bForceInNormal,Rssi_Up_bound,Rssi_Low_bound) to avoid CamelCase, which is not accepted by checkpatch.pl.
Quoted 7 lines
Signed-off-by Enzo Frese <[email protected]>--- drivers/staging/rtl8723bs/hal/odm.c | 2 +- .../rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 72 +++++++++---------- .../rtl8723bs/hal/odm_DynamicBBPowerSaving.h | 16 ++--- 3 files changed, 45 insertions(+), 45 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot