Skip to contentSkip to conversation

fs/proc/task_mmu.c:205:13: warning: 'reacquire_rcu' defined but not used

PATCH kernel test robot 2 participants 3 messages Sep 12 – Sep 14 Memory management

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   383fc05d4650b021f3c17e36a145106dcc61a294
commit: 2a61a4b80dc01581dc9f6935eedefbd596e77409 [439/459] proc/task_mmu: remove unnecessary inlines in function definitions
config: openrisc-randconfig-r053-20260912 (https://download.01.org/0day-ci/archive/20260912/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260912/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> fs/proc/task_mmu.c:205:13: warning: 'reacquire_rcu' defined but not used [-Wunused-function]
     205 | static void reacquire_rcu(struct proc_maps_private *priv)
         |             ^~~~~~~~~~~~~
>> fs/proc/task_mmu.c:197:13: warning: 'drop_rcu' defined but not used [-Wunused-function]

197 | static void drop_rcu(struct proc_maps_private *priv)
| ^~~~~~~~
fs/proc/task_mmu.c:133:12: warning: 'lock_ctx_mm' defined but not used [-Wunused-function]
133 | static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
| ^~~~~~~~~~~

vim +/reacquire_rcu +205 fs/proc/task_mmu.c

196

 > 197	static void drop_rcu(struct proc_maps_private *priv)
   198	{
   199		if (priv->lock_ctx.mmap_locked)
   200			return;
   201	
   202		rcu_read_unlock();
   203	}
   204	
 > 205	static void reacquire_rcu(struct proc_maps_private *priv)

206 {
207 if (priv->lock_ctx.mmap_locked)
208 return;
209
210 rcu_read_lock();
211 /* Reinitialize the iterator. */
212 vma_iter_set(&priv->iter, priv->lock_ctx.locked_vma->vm_end);
213 }
214

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

#1 lore raw
Quoted 19 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   383fc05d4650b021f3c17e36a145106dcc61a294
commit: 2a61a4b80dc01581dc9f6935eedefbd596e77409 [439/459] proc/task_mmu: remove unnecessary inlines in function definitions
config: openrisc-randconfig-r053-20260912 (https://download.01.org/0day-ci/archive/20260912/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260912/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

fs/proc/task_mmu.c:205:13: warning: 'reacquire_rcu' defined but not used [-Wunused-function]

205 | static void reacquire_rcu(struct proc_maps_private *priv)
| ^~~~~~~~~~~~~

Quoted 1 line
Quoted 1 line

fs/proc/task_mmu.c:197:13: warning: 'drop_rcu' defined but not used [-Wunused-function]

Quoted 8 lines

197 | static void drop_rcu(struct proc_maps_private *priv)
| ^~~~~~~~
fs/proc/task_mmu.c:133:12: warning: 'lock_ctx_mm' defined but not used [-Wunused-function]
133 | static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
| ^~~~~~~~~~~

vim +/reacquire_rcu +205 fs/proc/task_mmu.c

Looks like these functions are not used when CONFIG_PROC_PAGE_MONITOR=n. I'll post a fixup today.

Quoted 24 lines
   196
Quoted 1 line

197 static void drop_rcu(struct proc_maps_private *priv)

   198  {
   199          if (priv->lock_ctx.mmap_locked)
   200                  return;
   201
   202          rcu_read_unlock();
   203  }
   204
Quoted 1 line

205 static void reacquire_rcu(struct proc_maps_private *priv)

   206  {
   207          if (priv->lock_ctx.mmap_locked)
   208                  return;
   209
   210          rcu_read_lock();
   211          /* Reinitialize the iterator. */
   212          vma_iter_set(&priv->iter, priv->lock_ctx.locked_vma->vm_end);
   213  }
   214

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

#2 lore raw
In reply to kernel test robot
Quoted 16 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   383fc05d4650b021f3c17e36a145106dcc61a294
commit: 2a61a4b80dc01581dc9f6935eedefbd596e77409 [439/459] proc/task_mmu: remove unnecessary inlines in function definitions
config: openrisc-randconfig-r053-20260912 (https://download.01.org/0day-ci/archive/20260912/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260912/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

fs/proc/task_mmu.c:205:13: warning: 'reacquire_rcu' defined but not used [-Wunused-function]

Quoted 9 lines

205 | static void reacquire_rcu(struct proc_maps_private *priv)
| ^~~~~~~~~~~~~

Quoted 1 line
Quoted 1 line

fs/proc/task_mmu.c:197:13: warning: 'drop_rcu' defined but not used [-Wunused-function]

197 | static void drop_rcu(struct proc_maps_private *priv)
| ^~~~~~~~
fs/proc/task_mmu.c:133:12: warning: 'lock_ctx_mm' defined but not used [-Wunused-function]
133 | static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
| ^~~~~~~~~~~

Fixup is posted at
https://lore.kernel.org/all/[email protected]/

Quoted 26 lines

vim +/reacquire_rcu +205 fs/proc/task_mmu.c

   196
Quoted 1 line

197 static void drop_rcu(struct proc_maps_private *priv)

   198  {
   199          if (priv->lock_ctx.mmap_locked)
   200                  return;
   201
   202          rcu_read_unlock();
   203  }
   204
Quoted 1 line

205 static void reacquire_rcu(struct proc_maps_private *priv)

   206  {
   207          if (priv->lock_ctx.mmap_locked)
   208                  return;
   209
   210          rcu_read_lock();
   211          /* Reinitialize the iterator. */
   212          vma_iter_set(&priv->iter, priv->lock_ctx.locked_vma->vm_end);
   213  }
   214

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki