of: module: harden a call to request_module
PATCH 1/1 of: module: harden a call to request_module
In of_request_module(), the string 'str' is built from Device Tree data and passed directly to request_module() as a format string. While the Device Tree is generally considered trusted, using externally provided data as a format string is fragile and can lead to unintended format specifier interpretation.
Fix this by using request_module("%s", str) to treat 'str' as a plain string argument, not a format string.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- drivers/of/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/module.c +1 -1
@@ -73,7 +73,7 @@ int of_request_module(const struct device_node *np)of_modalias (np, str, size); str[size -1 ] ='\0' ; - ret =request_module (str); + ret =request_module ("%s" , str);kfree (str);return ret;
Signature · 1 line
2.53.0
Rob Herring
maintainerQuoted 8 lines · Dmitriy Okunev
In
of_request_module(), the string 'str' is built from Device Tree data and passed directly torequest_module()as a format string. While the Device Tree is generally considered trusted, using externally provided data as a format string is fragile and can lead to unintended format specifier interpretation.Fix this by using
request_module("%s", str)to treat 'str' as a plain string argument, not a format string.
'%' is not a legal character in DT node names. Even if someone modified a DT to have one, would we even get to this point. Probably unflattening or creating sysfs files would fail first.
Rob