Skip to contentSkip to conversation

mm/damon: fix typos in comments

PATCH In review Adrian Huang (Lenovo) 5 participants 6 messages Sep 15 – Oct 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/damon: fix typos in comments

Correct spelling mistakes. No functional changes.

---
 mm/damon/core.c     | 6 +++---
 mm/damon/lru_sort.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
mm/damon/core.c +3 -3
index 0c98f7e267d0..981a153619c0 100644
@@ -2447,7 +2447,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
  * This function checks if a given region should be skipped or not for the
  * reason.  If only the starting part of the region has previously charged,
  * this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true.  The
+ * area that not charged in the previous charge window, and return true.  The
  * caller can see the second one on the next iteration of the region walk.
  * Note that this means the caller should use damon_for_each_region() instead
  * of damon_for_each_region_safe().  If damon_for_each_region_safe() is used,
@@ -2613,7 +2613,7 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t,
  * This function is called when kdamond finished applying the action of a DAMOS
  * scheme to all regions that eligible for the given &damos->apply_interval_us.
  * If every scheme of @ctx including @s now finished walking for at least one
- * &damos->apply_interval_us, this function makrs the handling of the given
+ * &damos->apply_interval_us, this function marks the handling of the given
  * DAMOS walk request is done, so that damos_walk() can wake up and return.
  */
 static void damos_walk_complete(struct damon_ctx *ctx, struct damos *s)
@@ -4143,7 +4143,7 @@ static bool damon_find_system_rams_range(unsigned long *start,
  * This function sets the region of @t as requested by @start and @end.  If the
  * values of @start and @end are zero, however, this function finds 'System
  * RAM' resources and sets the region to cover all the resource.  In the latter
- * case, this function saves the start and the end addresseses of the first and
+ * case, this function saves the start and the end addresses of the first and
  * the last resources in @start and @end, respectively.
  *
  * Return: 0 on success, negative error code otherwise.
mm/damon/lru_sort.c +1 -1
index ad8e86dd3a93..273efa3c913e 100644
@@ -260,7 +260,7 @@ static int damon_lru_sort_add_filters(struct damos *hot_scheme,
 		return -ENOMEM;
 	damos_add_filter(hot_scheme, filter);
 
-	/* disabllow de-prioritizing young pages */
+	/* disallow de-prioritizing young pages */
 	filter = damos_new_filter(DAMOS_FILTER_TYPE_YOUNG, true, false);
 	if (!filter)
 		return -ENOMEM;
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Adrian Huang (Lenovo)
Quoted 44 lines · Adrian Huang (Lenovo)

Correct spelling mistakes. No functional changes.

---
 mm/damon/core.c     | 6 +++---
 mm/damon/lru_sort.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
mm/damon/core.c +3 -3
index 0c98f7e267d0..981a153619c0 100644
@@ -2447,7 +2447,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
  * This function checks if a given region should be skipped or not for the
  * reason.  If only the starting part of the region has previously charged,
  * this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true.  The
+ * area that not charged in the previous charge window, and return true.  The
  * caller can see the second one on the next iteration of the region walk.
  * Note that this means the caller should use damon_for_each_region() instead
  * of damon_for_each_region_safe().  If damon_for_each_region_safe() is used,
@@ -2613,7 +2613,7 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t,
  * This function is called when kdamond finished applying the action of a DAMOS
  * scheme to all regions that eligible for the given &damos->apply_interval_us.
  * If every scheme of @ctx including @s now finished walking for at least one
- * &damos->apply_interval_us, this function makrs the handling of the given
+ * &damos->apply_interval_us, this function marks the handling of the given
  * DAMOS walk request is done, so that damos_walk() can wake up and return.
  */
 static void damos_walk_complete(struct damon_ctx *ctx, struct damos *s)
@@ -4143,7 +4143,7 @@ static bool damon_find_system_rams_range(unsigned long *start,
  * This function sets the region of @t as requested by @start and @end.  If the
  * values of @start and @end are zero, however, this function finds 'System
  * RAM' resources and sets the region to cover all the resource.  In the latter
- * case, this function saves the start and the end addresseses of the first and
+ * case, this function saves the start and the end addresses of the first and
  * the last resources in @start and @end, respectively.
  *
  * Return: 0 on success, negative error code otherwise.
mm/damon/lru_sort.c +0 -0
index ad8e86dd3a93..273efa3c913e 100644

mm/damon/lru_sort.c static int damon_lru_sort_add_filters(struct damos *hot_scheme, · line 266

Quoted 8 lines
mm/damon/lru_sort.c +1 -1
@@ -260,7 +260,7 @@ static int damon_lru_sort_add_filters(struct damos *hot_scheme,
 		return -ENOMEM;
 	damos_add_filter(hot_scheme, filter);
 
-	/* disabllow de-prioritizing young pages */
+	/* disallow de-prioritizing young pages */
 	filter = damos_new_filter(DAMOS_FILTER_TYPE_YOUNG, true, false);
 	if (!filter)
 		return -ENOMEM;

Thanks,
Zenghui

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Adrian Huang (Lenovo)
Quoted 1 line · On Tue, 15 Sep 2026 18:27:46 +0800 "Adrian Huang (Lenovo)"…

Correct spelling mistakes. No functional changes.

Thank you for fixing those, Adrian!

Quoted 2 lines

This patch is applied to damon/next [1] tree. If this patch is not added to mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton) to pick this. So, no action from your side is needed for now. If it seems I also forgot doing that or you cannot wait for my action, please feel free to directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees

Thanks,
SJ

[...]

#4 lore raw
In reply to Adrian Huang (Lenovo)

Hi Adrian,

Quoted 6 lines · Adrian Huang (Lenovo)

Correct spelling mistakes. No functional changes.

---
 mm/damon/core.c     | 6 +++---
 mm/damon/lru_sort.c | 2 +-

could you add this changes in this file?

DAMON_RCLAIM -> DAMON_RECLAIM
'set as' -> 'set to'

mm/damon/core.c static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r, · line 2450

Quoted 12 lines
 2 files changed, 4 insertions(+), 4 deletions(-)
mm/damon/core.c +1 -1
index 0c98f7e267d0..981a153619c0 100644
@@ -2447,7 +2447,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
   * This function checks if a given region should be skipped or not for the
   * reason.  If only the starting part of the region has previously charged,
   * this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true.  The
+ * area that not charged in the previous charge window, and return true.  The

Please make it 'area that is not charged'

Thanks
Manuel

maintainer
#5 lore raw

Hi Manuel,

Quoted 17 lines · On Tue, 06 Oct 2026 10:38:38 +0200 Manuel Ebner <[email protected]> wrote:

Hi Adrian,

Quoted 6 lines · Adrian Huang (Lenovo)

Correct spelling mistakes. No functional changes.

---
 mm/damon/core.c     | 6 +++---
 mm/damon/lru_sort.c | 2 +-

could you add this changes in this file?

DAMON_RCLAIM -> DAMON_RECLAIM
'set as' -> 'set to'

Quoted 2 lines
 2 files changed, 4 insertions(+), 4 deletions(-)
Quoted 12 lines

mm/damon/core.c static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r, · line 2450

Quoted 10 lines
mm/damon/core.c +1 -1
index 0c98f7e267d0..981a153619c0 100644
@@ -2447,7 +2447,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
   * This function checks if a given region should be skipped or not for the
   * reason.  If only the starting part of the region has previously charged,
   * this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true.  The
+ * area that not charged in the previous charge window, and return true.  The

Please make it 'area that is not charged'

Would you mind posting those as another patch?

Thanks,
SJ

[...]