Skip to contentSkip to conversation

uevent0[123]: make check fixes

PATCH In review Avinesh Kumar via ltp 3 participants 3 messages Sep 15 – Sep 16

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uevent0[123]: make check fixes

From: Avinesh Kumar <[email protected]>

- use tabs
- use "(foo *)" instead of "(foo*)"
- remove multiple blank lines

---
 testcases/kernel/uevents/uevent01.c | 4 ++--
 testcases/kernel/uevents/uevent02.c | 2 +-
 testcases/kernel/uevents/uevent03.c | 1 -
 3 files changed, 3 insertions(+), 4 deletions(-)
testcases/kernel/uevents/uevent01.c +2 -2
index f5fe099d8ed0..28143a4b93e5 100644
@@ -57,10 +57,10 @@ static void verify_uevent(void)
 		tst_brk(TBROK, "Failed to find free loop device");
 
 	snprintf(ev_msg, sizeof(ev_msg),
-	         "change@/devices/virtual/block/loop%i", dev_num);
+		"change@/devices/virtual/block/loop%i", dev_num);
 
 	snprintf(ev_dev_path, sizeof(ev_dev_path),
-	         "DEVPATH=/devices/virtual/block/loop%i", dev_num);
+		"DEVPATH=/devices/virtual/block/loop%i", dev_num);
 
 	snprintf(ev_dev_minor, sizeof(ev_dev_minor), "MINOR=%i", dev_num);
 	snprintf(ev_dev_name, sizeof(ev_dev_name), "DEVNAME=loop%i", dev_num);
testcases/kernel/uevents/uevent02.c +1 -1
index f3d2ebc87a74..fd526ddb1c5a 100644
@@ -102,7 +102,7 @@ static void generate_tun_uevents(void)
 		.ifr_name = "ltp-tun0",
 	};
 
-	SAFE_IOCTL(fd, TUNSETIFF, (void*)&ifr);
+	SAFE_IOCTL(fd, TUNSETIFF, (void *)&ifr);
 
 	SAFE_IOCTL(fd, TUNSETPERSIST, 0);
 
testcases/kernel/uevents/uevent03.c +0 -1
index 42d629a4ae8e..8c8a464af5f6 100644
@@ -209,7 +209,6 @@ static void verify_uevent(void)
 	snprintf(dev_name1, sizeof(dev_name1),
 		"DEVNAME=input/%s", handler1);
 
-
 	snprintf(add_msg_event2, sizeof(add_msg_event2),
 		"add@%s/%s", sysname, handler2);
 
Signature · 5 lines
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Avinesh,

Quoted 1 line · Avinesh Kumar

uevent0[123]: make check fixes

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp