gpio: mvebu: use raw spinlock for MMIO regmaps
Subsystems (2)
PATCH 1/1 gpio: mvebu: use raw spinlock for MMIO regmaps
The mask/unmask handlers run with the generic irqchip's raw spinlock held and call regmap_read()/regmap_write() on the GPIO regmaps. By default regmap protects itself with a plain spinlock, which becomes a sleeping rt_mutex on CONFIG_PREEMPT_RT; taking it while holding the raw irqchip lock trips might_sleep(), and PROVE_RAW_LOCK_NESTING flags the same nesting on non-RT builds.
Configure both GPIO regmaps with .use_raw_spinlock = true so the MMIO accesses stay atomic in hardirq and raw-locked context.
--- drivers/gpio/gpio-mvebu.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpio/gpio-mvebu.c +8 -0
@@ -598,11 +598,18 @@ static void mvebu_gpio_irq_handler(struct irq_desc *desc)chained_irq_exit (chip, desc); } +/* +* These regmaps are accessed from the mask/unmask handlers while the +* irqchip's raw spinlock is held, so they must use a raw spinlock +* internally. A plain spinlock becomes a sleeping rt_mutex on +* CONFIG_PREEMPT_RT and would trip might_sleep() from that context. +*/ static const struct regmap_config mvebu_gpio_regmap_config = { .name ="gpio" , .reg_bits =32 , .reg_stride =4 , .val_bits =32 , + .use_raw_spinlock = true, };static const struct regmap_config mvebu_gpio_percpu_regmap_config = {
@@ -610,6 +617,7 @@ static const struct regmap_config mvebu_gpio_percpu_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, + .use_raw_spinlock = true, };static const struct regmap_config mvebu_pwm_regmap_config = {
Signature · 1 line
2.55.0
Quoted 4 lines · Rosen Penev
The mask/unmask handlers run with the generic irqchip's raw spinlock held and call regmap_read()/regmap_write() on the GPIO regmaps. By default regmap protects itself with a plain spinlock, which becomes a sleeping
rt_mutexonCONFIG_PREEMPT_RT; taking it while holding the raw
sleeping lock
Quoted 9 lines
irqchip lock trips
might_sleep(), andPROVE_RAW_LOCK_NESTINGflags the same nesting on non-RT builds.Configure both GPIO regmaps with .use_raw_spinlock = true so the MMIO accesses stay atomic in hardirq and raw-locked context.
Assisted-by LLMSigned-off-by Rosen Penev <[email protected]>---
other than the comments,
Quoted 8 lines
drivers/gpio/gpio-mvebu.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpio/gpio-mvebu.c +0
-0
drivers/gpio/gpio-mvebu.c static void mvebu_gpio_irq_handler(struct irq_desc *desc) · line 606
Quoted 9 lines
drivers/gpio/gpio-mvebu.c +6
-0@@ -598,11 +598,18 @@ static void mvebu_gpio_irq_handler(struct irq_desc *desc)chained_irq_exit (chip, desc); } +/* +* These regmaps are accessed from the mask/unmask handlers while the +* irqchip's raw spinlock is held, so they must use a raw spinlock +* internally. A plain spinlock becomes a sleeping rt_mutex on +* CONFIG_PREEMPT_RT and would trip might_sleep() from that context. +*/
IRQ delivery path must hold raw_spinlock_t. This is not special to this driver but must be done in every gpio chip. I wouldn't add this comment.
Quoted 19 lines
drivers/gpio/gpio-mvebu.c +2
-0static const struct regmap_config mvebu_gpio_regmap_config = { .name ="gpio" , .reg_bits =32 , .reg_stride =4 , .val_bits =32 , + .use_raw_spinlock = true, };static const struct regmap_config mvebu_gpio_percpu_regmap_config = {@@ -610,6 +617,7 @@ static const struct regmap_config mvebu_gpio_percpu_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, + .use_raw_spinlock = true, };static const struct regmap_config mvebu_pwm_regmap_config = {Signature · 1 line
2.55.0
Sebastian