mfd: intel-lpss: Clean up and modernize DebugFS usage
v6 cover mfd: intel-lpss: Clean up and modernize DebugFS usage
This series cleans up DebugFS code, modernizes it by replacing obsoleted macros and removes redundant error checking.
---
Changes in v6:
- Split each logical change into an individual patch.
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- Changed the goal of the patch to DebugFS modernization.
- Refactored intel_lpss_debugfs_add() into a void function.
- Removed deprecated macros and functions.
- Removed dmesg message completely.
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Keep the dmesg messages, instead check whether DebugFS is initialized
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Fixed commit name and description.
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Fixed function name in comment section.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Maria Lisina (4):
mfd: intel-lpss: Remove redundant DebugFS error check
mfd: intel-lpss: Use plain octal values for file permissions
mfd: intel-lpss: Remove extra DebugFS dentry
mfd: intel-lpss: Switch to debugfs_remove()
drivers/mfd/intel-lpss.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)
---
base-commit: 2f0c1cf72f4682178506f513bbf015e591b1aa4a
change-id: 20260913-intel-lpss-debugfs-eff3580d1295
Best regards,
Signature · 1 line
Maria Lisina <[email protected]>
PATCH v6 1/4 mfd: intel-lpss: Remove redundant DebugFS error check
The DebugFS API is designed to handle errors gracefully. Any explicit checking on return values is considered an anti-pattern.
This patch removes unnecessary error checking and converts intel_lpss_debugfs_add() into a void function.
--- drivers/mfd/intel-lpss.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/mfd/intel-lpss.c +2 -8
@@ -142,13 +142,11 @@ static void intel_lpss_cache_ltr(struct intel_lpss *lpss) lpss->idle_ltr =readl (lpss->priv +LPSS_PRIV_IDLELTR ); } -static int intel_lpss_debugfs_add (struct intel_lpss *lpss) +static void intel_lpss_debugfs_add (struct intel_lpss *lpss) {struct dentry *dir; dir =debugfs_create_dir (dev_name (lpss->dev), intel_lpss_debugfs); -if (IS_ERR (dir)) -return PTR_ERR (dir);/* Cache the values into lpss structure */ intel_lpss_cache_ltr (lpss);
@@ -158,7 +156,6 @@ static int intel_lpss_debugfs_add(struct intel_lpss *lpss)debugfs_create_x32 ("idle_ltr" ,S_IRUGO , dir, &lpss->idle_ltr); lpss->debugfs = dir; -return 0 ; }static void intel_lpss_debugfs_remove (struct intel_lpss *lpss)
@@ -432,10 +429,7 @@ int intel_lpss_probe(struct device *dev, goto err_clk_register;intel_lpss_ltr_expose (lpss); - - ret =intel_lpss_debugfs_add (lpss); -if (ret) -dev_warn (dev,"Failed to create debugfs entries\n" ); +intel_lpss_debugfs_add (lpss);if (intel_lpss_has_idma (lpss)) { ret = mfd_add_devices(dev, lpss->devid, &intel_lpss_idma64_cell,
Signature · 1 line
2.47.3
PATCH v6 2/4 mfd: intel-lpss: Use plain octal values for file permissions
In reply to Maria LisinaS_IRUGO macro is obsoleted and not recommended to use, therefore replace it with plain octal values.
--- drivers/mfd/intel-lpss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mfd/intel-lpss.c +3 -3
@@ -151,9 +151,9 @@ static void intel_lpss_debugfs_add(struct intel_lpss *lpss)/* Cache the values into lpss structure */ intel_lpss_cache_ltr (lpss); -debugfs_create_x32 ("capabilities" ,S_IRUGO , dir, &lpss->caps); -debugfs_create_x32 ("active_ltr" ,S_IRUGO , dir, &lpss->active_ltr); -debugfs_create_x32 ("idle_ltr" ,S_IRUGO , dir, &lpss->idle_ltr); +debugfs_create_x32 ("capabilities" ,0444 , dir, &lpss->caps); +debugfs_create_x32 ("active_ltr" ,0444 , dir, &lpss->active_ltr); +debugfs_create_x32 ("idle_ltr" ,0444 , dir, &lpss->idle_ltr); lpss->debugfs = dir; }
Signature · 1 line
2.47.3
PATCH v6 3/4 mfd: intel-lpss: Remove extra DebugFS dentry
In reply to Maria LisinaThere is no point to keep the variable dir just to assing lpss->debugfs to it later, just use lpss->debugfs directly.
--- drivers/mfd/intel-lpss.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/mfd/intel-lpss.c +8 -8
@@ -144,18 +144,18 @@ static void intel_lpss_cache_ltr(struct intel_lpss *lpss)static void intel_lpss_debugfs_add (struct intel_lpss *lpss) { -struct dentry *dir; - - dir =debugfs_create_dir (dev_name (lpss->dev), intel_lpss_debugfs); + lpss->debugfs =debugfs_create_dir (dev_name (lpss->dev), + intel_lpss_debugfs);/* Cache the values into lpss structure */ intel_lpss_cache_ltr (lpss); -debugfs_create_x32 ("capabilities" ,0444 , dir, &lpss->caps); -debugfs_create_x32 ("active_ltr" ,0444 , dir, &lpss->active_ltr); -debugfs_create_x32 ("idle_ltr" ,0444 , dir, &lpss->idle_ltr); - - lpss->debugfs = dir; +debugfs_create_x32 ("capabilities" ,0444 , + lpss->debugfs, &lpss->caps); +debugfs_create_x32 ("active_ltr" ,0444 , + lpss->debugfs, &lpss->active_ltr); +debugfs_create_x32 ("idle_ltr" ,0444 , + lpss->debugfs, &lpss->idle_ltr); }static void intel_lpss_debugfs_remove (struct intel_lpss *lpss)
Signature · 1 line
2.47.3
PATCH v6 4/4 mfd: intel-lpss: Switch to debugfs_remove()
In reply to Maria Lisinadebugfs_remove_recursive() is deprecated and has become a macro for debugfs_remove(), replace it with the direct debugfs_remove() call instead.
--- drivers/mfd/intel-lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/intel-lpss.c +1 -1
@@ -160,7 +160,7 @@ static void intel_lpss_debugfs_add(struct intel_lpss *lpss)static void intel_lpss_debugfs_remove (struct intel_lpss *lpss) { -debugfs_remove_recursive (lpss->debugfs); +debugfs_remove (lpss->debugfs); }static void intel_lpss_ltr_set (struct device *dev,s32 val)
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v6 4/4] mfd: intel-lpss: Switch to debugfs_remove()
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines
debugfs_remove_recursive()is deprecated and has become a macro fordebugfs_remove(), replace it with the directdebugfs_remove()call instead.Signed-off-by Maria Lisina <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
[email protected]
AI reviewRe: [PATCH v6 2/4] mfd: intel-lpss: Use plain octal values for file permissions
In reply to Maria LisinaSashiko has reviewed this patch and found no issues. It looks great!
Quoted 4 lines
S_IRUGOmacro is obsoleted and not recommended to use, therefore replace it with plain octal values.Signed-off-by Maria Lisina <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
[email protected]
AI reviewRe: [PATCH v6 1/4] mfd: intel-lpss: Remove redundant DebugFS error check
In reply to Maria LisinaSashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
The DebugFS API is designed to handle errors gracefully. Any explicit checking on return values is considered an anti-pattern.
This patch removes unnecessary error checking and converts
intel_lpss_debugfs_add()into a void function.Signed-off-by Maria Lisina <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
[email protected]
AI reviewRe: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
In reply to Maria LisinaSashiko has reviewed this patch and found no issues. It looks great!
Quoted 4 lines
There is no point to keep the variable dir just to assing
lpss->debugfsto it later, just uselpss->debugfsdirectly.Signed-off-by Maria Lisina <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Andy Shevchenko
reviewerRe: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
In reply to Maria LisinaQuoted 2 lines · Maria Lisina
There is no point to keep the variable dir just to assing
lpss->debugfsto it later, just uselpss->debugfsdirectly.
...
drivers/mfd/intel-lpss.c static void intel_lpss_cache_ltr(struct intel_lpss *lpss) · line 148
Quoted 7 lines
static void
intel_lpss_debugfs_add(struct intel_lpss *lpss){drivers/mfd/intel-lpss.c +2
-3-struct dentry *dir; - - dir =debugfs_create_dir (dev_name (lpss->dev), intel_lpss_debugfs); + lpss->debugfs =debugfs_create_dir (dev_name (lpss->dev), + intel_lpss_debugfs);
As Lee pointed out, we are fine with 100 limit, so one line here and below.
Quoted 15 lines
drivers/mfd/intel-lpss.c +6
-5/* Cache the values into lpss structure */ intel_lpss_cache_ltr (lpss); -debugfs_create_x32 ("capabilities" ,0444 , dir, &lpss->caps); -debugfs_create_x32 ("active_ltr" ,0444 , dir, &lpss->active_ltr); -debugfs_create_x32 ("idle_ltr" ,0444 , dir, &lpss->idle_ltr); - - lpss->debugfs = dir; +debugfs_create_x32 ("capabilities" ,0444 , + lpss->debugfs, &lpss->caps); +debugfs_create_x32 ("active_ltr" ,0444 , + lpss->debugfs, &lpss->active_ltr); +debugfs_create_x32 ("idle_ltr" ,0444 , + lpss->debugfs, &lpss->idle_ltr); }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 1/4] mfd: intel-lpss: Remove redundant DebugFS error check
In reply to Maria LisinaQuoted 5 lines · Maria Lisina
The DebugFS API is designed to handle errors gracefully. Any explicit checking on return values is considered an anti-pattern.
This patch removes unnecessary error checking and converts
intel_lpss_debugfs_add()into a void function.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 2/4] mfd: intel-lpss: Use plain octal values for file permissions
In reply to Maria LisinaQuoted 2 lines · Maria Lisina
S_IRUGOmacro is obsoleted and not recommended to use, therefore replace it with plain octal values.
Yep, octal permissions much easier to get without looking aside!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
In reply to Andy ShevchenkoQuoted 1 line · Andy Shevchenko
On Wed, Sep 16, 2026 at 07:36:41PM +0500, Maria Lisina wrote:
...
Quoted 9 lines
drivers/mfd/intel-lpss.c static void intel_lpss_cache_ltr(struct intel_lpss *lpss) · line 148
Quoted 7 lines
static void
intel_lpss_debugfs_add(struct intel_lpss *lpss){drivers/mfd/intel-lpss.c +2
-3-struct dentry *dir; - - dir =debugfs_create_dir (dev_name (lpss->dev), intel_lpss_debugfs); + lpss->debugfs =debugfs_create_dir (dev_name (lpss->dev), + intel_lpss_debugfs);As Lee pointed out, we are fine with 100 limit, so one line here and below.
After addressing this feel free to add
Quoted 15 lines
Quoted 15 lines
drivers/mfd/intel-lpss.c +6
-5/* Cache the values into lpss structure */ intel_lpss_cache_ltr (lpss); -debugfs_create_x32 ("capabilities" ,0444 , dir, &lpss->caps); -debugfs_create_x32 ("active_ltr" ,0444 , dir, &lpss->active_ltr); -debugfs_create_x32 ("idle_ltr" ,0444 , dir, &lpss->idle_ltr); - - lpss->debugfs = dir; +debugfs_create_x32 ("capabilities" ,0444 , + lpss->debugfs, &lpss->caps); +debugfs_create_x32 ("active_ltr" ,0444 , + lpss->debugfs, &lpss->active_ltr); +debugfs_create_x32 ("idle_ltr" ,0444 , + lpss->debugfs, &lpss->idle_ltr); }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 4/4] mfd: intel-lpss: Switch to debugfs_remove()
In reply to Maria LisinaQuoted 2 lines · Maria Lisina
debugfs_remove_recursive()is deprecated and has become a macro fordebugfs_remove(), replace it with the direct
a macro for --> an alias to
Quoted 1 line
debugfs_remove()call instead.
With the above amendment,
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
In reply to Andy ShevchenkoQuoted 1 line
As Lee pointed out, we are fine with 100 limit, so one line here and below.
But doesn't the guideline strictly say no more than 80?
Andy Shevchenko
reviewerRe: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
Quoted 3 lines · Maria Lisina
Quoted 1 line
As Lee pointed out, we are fine with 100 limit, so one line here and below.
But doesn't the guideline strictly say no more than 80?
Yes it says, some maintainers used relaxed version (which is default in checkpatch and now it's 100). Lee is the maintainer of the MFD subsystem and it's clear he leans towards using 100 limit.
Signature · 2 lines
With Best Regards, Andy Shevchenko