Skip to contentSkip to conversation

FAILED: patch "[PATCH] Revert "drm/amdgpu: debugfs: avoid extra EOLs in" failed to apply to 7.2-stable tree

PATCH New [email protected] 2 participants 3 messages Sep 16

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 7.2-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-7.2.y
git checkout FETCH_HEAD
git cherry-pick -x 829157e762ed043e28ecb2e9f3c7d22b54e5989e
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026091651-justifier-ramrod-f274@gregkh' --subject-prefix 'PATCH 7.2.y' 'HEAD^..'

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 829157e762ed043e28ecb2e9f3c7d22b54e5989e Mon Sep 17 00:00:00 2001
From: Thadeu Lima de Souza Cascardo <[email protected]>
Date: Tue, 8 Sep 2026 16:59:51 -0300
Subject: [PATCH] Revert "drm/amdgpu: debugfs: avoid extra EOLs in
amdgpu_gem_info"

This reverts commit c119d05a36a884482decc67e55944648f8cba97e.

It removes the newline even when there are no fences attached to a struct dma_resv, leading to multiple BOs being output on the same line, making the debug file less readable, not more as the commit intended.

(cherry picked from commit a2aafaeb2be13ed3c893e6a44a3a5d26b251ae6a)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1 -2
index 5d9d137209b6..1b6c32a177fb 100644
@@ -1701,9 +1701,8 @@ u64 amdgpu_bo_print_info(int id, struct amdgpu_bo *bo, struct seq_file *m)
 	if (dma_resv_trylock(bo->tbo.base.resv)) {
 		dma_resv_describe(bo->tbo.base.resv, m);
 		dma_resv_unlock(bo->tbo.base.resv);
-	} else {
-		seq_puts(m, "\n");
 	}
+	seq_puts(m, "\n");
 
 	return size;
 }
maintainer
#1 lore raw

PATCH 1/2 drm/amdgpu: debugfs: avoid extra EOLs in amdgpu_gem_info

From: Michał Mirosław <[email protected]>

[ Upstream commit c119d05a36a884482decc67e55944648f8cba97e ]

Stable-dep-of: 829157e762ed ("Revert "drm/amdgpu: debugfs: avoid extra EOLs in amdgpu_gem_info"")

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +2 -1
index 718937777e532..d4a9d5e8fb429 100644
@@ -1699,8 +1699,9 @@ u64 amdgpu_bo_print_info(int id, struct amdgpu_bo *bo, struct seq_file *m)
 	if (dma_resv_trylock(bo->tbo.base.resv)) {
 		dma_resv_describe(bo->tbo.base.resv, m);
 		dma_resv_unlock(bo->tbo.base.resv);
+	} else {
+		seq_puts(m, "\n");
 	}
-	seq_puts(m, "\n");
 
 	return size;
 }
Signature · 1 line
2.53.0
maintainer
#2 lore raw

PATCH 2/2 Revert "drm/amdgpu: debugfs: avoid extra EOLs in amdgpu_gem_info"

From: Thadeu Lima de Souza Cascardo <[email protected]>

[ Upstream commit 829157e762ed043e28ecb2e9f3c7d22b54e5989e ]

This reverts commit c119d05a36a884482decc67e55944648f8cba97e.

It removes the newline even when there are no fences attached to a struct dma_resv, leading to multiple BOs being output on the same line, making the debug file less readable, not more as the commit intended.

(cherry picked from commit a2aafaeb2be13ed3c893e6a44a3a5d26b251ae6a)
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1 -2
index d4a9d5e8fb429..718937777e532 100644
@@ -1699,9 +1699,8 @@ u64 amdgpu_bo_print_info(int id, struct amdgpu_bo *bo, struct seq_file *m)
 	if (dma_resv_trylock(bo->tbo.base.resv)) {
 		dma_resv_describe(bo->tbo.base.resv, m);
 		dma_resv_unlock(bo->tbo.base.resv);
-	} else {
-		seq_puts(m, "\n");
 	}
+	seq_puts(m, "\n");
 
 	return size;
 }
Signature · 1 line
2.53.0