perf test: stat metrics cgroup strip possible slash from cgroup name
Ian Rogers
reviewerPATCH 1/1 perf test: stat metrics cgroup strip possible slash from cgroup name
The grep to match cgroup name in metric output assumes no leading / on the cgroup name, however, cgroups in /proc/self/cgroup may have a leading /. Strip the / if it exists to avoid failures to match the cgroup name in the perf stat output.
--- tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++ 1 file changed, 7 insertions(+)
tools/perf/tests/shell/stat_metrics_cgrp.sh +7 -0
@@ -86,6 +86,13 @@ check_metric_reported() for cgrp in "${cgrps[@]}"; do # Find metric lines for this cgroup + case "$cgrp" in + /) # The root cgroup, leave unchanged. + ;; + /*) # Strip any starting slashes. + cgrp="${cgrp#/}" + ;; + esac # We use exact cgroup match with surrounding commas local cgrp_lines cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
Signature · 1 line
2.55.0.1082.g2b9226bbc0-goog
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
The grep to match cgroup name in metric output assumes no leading / on the cgroup name, however, cgroups in
/proc/self/cgroupmay have a leading /. Strip the / if it exists to avoid failures to match the cgroup name in the perf stat output.Signed-off-by Ian Rogers <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Ian Rogers
reviewerQuoted 7 lines · Ian Rogers
The grep to match cgroup name in metric output assumes no leading / on the cgroup name, however, cgroups in
/proc/self/cgroupmay have a leading /. Strip the / if it exists to avoid failures to match the cgroup name in the perf stat output.Signed-off-by Ian Rogers <[email protected]>
Ping.
Thanks,
Ian
Quoted 25 lines
--- tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++ 1 file changed, 7 insertions(+)tools/perf/tests/shell/stat_metrics_cgrp.sh +7
-1@@ -86,6 +86,13 @@ check_metric_reported() for cgrp in "${cgrps[@]}"; do # Find metric lines for this cgroup + case "$cgrp" in + /) # The root cgroup, leave unchanged. + ;; + /*) # Strip any starting slashes. + cgrp="${cgrp#/}" + ;; + esac # We use exact cgroup match with surrounding commas local cgrp_lines cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true) --2.55.0.1082.g2b9226bbc0-goog
Quoted 10 lines · Ian Rogers
Quoted 7 lines · Ian Rogers
The grep to match cgroup name in metric output assumes no leading / on the cgroup name, however, cgroups in
/proc/self/cgroupmay have a leading /. Strip the / if it exists to avoid failures to match the cgroup name in the perf stat output.Signed-off-by Ian Rogers <[email protected]>Ping.
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
Quoted 6 lines · Ian Rogers
The grep to match cgroup name in metric output assumes no leading / on the cgroup name, however, cgroups in
/proc/self/cgroupmay have a leading /. Strip the / if it exists to avoid failures to match the cgroup name in the perf stat output.Signed-off-by Ian Rogers <[email protected]>
Thanks,
Namhyung
Quoted 25 lines
--- tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++ 1 file changed, 7 insertions(+)tools/perf/tests/shell/stat_metrics_cgrp.sh +7
-0@@ -86,6 +86,13 @@ check_metric_reported() for cgrp in "${cgrps[@]}"; do # Find metric lines for this cgroup + case "$cgrp" in + /) # The root cgroup, leave unchanged. + ;; + /*) # Strip any starting slashes. + cgrp="${cgrp#/}" + ;; + esac # We use exact cgroup match with surrounding commas local cgrp_lines cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)Signature · 1 line
2.55.0.1082.g2b9226bbc0-goog