pinctrl: qcom: tlmm-test: Add const to reg_names allocation type
Subsystems (5)
PATCH 1/1 pinctrl: qcom: tlmm-test: Add const to reg_names allocation type
From: Kees Cook <[email protected]>
In preparation for converting the kmalloc family of allocators to the type-aware kmalloc_obj family, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (The kmalloc family returns "void *", which can be implicitly cast to any pointer type.)
The assigned type is "const char **", but the converted allocation type would be "char **", which is the same type without the const qualifier. As there is no general way to safely add const qualifiers, take the size from the assignment target instead. No change in allocation size results.
Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:drivers/pinctrl/qcom/tlmm-test.o
---
Cc: Bartosz Golaszewski <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
--- drivers/pinctrl/qcom/tlmm-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/tlmm-test.c +1 -1
@@ -587,7 +587,7 @@ static int tlmm_reg_base(struct device_node *tlmm, struct resource *res)return count; } - reg_names =kcalloc (count,sizeof (char *),GFP_KERNEL ); + reg_names =kcalloc (count,sizeof (*reg_names),GFP_KERNEL );if (!reg_names)return -ENOMEM ;
Signature · 1 line
2.34.1
Quoted 14 lines · Kees Cook
From: Kees Cook <[email protected]>
In preparation for converting the kmalloc family of allocators to the type-aware
kmalloc_objfamily, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (The kmalloc family returns "void *", which can be implicitly cast to any pointer type.)The assigned type is "const char **", but the converted allocation type would be "char **", which is the same type without the const qualifier. As there is no general way to safely add const qualifiers, take the size from the assignment target instead. No change in allocation size results.
Quoted 6 lines
Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
drivers/pinctrl/qcom/tlmm-test.oAssisted-by LLM coccinelleSigned-off-by Kees Cook <[email protected]>---
Konrad
Bartosz Golaszewski
AppliedQuoted 6 lines · Kees Cook
In preparation for converting the kmalloc family of allocators to the type-aware
kmalloc_objfamily, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (The kmalloc family returns "void *", which can be implicitly cast to any pointer type.)
Quoted 7 lines
The assigned type is "const char **", but the converted allocation type would be "char **", which is the same type without the const qualifier. As there is no general way to safely add const qualifiers, take the size from the assignment target instead. No change in allocation size results.
[...]
Applied, thanks!
[1/1] pinctrl: qcom: tlmm-test: Add const to reg_names allocation type
https://git.kernel.org/brgl/c/4d7c9430a26aea6a69521af3aa2d78dd5bc8d3ed
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>