Skip to contentSkip to conversation

Documentation: Add missing KVM s390 crypto attributes

PATCH In review Eric Farman 4 participants 4 messages Sep 18 – Sep 22

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Add missing KVM s390 crypto attributes

Device attributes to enable/disable the AP interpretive execution support for crypto were added to KVM several years ago, but they weren't added to the documentation itself.

Fixes 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
---
 Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Documentation/virt/kvm/devices/vm.rst +18 -0
index a4d39fa1b083..78e63eb9994e 100644
@@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
 :Parameters: none
 :Returns:    0
 
+4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to enable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
+4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to disable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
 5. GROUP: KVM_S390_VM_MIGRATION
 ===============================
 
Signature · 1 line
2.53.0
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines

Device attributes to enable/disable the AP interpretive execution support for crypto were added to KVM several years ago, but they weren't added to the documentation itself.

Fixes 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Eric Farman
Quoted 6 lines · Eric Farman

Device attributes to enable/disable the AP interpretive execution support for crypto were added to KVM several years ago, but they weren't added to the documentation itself.

Fixes 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")
Quoted 33 lines
---
  Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)
Documentation/virt/kvm/devices/vm.rst +18 -0
index a4d39fa1b083..78e63eb9994e 100644
@@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
  :Parameters: none
  :Returns:    0
 
+4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to enable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
+4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to disable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
  5. GROUP: KVM_S390_VM_MIGRATION
  ===============================
 
#3 lore raw
In reply to Eric Farman

Am 18.09.26 um 16:51 schrieb Eric Farman:

Quoted 6 lines

Device attributes to enable/disable the AP interpretive execution support for crypto were added to KVM several years ago, but they weren't added to the documentation itself.

Fixes 37940fb0b6a2 ("KVM: s390: device attrs to enable/disable AP interpretation")

thanks. Unless Jonathan objects, I will take that via the kvms390 tree.

Quoted 33 lines
---
  Documentation/virt/kvm/devices/vm.rst | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)
Documentation/virt/kvm/devices/vm.rst +18 -0
index a4d39fa1b083..78e63eb9994e 100644
@@ -280,6 +280,24 @@ Allows user space to disable dea key wrapping, clearing the wrapping key.
  :Parameters: none
  :Returns:    0
 
+4.5. ATTRIBUTE: KVM_S390_VM_CRYPTO_ENABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to enable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
+4.6. ATTRIBUTE: KVM_S390_VM_CRYPTO_DISABLE_APIE (w/o)
+-------------------------------------------------------
+
+Allows user space to disable AP interpretive execution.
+
+:Parameters: none
+:Returns:    0 for success
+	     -EOPNOTSUPP if AP instructions not available for guest
+
  5. GROUP: KVM_S390_VM_MIGRATION
  ===============================