Skip to contentSkip to conversation

staging: greybus: gpio: add comment describing irq_lock mutex

PATCH In review UgwuRhema 2 participants 2 messages Sep 21

Subsystems (3)
lore
Share & tools
lore

UgwuRhema

author
#0 lore raw

PATCH 1/1 staging: greybus: gpio: add comment describing irq_lock mutex

Add a description comment for irq_lock to clarify what the mutex protects and satisfy checkpatch checks.

---
 drivers/staging/greybus/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/gpio.c +1 -1
index 12185f7a9..7f19b3275 100644
@@ -39,7 +39,7 @@ struct gb_gpio_controller {
 
 	struct gpio_chip	chip;
 	struct irq_chip		irqc;
-	struct mutex		irq_lock;
+	struct mutex		irq_lock; /* protects IRQ configuration and hardware state */
 };
 
 static struct gpio_chip *irq_data_to_gpio_chip(struct irq_data *d)
Signature · 1 line
2.55.0
#1 lore raw
Quoted 13 lines · UgwuRhema

Add a description comment for irq_lock to clarify what the mutex protects and satisfy checkpatch checks.

---
 drivers/staging/greybus/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/gpio.c +0 -0
index 12185f7a9..7f19b3275 100644

drivers/staging/greybus/gpio.c struct gb_gpio_controller { · line 42

Quoted 5 lines
drivers/staging/greybus/gpio.c +1 -1
@@ -39,7 +39,7 @@ struct gb_gpio_controller {
 
 	struct gpio_chip	chip;
 	struct irq_chip		irqc;
-	struct mutex		irq_lock;
+	struct mutex		irq_lock; /* protects IRQ configuration and hardware state */

No, I wouldn't say this is accurate at all.

regards,
dan carpenter

Quoted 2 lines
drivers/staging/greybus/gpio.c +0 -0
 };