Skip to contentSkip to conversation

dt-bindings: soc: mediatek: Allow pwrap regs

PATCH In review Rob Herring (Arm) 3 participants 4 messages Sep 21 – Sep 22

Subsystems (2)
Device tree bindings Arm MediaTek
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: soc: mediatek: Allow pwrap regs

The MT7622 PMIC wrapper has a regulators child node. Add the child schema reference so regulator subnodes are evaluated by the MT6380 regulator binding instead of being rejected.

Assisted-by Codex:gpt-5-5
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +3 -0
index e7c4a3984c60..79b755858bad 100644
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
+
 required:
   - compatible
   - reg
Signature · 1 line
2.53.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing referenced mediatek,mt6380-regulator.yaml schema --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing referenced mediatek,mt6380-regulator.yaml schema --

commit 73b0295b13e9c91b5f296071d21498bc710f649e
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: soc: mediatek: Allow pwrap regs

This commit updates the MT7622 PMIC wrapper binding to add a child schema reference for regulators. This change routes regulator subnodes to the MT6380 regulator binding for evaluation.

Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml properties: · line 109

Quoted 9 lines
Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +2 -0
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#

[Severity: Low]
Does this introduce an invalid schema reference for the regulators property?

It appears the referenced mediatek,mt6380-regulator.yaml file does not exist in the repository, as the MT6380 regulator binding is currently a legacy text file (mt6380-regulator.txt).

This can cause make dt_binding_check to fail when resolving the cross-reference or silently skip validating the regulators node. Subsequent patches in the series also do not appear to add the missing YAML file.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#3 lore raw
In reply to Rob Herring (Arm)
Quoted 15 lines · Rob Herring (Arm)

The MT7622 PMIC wrapper has a regulators child node. Add the child schema reference so regulator subnodes are evaluated by the MT6380 regulator binding instead of being rejected.

Assisted-by Codex:gpt-5-5
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +0 -0
index e7c4a3984c60..79b755858bad 100644

Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml properties: · line 109

Quoted 5 lines
Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +2 -0
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#

Err, this needs the conversion. Dropping this patch.

Rob