Skip to contentSkip to conversation

dt-bindings: panel: Add JDI NT35596S

PATCH In review Rob Herring (Arm) 3 participants 4 messages Sep 21 – Sep 23

Subsystems (4)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: panel: Add JDI NT35596S

Add a schema for the JDI FHD NT35596S MIPI-DSI panel used by the Xiaomi Mi Mix 2S. The schema documents the DSI reg value, reset GPIO, backlight, graph port, and vddio, vddpos, and vddneg supplies present in the DTS.

Assisted-by LLM
---
 .../display/panel/jdi,fhd-nt35596s.yaml       | 73 +++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +73 -0
new file mode 100644
index 000000000000..aefc9ae5d8ab
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/jdi,fhd-nt35596s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: JDI FHD NT35596S MIPI-DSI Panel
+
+maintainers:
+  - Molly Sophia <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: jdi,fhd-nt35596s
+
+  reg:
+    maxItems: 1
+
+  backlight: true
+  reset-gpios: true
+
+  vddio-supply:
+    description: I/O voltage rail
+
+  vddneg-supply:
+    description: Negative source voltage rail
+
+  vddpos-supply:
+    description: Positive source voltage rail
+
+  port: true
+
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - vddio-supply
+  - vddneg-supply
+  - vddpos-supply
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "jdi,fhd-nt35596s";
+            reg = <0>;
+
+            reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+            vddio-supply = <&vreg_l14a_1p8>;
+            backlight = <&pmi8998_wled>;
+            vddpos-supply = <&lab>;
+            vddneg-supply = <&ibb>;
+
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&mdss_dsi0_out>;
+                };
+            };
+        };
+    };
+
+...
Signature · 1 line
2.53.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: incorrect use of additionalProperties instead of unevaluatedProperties --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of additionalProperties instead of unevaluatedProperties --

commit e0dc4d49c687f6d5568ce2c31031086acb6cd5e6
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: panel: Add JDI NT35596S

This commit adds a new device tree binding schema for the JDI FHD NT35596S MIPI-DSI panel. It documents properties such as the DSI reg value, reset GPIO, backlight, port, and various power supplies.

Quoted 5 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +0 -0
new file mode 100644
index 0000000000000..aefc9ae5d8abd

[ ... ]

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +6 -0
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: jdi,fhd-nt35596s

[ ... ]

Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml line 45

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - vddio-supply
+  - vddneg-supply
+  - vddpos-supply
+  - port
+
+additionalProperties: false

[Severity: Low]
Does the use of additionalProperties: false here incorrectly reject standard inherited panel properties?

Because this schema references panel-common.yaml in an allOf block, additionalProperties does not traverse the $ref references. This blocks standard properties like rotation and forces the redundant declaration of properties like backlight, reset-gpios, and port just to pass static JSON schema validation during a make dt_binding_check.

Should this use unevaluatedProperties: false instead?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw
Quoted 45 lines · On Mon, Sep 21, 2026 at 11:31:27PM +0000, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of additionalProperties instead of unevaluatedProperties --

commit e0dc4d49c687f6d5568ce2c31031086acb6cd5e6
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: panel: Add JDI NT35596S

This commit adds a new device tree binding schema for the JDI FHD NT35596S MIPI-DSI panel. It documents properties such as the DSI reg value, reset GPIO, backlight, port, and various power supplies.

Quoted 5 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +0 -0
new file mode 100644
index 0000000000000..aefc9ae5d8abd

[ ... ]

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +6 -0
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: jdi,fhd-nt35596s

[ ... ]

Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml line 45

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - vddio-supply
+  - vddneg-supply
+  - vddpos-supply
+  - port
+
+additionalProperties: false

[Severity: Low]
Does the use of additionalProperties: false here incorrectly reject standard inherited panel properties?

Quoted 7 lines

Because this schema references panel-common.yaml in an allOf block, additionalProperties does not traverse the $ref references. This blocks standard properties like rotation and forces the redundant declaration of properties like backlight, reset-gpios, and port just to pass static JSON schema validation during a make dt_binding_check.

Should this use unevaluatedProperties: false instead?

This seems to be the new thing that Sashiko whines about, any binding I see with additionalProperties: false seems to get complained about.

author maintainer
#3 lore raw
Quoted 52 lines · Conor Dooley
Quoted 51 lines · On Mon, Sep 21, 2026 at 11:31:27PM +0000, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of additionalProperties instead of unevaluatedProperties --

commit e0dc4d49c687f6d5568ce2c31031086acb6cd5e6
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: panel: Add JDI NT35596S

This commit adds a new device tree binding schema for the JDI FHD NT35596S MIPI-DSI panel. It documents properties such as the DSI reg value, reset GPIO, backlight, port, and various power supplies.

Quoted 5 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +0 -0
new file mode 100644
index 0000000000000..aefc9ae5d8abd

[ ... ]

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +6 -0
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: jdi,fhd-nt35596s

[ ... ]

Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml line 45

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - vddio-supply
+  - vddneg-supply
+  - vddpos-supply
+  - port
+
+additionalProperties: false

[Severity: Low]
Does the use of additionalProperties: false here incorrectly reject standard inherited panel properties?

Because this schema references panel-common.yaml in an allOf block, additionalProperties does not traverse the $ref references. This blocks standard properties like rotation and forces the redundant declaration of properties like backlight, reset-gpios, and port just to pass static JSON schema validation during a make dt_binding_check.

Quoted 4 lines
Quoted 1 line

Should this use unevaluatedProperties: false instead?

This seems to be the new thing that Sashiko whines about, any binding I see with additionalProperties: false seems to get complained about.

That and needing labels to be resolved in examples it consistently gets wrong. Probably need to work on the guidance...

Rob