Skip to contentSkip to conversation

dt-bindings: mfd: Allow MT6360 interrupt flags

PATCH Applied Rob Herring (Arm) 3 participants 4 messages Sep 21 – Oct 13

Subsystems (3)
Device tree bindings Arm MediaTek Multifunction devices (MFD)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mfd: Allow MT6360 interrupt flags

MT6360 interrupt controllers use either one interrupt cell or two cells, with the optional second cell carrying trigger flags. Allow both forms.

Assisted-by LLM
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml +3 -2
index fb65abf30d57..828ed7f558f6 100644
@@ -33,9 +33,10 @@ properties:
   interrupt-controller: true
 
   "#interrupt-cells":
-    const: 1
+    enum: [1, 2]
     description:
-      The first cell is the IRQ number.
+      The first cell is the IRQ number. The optional second cell is the IRQ
+      trigger type.
 
   regulators:
     $ref: /schemas/regulator/mt6360-regulator.yaml#
Signature · 1 line
2.53.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint --

commit 3c231e0793c5c72fac7dc860b2b89ed70228f7a3
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: mfd: Allow MT6360 interrupt flags

This commit updates the MT6360 device tree binding to allow the interrupt controller to use either one or two cells. It replaces the constant cell count constraint with an enum to support an optional second cell for trigger flags.

Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml properties: · line 36

Quoted 10 lines
Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml +1 -1
index fb65abf30d57b..828ed7f558f66 100644
@@ -33,9 +33,10 @@ properties:
   interrupt-controller: true
 
   "#interrupt-cells":
-    const: 1
+    enum: [1, 2]

[Severity: Medium]
Does this change conflict with the device tree binding subsystem rules?

The subsystem guidelines mandate that cell-count properties like #interrupt-cells must use a const constraint rather than an enum to prevent ambiguous or variable cell sizes during schema validation.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#2 lore raw
Quoted 21 lines · On Mon, Sep 21, 2026 at 11:32:49PM +0000, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint --

commit 3c231e0793c5c72fac7dc860b2b89ed70228f7a3
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: mfd: Allow MT6360 interrupt flags

This commit updates the MT6360 device tree binding to allow the interrupt controller to use either one or two cells. It replaces the constant cell count constraint with an enum to support an optional second cell for trigger flags.

Quoted 7 lines
Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml +0 -0
index fb65abf30d57b..828ed7f558f66 100644
@@ -33,9 +33,10 @@ properties:
   interrupt-controller: true
Quoted 6 lines

Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml properties: · line 36

Quoted 3 lines
Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml +1 -1
   "#interrupt-cells":
-    const: 1
+    enum: [1, 2]

[Severity: Medium]
Does this change conflict with the device tree binding subsystem rules?

No.

Quoted 3 lines

The subsystem guidelines mandate that cell-count properties like #interrupt-cells must use a const constraint rather than an enum to prevent ambiguous or variable cell sizes during schema validation.

There's always exceptions to guidelines...

Rob

maintainer Applied
#3 lore raw

Re: (subset) [PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

In reply to Rob Herring (Arm)
Quoted 3 lines · Rob Herring (Arm)

MT6360 interrupt controllers use either one interrupt cell or two cells, with the optional second cell carrying trigger flags. Allow both forms.

Applied, thanks!

[1/1] dt-bindings: mfd: Allow MT6360 interrupt flags

      commit: ee76e520857352ec34aaa5786db41610a4a25de7

--
Lee Jones [李琼斯]